chore: Bump workspace-tools to 0.27.0#24914
Merged
ling1726 merged 2 commits intomicrosoft:masterfrom Sep 23, 2022
Merged
Conversation
Follow up of microsoft#24881 which upated beachball to a version that required ^0.27.0. The API broke multiple times between our current version of beachball and the one upgrade. Fixes beachball in our repo
micahgodbolt
approved these changes
Sep 22, 2022
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 22bc5f9ecc73b4b18c92f31932fb72334a594390 (build) |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 8481159:
|
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 1281 | 1296 | 5000 | |
| Button | mount | 917 | 940 | 5000 | |
| FluentProvider | mount | 1497 | 1499 | 5000 | |
| FluentProviderWithTheme | mount | 573 | 578 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 552 | 550 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 569 | 580 | 10 | |
| MakeStyles | mount | 1969 | 1986 | 50000 | |
| SpinButton | mount | 2367 | 2339 | 5000 |
Collaborator
📊 Bundle size reportUnchanged fixtures
|
Collaborator
Perf Analysis (
|
| Scenario | Current PR Ticks | Baseline Ticks | Ratio | Regression Analysis |
|---|---|---|---|---|
| PopupMinimalPerf.default | 560 | 561 | 1:1 | analysis |
Perf tests with no regressions
| Scenario | Current PR Ticks | Baseline Ticks | Ratio |
|---|---|---|---|
| ListCommonPerf.default | 534 | 493 | 1.08:1 |
| RefMinimalPerf.default | 196 | 185 | 1.06:1 |
| AttachmentMinimalPerf.default | 130 | 124 | 1.05:1 |
| TextAreaMinimalPerf.default | 419 | 399 | 1.05:1 |
| PortalMinimalPerf.default | 142 | 137 | 1.04:1 |
| TextMinimalPerf.default | 308 | 297 | 1.04:1 |
| CarouselMinimalPerf.default | 362 | 350 | 1.03:1 |
| FormMinimalPerf.default | 334 | 325 | 1.03:1 |
| LayoutMinimalPerf.default | 316 | 308 | 1.03:1 |
| ListWith60ListItems.default | 512 | 498 | 1.03:1 |
| ReactionMinimalPerf.default | 339 | 329 | 1.03:1 |
| AvatarMinimalPerf.default | 166 | 162 | 1.02:1 |
| BoxMinimalPerf.default | 305 | 300 | 1.02:1 |
| CardMinimalPerf.default | 466 | 457 | 1.02:1 |
| ChatDuplicateMessagesPerf.default | 234 | 230 | 1.02:1 |
| ChatWithPopoverPerf.default | 304 | 298 | 1.02:1 |
| DropdownManyItemsPerf.default | 541 | 533 | 1.02:1 |
| HeaderSlotsPerf.default | 681 | 670 | 1.02:1 |
| ListNestedPerf.default | 473 | 465 | 1.02:1 |
| AnimationMinimalPerf.default | 472 | 467 | 1.01:1 |
| ButtonMinimalPerf.default | 141 | 139 | 1.01:1 |
| ButtonOverridesMissPerf.default | 1025 | 1010 | 1.01:1 |
| ChatMinimalPerf.default | 635 | 628 | 1.01:1 |
| DialogMinimalPerf.default | 689 | 681 | 1.01:1 |
| DropdownMinimalPerf.default | 2193 | 2162 | 1.01:1 |
| ImageMinimalPerf.default | 337 | 335 | 1.01:1 |
| ItemLayoutMinimalPerf.default | 967 | 962 | 1.01:1 |
| LabelMinimalPerf.default | 339 | 336 | 1.01:1 |
| ListMinimalPerf.default | 461 | 457 | 1.01:1 |
| RosterPerf.default | 1707 | 1691 | 1.01:1 |
| SegmentMinimalPerf.default | 304 | 302 | 1.01:1 |
| StatusMinimalPerf.default | 614 | 606 | 1.01:1 |
| ToolbarMinimalPerf.default | 795 | 786 | 1.01:1 |
| ButtonSlotsPerf.default | 421 | 421 | 1:1 |
| CheckboxMinimalPerf.default | 1528 | 1524 | 1:1 |
| DividerMinimalPerf.default | 312 | 313 | 1:1 |
| EmbedMinimalPerf.default | 2640 | 2627 | 1:1 |
| GridMinimalPerf.default | 300 | 301 | 1:1 |
| LoaderMinimalPerf.default | 521 | 520 | 1:1 |
| MenuMinimalPerf.default | 742 | 740 | 1:1 |
| ProviderMergeThemesPerf.default | 992 | 990 | 1:1 |
| ProviderMinimalPerf.default | 322 | 321 | 1:1 |
| SliderMinimalPerf.default | 1247 | 1243 | 1:1 |
| SplitButtonMinimalPerf.default | 3269 | 3261 | 1:1 |
| TableManyItemsPerf.default | 1561 | 1565 | 1:1 |
| TreeMinimalPerf.default | 695 | 696 | 1:1 |
| InputMinimalPerf.default | 841 | 847 | 0.99:1 |
| IconMinimalPerf.default | 562 | 569 | 0.99:1 |
| TableMinimalPerf.default | 359 | 361 | 0.99:1 |
| CustomToolbarPrototype.default | 2166 | 2178 | 0.99:1 |
| AccordionMinimalPerf.default | 123 | 125 | 0.98:1 |
| AlertMinimalPerf.default | 223 | 227 | 0.98:1 |
| AttachmentSlotsPerf.default | 850 | 869 | 0.98:1 |
| HeaderMinimalPerf.default | 310 | 317 | 0.98:1 |
| MenuButtonMinimalPerf.default | 1329 | 1352 | 0.98:1 |
| RadioGroupMinimalPerf.default | 386 | 393 | 0.98:1 |
| TooltipMinimalPerf.default | 1839 | 1872 | 0.98:1 |
| TreeWith60ListItems.default | 133 | 136 | 0.98:1 |
| VideoMinimalPerf.default | 614 | 625 | 0.98:1 |
| DatepickerMinimalPerf.default | 4607 | 4733 | 0.97:1 |
| SkeletonMinimalPerf.default | 300 | 310 | 0.97:1 |
| FlexMinimalPerf.default | 240 | 251 | 0.96:1 |
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| BaseButton | mount | 1205 | 1186 | 5000 | |
| Breadcrumb | mount | 2830 | 2807 | 1000 | |
| Checkbox | mount | 2675 | 2650 | 5000 | |
| CheckboxBase | mount | 2362 | 2370 | 5000 | |
| ChoiceGroup | mount | 4245 | 4279 | 5000 | |
| ComboBox | mount | 1173 | 1185 | 1000 | |
| CommandBar | mount | 9352 | 9204 | 1000 | |
| ContextualMenu | mount | 10228 | 10098 | 1000 | |
| DefaultButton | mount | 1369 | 1373 | 5000 | |
| DetailsRow | mount | 3382 | 3342 | 5000 | |
| DetailsRowFast | mount | 3408 | 3380 | 5000 | |
| DetailsRowNoStyles | mount | 3272 | 3248 | 5000 | |
| Dialog | mount | 2961 | 3001 | 1000 | |
| DocumentCardTitle | mount | 580 | 563 | 1000 | |
| Dropdown | mount | 3201 | 3175 | 5000 | |
| FocusTrapZone | mount | 1951 | 1971 | 5000 | |
| FocusZone | mount | 1884 | 1925 | 5000 | |
| GroupedList | mount | 47409 | 53895 | 2 | |
| GroupedList | virtual-rerender | 23098 | 22884 | 2 | |
| GroupedList | virtual-rerender-with-unmount | 82083 | 81458 | 2 | |
| GroupedListV2 | mount | 565 | 547 | 2 | |
| GroupedListV2 | virtual-rerender | 530 | 538 | 2 | |
| GroupedListV2 | virtual-rerender-with-unmount | 561 | 552 | 2 | |
| IconButton | mount | 1796 | 1790 | 5000 | |
| Label | mount | 737 | 757 | 5000 | |
| Layer | mount | 4122 | 4130 | 5000 | |
| Link | mount | 841 | 857 | 5000 | |
| MenuButton | mount | 1613 | 1629 | 5000 | |
| MessageBar | mount | 2347 | 2296 | 5000 | |
| Nav | mount | 3079 | 3111 | 1000 | |
| OverflowSet | mount | 1427 | 1401 | 5000 | |
| Panel | mount | 2495 | 2476 | 1000 | |
| Persona | mount | 1239 | 1242 | 1000 | |
| Pivot | mount | 1542 | 1506 | 1000 | |
| PrimaryButton | mount | 1505 | 1495 | 5000 | |
| Rating | mount | 6971 | 6991 | 5000 | |
| SearchBox | mount | 1505 | 1506 | 5000 | |
| Shimmer | mount | 2919 | 2886 | 5000 | |
| Slider | mount | 2116 | 2146 | 5000 | |
| SpinButton | mount | 4330 | 4284 | 5000 | |
| Spinner | mount | 821 | 834 | 5000 | |
| SplitButton | mount | 2842 | 2865 | 5000 | |
| Stack | mount | 892 | 902 | 5000 | |
| StackWithIntrinsicChildren | mount | 2255 | 2216 | 5000 | |
| StackWithTextChildren | mount | 4932 | 4889 | 5000 | |
| SwatchColorPicker | mount | 9521 | 9584 | 5000 | |
| TagPicker | mount | 2355 | 2323 | 5000 | |
| TeachingBubble | mount | 75292 | 73966 | 5000 | |
| Text | mount | 823 | 828 | 5000 | |
| TextField | mount | 1560 | 1559 | 5000 | |
| ThemeProvider | mount | 1447 | 1450 | 5000 | |
| ThemeProvider | virtual-rerender | 1146 | 1134 | 5000 | |
| ThemeProvider | virtual-rerender-with-unmount | 1997 | 2000 | 5000 | |
| Toggle | mount | 1139 | 1124 | 5000 | |
| buttonNative | mount | 546 | 543 | 5000 |
Hotell
approved these changes
Sep 23, 2022
Contributor
Hotell
left a comment
There was a problem hiding this comment.
bump with capital B! waat
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Sep 24, 2022
* master: (29 commits) chore(react-tooltip): update package scaffold (microsoft#24927) chore(react-popover): update package scaffold (microsoft#24925) chore(react-overflow): update package scaffold (microsoft#24926) chore(react-menu): update package scaffold (microsoft#24924) applying package updates chore: Bump workspace-tools to 0.27.0 (microsoft#24914) fix: Make Menu openOnHover prop work again (microsoft#24899) stress test: convert cli scripts to typescript (microsoft#24915) update package manifest to only include v8 controls (microsoft#24839) Stress Test: add random tree (microsoft#24896) chore: Expand scope of dependency mismatch generator (microsoft#24880) chore: run dependency mismatch generator in release pipeline (microsoft#24881) chore: scaffolds react-trigger package (microsoft#24887) applying package updates chore: a11y docs structure update (microsoft#24871) feat: add popupProps to Modal component to allow override internal Popup props (microsoft#24693) fix: Set github user in nightly release pipeline (microsoft#24850) chore(react-aria): restructure folder organization (microsoft#24884) ci(github): fix invalid json string in issues.yml v2 (microsoft#24886) Add react-components/unstable to tsconfig aliases (microsoft#24878) ...
NotWoods
pushed a commit
to NotWoods/fluentui
that referenced
this pull request
Nov 18, 2022
* chore: Bump workspace-tools to 0.27.0 Follow up of microsoft#24881 which upated beachball to a version that required ^0.27.0. The API broke multiple times between our current version of beachball and the one upgrade. Fixes beachball in our repo * remove resolution for workspace-tools
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up of #24881 which updated beachball to a version that required ^0.27.0. The API broke multiple times between our current version of beachball and the one upgraded to.
Fixes beachball in our repo