feat: add helper types to assist DOM element handling#24722
Merged
bsunderhus merged 1 commit intomicrosoft:masterfrom Sep 9, 2022
Merged
feat: add helper types to assist DOM element handling#24722bsunderhus merged 1 commit intomicrosoft:masterfrom
bsunderhus merged 1 commit intomicrosoft:masterfrom
Conversation
Collaborator
📊 Bundle size reportUnchanged fixtures
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit c7cc4c8:
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: d653291a07d843930da4023e599177686a1e6e1d (build) |
d7d8133 to
c7cc4c8
Compare
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| SpinButton | mount | 3820 | 2491 | 5000 | Possible regression |
All results
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 1318 | 1285 | 5000 | |
| Button | mount | 938 | 951 | 5000 | |
| FluentProvider | mount | 1472 | 1552 | 5000 | |
| FluentProviderWithTheme | mount | 633 | 630 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 579 | 590 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 1842 | 626 | 10 | |
| MakeStyles | mount | 1902 | 1920 | 50000 | |
| SpinButton | mount | 3820 | 2491 | 5000 | Possible regression |
Contributor
|
why are normal unions/intersections not enough ? |
Contributor
Author
Unfortunately it wouldn't be enough as |
ling1726
approved these changes
Sep 9, 2022
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Sep 9, 2022
* master: (63 commits) feat: add helper types to assist DOM element handling (microsoft#24722) applying package updates Textarea/hc bug (microsoft#24701) Fix null ref in use slider (microsoft#24728) Add Field unit tests, and remove snapshot tests (microsoft#24706) Stress Test: add build commands (microsoft#24575) Coachmark - useOffsetHeight should cause re-render on each set state to match v7 functionality (microsoft#24702) Implement screener tests for Field components (microsoft#24684) Update Field types to clean up react-field.api.md (microsoft#24703) fix(Popup): remove rotate(360deg) from PopupContent content styles (microsoft#24432) fix(FocusZone): should reset tabindex when focus is outside the zone with prop `shouldResetActiveElementWhenTabFromZone` (microsoft#24463) Fix greyed out legend key contrast ratio (microsoft#24714) fix: Portal compat should apply `focus-visible` ponyfill (microsoft#24712) Fix artifact error (microsoft#24717) chore(react-dialog): remove localShorthands in favor of griffel shorthands (microsoft#24715) Skip screener checks for draft PRs with exception of appropriately la… (microsoft#24694) fix: Remove provider classname from focus styles (microsoft#24710) feat: autocontrolled `useTable` hook (microsoft#24688) feat: add dialog properties to getNativeElementProps (microsoft#24698) Using migrate rather than upgrade term (microsoft#24695) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New Behavior
Adds 2 helper types to assist DOM element handling on scenarios that is required to know the element type.
ARIAButtonElementandARIAButtonElementIntersection.ARIAButtonElement
should be used on references definition for example.It's almost equivalent to:
HTMLButtonElement | HTMLAnchorElement | HTMLDivElementARIAButtonElementIntersection
should be used on cases that narrowing down the type is required, for example, an even handler declaration. It's almost equivalent to:
HTMLButtonElement & HTMLAnchorElement & HTMLDivElement