Skip to content

Using migrate rather than upgrade term#24695

Merged
GeoffCoxMSFT merged 5 commits intomicrosoft:masterfrom
GeoffCoxMSFT:upgrade-to-migrate
Sep 7, 2022
Merged

Using migrate rather than upgrade term#24695
GeoffCoxMSFT merged 5 commits intomicrosoft:masterfrom
GeoffCoxMSFT:upgrade-to-migrate

Conversation

@GeoffCoxMSFT
Copy link
Member

@GeoffCoxMSFT GeoffCoxMSFT commented Sep 7, 2022

Changes

  • Updated documentation to use the term migrate (migrates, migrated, migration) instead of upgrade.
  • Updated the package.json description for the public-docsite-v9

Fixes #24676

@GeoffCoxMSFT GeoffCoxMSFT self-assigned this Sep 7, 2022
@GeoffCoxMSFT GeoffCoxMSFT requested review from a team as code owners September 7, 2022 17:22
@github-actions github-actions bot added this to the July Project Cycle Q3 2022 milestone Sep 7, 2022
@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 7, 2022 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit ca2112d:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

spmonahan
spmonahan reviewed Sep 7, 2022
View reviewed changes
GeoffCoxMSFT and others added 3 commits September 7, 2022 13:18
@GeoffCoxMSFT @khmakoto @spmonahan
Apply suggestions from code review
73f2893 
Co-authored-by: Makoto Morimoto <Humberto.Morimoto@microsoft.com>
Co-authored-by: Sean Monahan <seanmonahan@microsoft.com>
@GeoffCoxMSFT
Fix changefile
63d96ce
@GeoffCoxMSFT
Merge branch 'upgrade-to-migrate' of https://github.com/GeoffCoxMSFT/…
ca2112d 
…fluentui into upgrade-to-migrate
@fabricteam
Copy link
Collaborator

fabricteam commented Sep 7, 2022 •
edited
Loading

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover		 189.372 kB
52.027 kB
react-components
react-components: FluentProvider & webLightTheme		 33.317 kB
10.983 kB
🤖 This report was generated against 76e7b6542225187953d18bab5ed858f7065d20ff

@fabricteam
Copy link
Collaborator

fabricteam commented Sep 7, 2022 •
edited
Loading

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 1281 1293 5000
Button mount 973 950 5000
FluentProvider mount 1464 1588 5000
FluentProviderWithTheme mount 621 597 10
FluentProviderWithTheme virtual-rerender 598 598 10
FluentProviderWithTheme virtual-rerender-with-unmount 634 627 10
MakeStyles mount 1755 1894 50000
SpinButton mount 2446 2483 5000

@GeoffCoxMSFT GeoffCoxMSFT enabled auto-merge (squash) September 7, 2022 20:40
@size-auditor
Copy link

size-auditor bot commented Sep 7, 2022

Asset size changes

⚠️ Insufficient baseline data to detect size changes

Unable to find bundle size details for Baseline commit: 76e7b65

Possible causes

  • The baseline build 76e7b65 is broken
  • The Size Auditor run for the baseline build 76e7b65 was not triggered

Recommendations

  • Please merge your branch for this Pull request with the latest master build and commit your changes once again

@GeoffCoxMSFT GeoffCoxMSFT merged commit 4c31b27 into microsoft:master Sep 7, 2022
marcosmoura added a commit to marcosmoura/fluentui that referenced this pull request Sep 9, 2022
@marcosmoura
Merge branch 'master' into marcosmoura/feat/selectable-cards
921d7d1 
* master: (63 commits)
  feat: add helper types to assist DOM element handling (microsoft#24722)
  applying package updates
  Textarea/hc bug (microsoft#24701)
  Fix null ref in use slider (microsoft#24728)
  Add Field unit tests, and remove snapshot tests (microsoft#24706)
  Stress Test: add build commands (microsoft#24575)
  Coachmark - useOffsetHeight should cause re-render on each set state to match v7 functionality (microsoft#24702)
  Implement screener tests for Field components (microsoft#24684)
  Update Field types to clean up react-field.api.md (microsoft#24703)
  fix(Popup): remove rotate(360deg) from PopupContent content styles (microsoft#24432)
  fix(FocusZone): should reset tabindex when focus is outside the zone with prop `shouldResetActiveElementWhenTabFromZone` (microsoft#24463)
  Fix greyed out legend key contrast ratio (microsoft#24714)
  fix: Portal compat should apply `focus-visible` ponyfill (microsoft#24712)
  Fix artifact error (microsoft#24717)
  chore(react-dialog): remove localShorthands in favor of griffel shorthands (microsoft#24715)
  Skip screener checks for draft PRs with exception of appropriately la… (microsoft#24694)
  fix: Remove provider classname from focus styles (microsoft#24710)
  feat: autocontrolled `useTable` hook (microsoft#24688)
  feat: add dialog properties to getNativeElementProps (microsoft#24698)
  Using migrate rather than upgrade term (microsoft#24695)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@spmonahan spmonahan spmonahan approved these changes

@khmakoto khmakoto Awaiting requested review from khmakoto

Assignees

@GeoffCoxMSFT GeoffCoxMSFT

Labels

None yet

Projects

None yet

Milestone

July Project Cycle Q3 2022

Development

Successfully merging this pull request may close these issues.

Update storybook documentation to use 'migration' rather than 'upgrade'

4 participants

@GeoffCoxMSFT @fabricteam @khmakoto @spmonahan