High Contrast Selectors: Fix broken 2nd query#23739
Merged
GeoffCoxMSFT merged 4 commits intomicrosoft:masterfrom Jun 27, 2022
Merged
High Contrast Selectors: Fix broken 2nd query#23739GeoffCoxMSFT merged 4 commits intomicrosoft:masterfrom
GeoffCoxMSFT merged 4 commits intomicrosoft:masterfrom
Conversation
smhigley
approved these changes
Jun 27, 2022
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 2a778dc:
|
Collaborator
📊 Bundle size report🤖 This report was generated against 3fd2ece7f931253f2d2c73143ab7dac3ff816287 |
Asset size changes
Baseline commit: 3fd2ece7f931253f2d2c73143ab7dac3ff816287 (build) |
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| BaseButton | mount | 800 | 754 | 5000 | |
| Breadcrumb | mount | 2106 | 2174 | 1000 | |
| Checkbox | mount | 1296 | 1173 | 5000 | |
| CheckboxBase | mount | 1104 | 1089 | 5000 | |
| ChoiceGroup | mount | 3901 | 3828 | 5000 | |
| ComboBox | mount | 859 | 843 | 1000 | |
| CommandBar | mount | 9269 | 9119 | 1000 | |
| ContextualMenu | mount | 11043 | 10642 | 1000 | |
| DefaultButton | mount | 991 | 928 | 5000 | |
| DetailsRow | mount | 3158 | 3184 | 5000 | |
| DetailsRowFast | mount | 3349 | 3336 | 5000 | |
| DetailsRowNoStyles | mount | 3248 | 3111 | 5000 | |
| Dialog | mount | 2423 | 2443 | 1000 | |
| DocumentCardTitle | mount | 135 | 154 | 1000 | |
| Dropdown | mount | 2904 | 2941 | 5000 | |
| FocusTrapZone | mount | 1556 | 1667 | 5000 | |
| FocusZone | mount | 1543 | 1585 | 5000 | |
| IconButton | mount | 1475 | 1482 | 5000 | |
| Label | mount | 266 | 307 | 5000 | |
| Layer | mount | 2504 | 2390 | 5000 | |
| Link | mount | 412 | 414 | 5000 | |
| MenuButton | mount | 1285 | 1247 | 5000 | |
| MessageBar | mount | 1871 | 1731 | 5000 | |
| Nav | mount | 2827 | 2891 | 1000 | |
| OverflowSet | mount | 957 | 927 | 5000 | |
| Panel | mount | 1874 | 1877 | 1000 | |
| Persona | mount | 830 | 864 | 1000 | |
| Pivot | mount | 1243 | 1233 | 1000 | |
| PrimaryButton | mount | 1140 | 1119 | 5000 | |
| Rating | mount | 6749 | 6724 | 5000 | |
| SearchBox | mount | 1092 | 1021 | 5000 | |
| Shimmer | mount | 2177 | 2178 | 5000 | |
| Slider | mount | 1681 | 1606 | 5000 | |
| SpinButton | mount | 4275 | 4622 | 5000 | |
| Spinner | mount | 375 | 334 | 5000 | |
| SplitButton | mount | 2683 | 2762 | 5000 | |
| Stack | mount | 432 | 454 | 5000 | |
| StackWithIntrinsicChildren | mount | 2006 | 1810 | 5000 | |
| StackWithTextChildren | mount | 4366 | 4146 | 5000 | |
| SwatchColorPicker | mount | 9741 | 9720 | 5000 | |
| TagPicker | mount | 2357 | 2318 | 5000 | |
| TeachingBubble | mount | 88693 | 86858 | 5000 | |
| Text | mount | 377 | 354 | 5000 | |
| TextField | mount | 1243 | 1225 | 5000 | |
| ThemeProvider | mount | 1033 | 998 | 5000 | |
| ThemeProvider | virtual-rerender | 552 | 552 | 5000 | |
| ThemeProvider | virtual-rerender-with-unmount | 1639 | 1612 | 5000 | |
| Toggle | mount | 682 | 690 | 5000 | |
| buttonNative | mount | 109 | 108 | 5000 |
conniec218
approved these changes
Jun 27, 2022
rohitpagariya
pushed a commit
to rohitpagariya/fluentui
that referenced
this pull request
Jun 28, 2022
* fix high contrast media query selector * change file * update snaps * card snaps
micahgodbolt
added a commit
that referenced
this pull request
Jul 26, 2022
…24022) * Change files * snaps * snaps * all the snaps
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #23716
selectors with multiple media queries do not need to duplicate @media