Skip to content

Cherry pick #23739: High Contrast Selectors - Fix broken 2nd query#24022

Merged
micahgodbolt merged 4 commits intomicrosoft:7.0from
micahgodbolt:cherry-pick-23739
Jul 26, 2022
Merged

Cherry pick #23739: High Contrast Selectors - Fix broken 2nd query#24022
micahgodbolt merged 4 commits intomicrosoft:7.0from
micahgodbolt:cherry-pick-23739

Conversation

@micahgodbolt
Copy link
Copy Markdown
Member

@micahgodbolt micahgodbolt commented Jul 21, 2022

Cherry-pick of #23739.

Not an exact cherrypick as the file names/locations have changed, but changed the root media queries and then updated all of the affected snaps.

Original description follows:

selectors with multiple media queries do not need to duplicate @media

@media screen and (-ms-high-contrast: active), screen and (forced-colors: active) {
.cs {color: green }
}

not

@media screen and (-ms-high-contrast: active), @media screen and (forced-colors: active) {
.cs {color: green }
}

@codesandbox-ci
Copy link
Copy Markdown

codesandbox-ci bot commented Jul 21, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 407d43d:

Sandbox Source
Fluent UI Button Configuration
codesandbox-react-template Configuration

@size-auditor
Copy link
Copy Markdown

size-auditor bot commented Jul 21, 2022

Asset size changes

Project Bundle Baseline Size New Size Difference
office-ui-fabric-react office-ui-fabric-react-ButtonGrid 178.529 kB 178.522 kB BelowBaseline     -7 bytes
office-ui-fabric-react office-ui-fabric-react-FloatingPicker 238.608 kB 238.601 kB BelowBaseline     -7 bytes
office-ui-fabric-react office-ui-fabric-react-ColorPicker 87.616 kB 87.609 kB BelowBaseline     -7 bytes
office-ui-fabric-react office-ui-fabric-react-Button 192.184 kB 192.177 kB BelowBaseline     -7 bytes
office-ui-fabric-react office-ui-fabric-react-Breadcrumb 197.52 kB 197.513 kB BelowBaseline     -7 bytes
office-ui-fabric-react office-ui-fabric-react-Facepile 208.098 kB 208.091 kB BelowBaseline     -7 bytes
office-ui-fabric-react office-ui-fabric-react-GroupedList 123.888 kB 123.881 kB BelowBaseline     -7 bytes
office-ui-fabric-react office-ui-fabric-react-Grid 178.529 kB 178.522 kB BelowBaseline     -7 bytes
office-ui-fabric-react office-ui-fabric-react-Callout 85.648 kB 85.641 kB BelowBaseline     -7 bytes
office-ui-fabric-react office-ui-fabric-react-ComboBox 243.701 kB 243.694 kB BelowBaseline     -7 bytes
office-ui-fabric-react office-ui-fabric-react-Check 50.641 kB 50.634 kB BelowBaseline     -7 bytes
office-ui-fabric-react office-ui-fabric-react-Checkbox 65.278 kB 65.271 kB BelowBaseline     -7 bytes
office-ui-fabric-react office-ui-fabric-react-DocumentCard 213.383 kB 213.376 kB BelowBaseline     -7 bytes
office-ui-fabric-react office-ui-fabric-react-ChoiceGroup 62.193 kB 62.186 kB BelowBaseline     -7 bytes
office-ui-fabric-react office-ui-fabric-react-Dialog 209.024 kB 209.017 kB BelowBaseline     -7 bytes
office-ui-fabric-react office-ui-fabric-react-DetailsList 221.52 kB 221.513 kB BelowBaseline     -7 bytes
office-ui-fabric-react office-ui-fabric-react-ChoiceGroupOption 57.222 kB 57.215 kB BelowBaseline     -7 bytes
office-ui-fabric-react office-ui-fabric-react-Coachmark 94.08 kB 94.073 kB BelowBaseline     -7 bytes
office-ui-fabric-react office-ui-fabric-react-HoverCard 98.284 kB 98.277 kB BelowBaseline     -7 bytes
office-ui-fabric-react office-ui-fabric-react-ContextualMenu 155.361 kB 155.354 kB BelowBaseline     -7 bytes
office-ui-fabric-react office-ui-fabric-react-CommandBar 199.007 kB 199 kB BelowBaseline     -7 bytes
office-ui-fabric-react office-ui-fabric-react-DatePicker 208.519 kB 208.512 kB BelowBaseline     -7 bytes
office-ui-fabric-react office-ui-fabric-react-Label 36.044 kB 36.037 kB BelowBaseline     -7 bytes
office-ui-fabric-react office-ui-fabric-react-Keytip 79.992 kB 79.985 kB BelowBaseline     -7 bytes
office-ui-fabric-react office-ui-fabric-react-Slider 59.738 kB 59.731 kB BelowBaseline     -7 bytes
office-ui-fabric-react office-ui-fabric-react-ScrollablePane 52.89 kB 52.883 kB BelowBaseline     -7 bytes
office-ui-fabric-react office-ui-fabric-react-SearchBox 185.151 kB 185.144 kB BelowBaseline     -7 bytes
office-ui-fabric-react office-ui-fabric-react-SelectedItemsList 228.036 kB 228.029 kB BelowBaseline     -7 bytes
office-ui-fabric-react office-ui-fabric-react-Separator 33.198 kB 33.191 kB BelowBaseline     -7 bytes
office-ui-fabric-react office-ui-fabric-react-Shimmer 51.383 kB 51.376 kB BelowBaseline     -7 bytes
office-ui-fabric-react office-ui-fabric-react-ShimmeredDetailsList 231.977 kB 231.97 kB BelowBaseline     -7 bytes
office-ui-fabric-react office-ui-fabric-react-SpinButton 191.167 kB 191.16 kB BelowBaseline     -7 bytes
office-ui-fabric-react office-ui-fabric-react-KeytipLayer 100.655 kB 100.648 kB BelowBaseline     -7 bytes
office-ui-fabric-react office-ui-fabric-react-Spinner 39.296 kB 39.289 kB BelowBaseline     -7 bytes
office-ui-fabric-react office-ui-fabric-react-SwatchColorPicker 188.889 kB 188.882 kB BelowBaseline     -7 bytes
office-ui-fabric-react office-ui-fabric-react-TeachingBubble 203.903 kB 203.896 kB BelowBaseline     -7 bytes
office-ui-fabric-react office-ui-fabric-react-TextField 77.208 kB 77.201 kB BelowBaseline     -7 bytes
office-ui-fabric-react office-ui-fabric-react-Toggle 50.814 kB 50.807 kB BelowBaseline     -7 bytes
office-ui-fabric-react office-ui-fabric-react-Tooltip 85.256 kB 85.249 kB BelowBaseline     -7 bytes
office-ui-fabric-react office-ui-fabric-react-Rating 76.164 kB 76.157 kB BelowBaseline     -7 bytes
office-ui-fabric-react office-ui-fabric-react-ProgressIndicator 37.05 kB 37.043 kB BelowBaseline     -7 bytes
office-ui-fabric-react office-ui-fabric-react-PositioningContainer 72.356 kB 72.349 kB BelowBaseline     -7 bytes
office-ui-fabric-react office-ui-fabric-react-Pivot 183.847 kB 183.84 kB BelowBaseline     -7 bytes
office-ui-fabric-react office-ui-fabric-react-Keytips 103.826 kB 103.819 kB BelowBaseline     -7 bytes
office-ui-fabric-react office-ui-fabric-react-Link 44.142 kB 44.135 kB BelowBaseline     -7 bytes
office-ui-fabric-react office-ui-fabric-react-MarqueeSelection 68.781 kB 68.774 kB BelowBaseline     -7 bytes
office-ui-fabric-react office-ui-fabric-react-MessageBar 187.339 kB 187.332 kB BelowBaseline     -7 bytes
office-ui-fabric-react office-ui-fabric-react-Modal 97.014 kB 97.007 kB BelowBaseline     -7 bytes
office-ui-fabric-react office-ui-fabric-react-Nav 185.371 kB 185.364 kB BelowBaseline     -7 bytes
office-ui-fabric-react office-ui-fabric-react-Overlay 38.454 kB 38.447 kB BelowBaseline     -7 bytes
office-ui-fabric-react office-ui-fabric-react-Panel 198.734 kB 198.727 kB BelowBaseline     -7 bytes
office-ui-fabric-react office-ui-fabric-react-Persona 114.12 kB 114.113 kB BelowBaseline     -7 bytes
office-ui-fabric-react office-ui-fabric-react-PersonaCoin 114.12 kB 114.113 kB BelowBaseline     -7 bytes
office-ui-fabric-react office-ui-fabric-react-PersonaPresence 55.717 kB 55.71 kB BelowBaseline     -7 bytes
office-ui-fabric-react office-ui-fabric-react-Pickers 283.367 kB 283.36 kB BelowBaseline     -7 bytes
office-ui-fabric-react office-ui-fabric-react-ActivityItem 68.826 kB 68.819 kB BelowBaseline     -7 bytes
office-ui-fabric-react office-ui-fabric-react-Dropdown 230.558 kB 230.544 kB BelowBaseline     -14 bytes
office-ui-fabric-react office-ui-fabric-react-Styling 43.822 kB 43.794 kB BelowBaseline     -28 bytes

ExceedsTolerance Over Tolerance (1024 B) ExceedsBaseline Over Baseline BelowBaseline Below Baseline New New Deleted  Removed 1 kB = 1000 B

Baseline commit: cf31bb07e968a0385c644b394f86141e12ed940c (build)

@fabricteam
Copy link
Copy Markdown
Collaborator

fabricteam commented Jul 21, 2022

Perf Analysis

No significant results to display.

All results

Scenario Render type 7.0 Ticks PR Ticks Iterations Status
BaseButton mount 759 778 5000
Breadcrumb mount 36496 36332 5000
Checkbox mount 1310 1325 5000
CheckboxBase mount 1090 1103 5000
ChoiceGroup mount 4220 4243 5000
ComboBox mount 767 775 1000
CommandBar mount 6768 6761 1000
ContextualMenu mount 13444 13964 1000
DefaultButton mount 959 978 5000
DetailsRow mount 3188 3267 5000
DetailsRowFast mount 3200 3201 5000
DetailsRowNoStyles mount 3036 3030 5000
Dialog mount 1961 1922 1000
DocumentCardTitle mount 1545 1556 1000
Dropdown mount 2134 2167 5000
FocusTrapZone mount 1478 1476 5000
FocusZone mount 1555 1566 5000
IconButton mount 1467 1498 5000
Label mount 288 298 5000
Layer mount 1650 1645 5000
Link mount 371 373 5000
MenuButton mount 1247 1242 5000
MessageBar mount 1748 1807 5000
Nav mount 2805 2801 1000
OverflowSet mount 1204 1198 5000
Panel mount 1275 1223 1000
Persona mount 819 825 1000
Pivot mount 1237 1242 1000
PrimaryButton mount 1083 1100 5000
Rating mount 6635 6670 5000
SearchBox mount 1071 1075 5000
Shimmer mount 2222 2188 5000
Slider mount 1276 1283 5000
SpinButton mount 4308 4313 5000
Spinner mount 351 347 5000
SplitButton mount 2726 2716 5000
Stack mount 425 416 5000
StackWithIntrinsicChildren mount 1442 1436 5000
StackWithTextChildren mount 4062 4055 5000
SwatchColorPicker mount 8984 9006 5000
TagPicker mount 2452 2441 5000
TeachingBubble mount 44141 43917 5000
Text mount 356 355 5000
TextField mount 1163 1205 5000
Toggle mount 702 691 5000
button mount 90 91 5000

@khmakoto khmakoto changed the title Cherry pick 23739 to 7.0 Cherry pick #23739: High Contrast Selectors - Fix broken 2nd query Jul 25, 2022
@micahgodbolt micahgodbolt merged commit 44b4146 into microsoft:7.0 Jul 26, 2022
@micahgodbolt micahgodbolt deleted the cherry-pick-23739 branch July 26, 2022 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants