react-radio: update labels in examples#22781
Merged
spmonahan merged 1 commit intomicrosoft:masterfrom May 3, 2022
Merged
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 47a8591:
|
Collaborator
📊 Bundle size reportUnchanged fixtures
|
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 1254 | 1240 | 5000 | |
| Button | mount | 775 | 792 | 5000 | |
| FluentProvider | mount | 2407 | 2368 | 5000 | |
| FluentProviderWithTheme | mount | 403 | 424 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 333 | 329 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 418 | 442 | 10 | |
| MakeStyles | mount | 1988 | 1999 | 50000 |
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 48dbe4cb1f67a38a4c0a4e0d5282c98741ca16c2 (build) |
smhigley
approved these changes
May 3, 2022
Contributor
smhigley
left a comment
There was a problem hiding this comment.
one small defaultValue change, but approving anyway to not hold it up
packages/react-radio/src/stories/RadioGroupDisabled.stories.tsx
Outdated
Show resolved
Hide resolved
c06b07a to
47a8591
Compare
marwan38
pushed a commit
to marwan38/fluentui
that referenced
this pull request
Jun 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Behavior
Radioexamples lack clear labels.New Behavior
Radioexample labels are updated to select from a list of fruits. This allows theRadioGrouplabel examples to be clearer and more realistic than "Option" while still being simple to understand.Additionally, a new story demonstrating how to mark a group as required has been added.
Related Issue(s)
Fixes #22770