feat(tools): apply d.ts rolluping setup in migration generator#22663
Merged
Hotell merged 3 commits intomicrosoft:masterfrom Apr 28, 2022
Merged
feat(tools): apply d.ts rolluping setup in migration generator#22663Hotell merged 3 commits intomicrosoft:masterfrom
Hotell merged 3 commits intomicrosoft:masterfrom
Conversation
50 tasks
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit a5f308d:
|
Hotell
commented
Apr 27, 2022
| }); | ||
| }); | ||
|
|
||
| describe(`api-extractor.json updates`, () => { |
Contributor
Author
There was a problem hiding this comment.
extracted api-extractor related tests to separate group
| "update-snapshots": "just-scripts jest -u", | ||
| } | ||
| `); | ||
| expect(pkgJson.scripts.start).toBeDefined(); |
Contributor
Author
There was a problem hiding this comment.
refactored this test to focus only on things that matter for this test scope
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 946 | 899 | 5000 | |
| Button | mount | 558 | 545 | 5000 | |
| FluentProvider | mount | 2052 | 2128 | 5000 | |
| FluentProviderWithTheme | mount | 269 | 288 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 241 | 238 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 315 | 310 | 10 | |
| MakeStyles | mount | 1555 | 1557 | 50000 |
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: a1dca96f80f3e36b8836d8701e11a56d1aff572d (build) |
Collaborator
📊 Bundle size reportUnchanged fixtures
|
Collaborator
Perf Analysis (
|
| Scenario | Current PR Ticks | Baseline Ticks | Ratio |
|---|---|---|---|
| SegmentMinimalPerf.default | 290 | 247 | 1.17:1 |
| PortalMinimalPerf.default | 151 | 138 | 1.09:1 |
| AvatarMinimalPerf.default | 172 | 160 | 1.08:1 |
| ImageMinimalPerf.default | 318 | 294 | 1.08:1 |
| RefMinimalPerf.default | 208 | 192 | 1.08:1 |
| ListWith60ListItems.default | 543 | 514 | 1.06:1 |
| HeaderMinimalPerf.default | 304 | 290 | 1.05:1 |
| BoxMinimalPerf.default | 282 | 272 | 1.04:1 |
| ListMinimalPerf.default | 429 | 414 | 1.04:1 |
| ReactionMinimalPerf.default | 312 | 300 | 1.04:1 |
| DropdownManyItemsPerf.default | 569 | 555 | 1.03:1 |
| PopupMinimalPerf.default | 534 | 519 | 1.03:1 |
| SkeletonMinimalPerf.default | 285 | 276 | 1.03:1 |
| IconMinimalPerf.default | 504 | 489 | 1.03:1 |
| FormMinimalPerf.default | 335 | 328 | 1.02:1 |
| ListNestedPerf.default | 460 | 449 | 1.02:1 |
| LoaderMinimalPerf.default | 576 | 564 | 1.02:1 |
| TableMinimalPerf.default | 328 | 322 | 1.02:1 |
| TreeMinimalPerf.default | 680 | 665 | 1.02:1 |
| AnimationMinimalPerf.default | 451 | 446 | 1.01:1 |
| ChatDuplicateMessagesPerf.default | 244 | 242 | 1.01:1 |
| DialogMinimalPerf.default | 642 | 638 | 1.01:1 |
| DropdownMinimalPerf.default | 2585 | 2557 | 1.01:1 |
| ItemLayoutMinimalPerf.default | 988 | 976 | 1.01:1 |
| LayoutMinimalPerf.default | 293 | 291 | 1.01:1 |
| MenuMinimalPerf.default | 699 | 695 | 1.01:1 |
| ProviderMergeThemesPerf.default | 1071 | 1065 | 1.01:1 |
| ProviderMinimalPerf.default | 334 | 331 | 1.01:1 |
| SplitButtonMinimalPerf.default | 3685 | 3646 | 1.01:1 |
| CustomToolbarPrototype.default | 2304 | 2282 | 1.01:1 |
| VideoMinimalPerf.default | 542 | 534 | 1.01:1 |
| AttachmentSlotsPerf.default | 922 | 924 | 1:1 |
| ButtonMinimalPerf.default | 134 | 134 | 1:1 |
| ChatMinimalPerf.default | 607 | 608 | 1:1 |
| CheckboxMinimalPerf.default | 2255 | 2250 | 1:1 |
| GridMinimalPerf.default | 274 | 273 | 1:1 |
| HeaderSlotsPerf.default | 629 | 628 | 1:1 |
| MenuButtonMinimalPerf.default | 1408 | 1406 | 1:1 |
| SliderMinimalPerf.default | 1409 | 1415 | 1:1 |
| TableManyItemsPerf.default | 1594 | 1599 | 1:1 |
| ToolbarMinimalPerf.default | 785 | 785 | 1:1 |
| TreeWith60ListItems.default | 135 | 135 | 1:1 |
| AccordionMinimalPerf.default | 120 | 121 | 0.99:1 |
| AlertMinimalPerf.default | 210 | 212 | 0.99:1 |
| CarouselMinimalPerf.default | 387 | 392 | 0.99:1 |
| DatepickerMinimalPerf.default | 4765 | 4802 | 0.99:1 |
| EmbedMinimalPerf.default | 3430 | 3466 | 0.99:1 |
| LabelMinimalPerf.default | 308 | 312 | 0.99:1 |
| RosterPerf.default | 920 | 927 | 0.99:1 |
| TextMinimalPerf.default | 284 | 288 | 0.99:1 |
| TooltipMinimalPerf.default | 882 | 889 | 0.99:1 |
| ButtonOverridesMissPerf.default | 1230 | 1257 | 0.98:1 |
| InputMinimalPerf.default | 1057 | 1081 | 0.98:1 |
| StatusMinimalPerf.default | 549 | 558 | 0.98:1 |
| AttachmentMinimalPerf.default | 117 | 121 | 0.97:1 |
| DividerMinimalPerf.default | 279 | 288 | 0.97:1 |
| ListCommonPerf.default | 508 | 526 | 0.97:1 |
| ButtonSlotsPerf.default | 433 | 450 | 0.96:1 |
| CardMinimalPerf.default | 438 | 454 | 0.96:1 |
| ChatWithPopoverPerf.default | 308 | 322 | 0.96:1 |
| TextAreaMinimalPerf.default | 361 | 392 | 0.92:1 |
| RadioGroupMinimalPerf.default | 330 | 361 | 0.91:1 |
| FlexMinimalPerf.default | 197 | 235 | 0.84:1 |
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| BaseButton | mount | 776 | 764 | 5000 | |
| Breadcrumb | mount | 2345 | 2344 | 1000 | |
| Checkbox | mount | 1209 | 1199 | 5000 | |
| CheckboxBase | mount | 975 | 1088 | 5000 | |
| ChoiceGroup | mount | 3916 | 4002 | 5000 | |
| ComboBox | mount | 830 | 864 | 1000 | |
| CommandBar | mount | 8533 | 8384 | 1000 | |
| ContextualMenu | mount | 10015 | 9376 | 1000 | |
| DefaultButton | mount | 964 | 963 | 5000 | |
| DetailsRow | mount | 3246 | 3347 | 5000 | |
| DetailsRowFast | mount | 3250 | 3360 | 5000 | |
| DetailsRowNoStyles | mount | 3057 | 3038 | 5000 | |
| Dialog | mount | 1890 | 1935 | 1000 | |
| DocumentCardTitle | mount | 142 | 152 | 1000 | |
| Dropdown | mount | 2614 | 2833 | 5000 | |
| FocusTrapZone | mount | 1543 | 1588 | 5000 | |
| FocusZone | mount | 1561 | 1546 | 5000 | |
| IconButton | mount | 1387 | 1333 | 5000 | |
| Label | mount | 299 | 304 | 5000 | |
| Layer | mount | 2302 | 2413 | 5000 | |
| Link | mount | 344 | 345 | 5000 | |
| MenuButton | mount | 1256 | 1143 | 5000 | |
| MessageBar | mount | 1809 | 1781 | 5000 | |
| Nav | mount | 2735 | 2665 | 1000 | |
| OverflowSet | mount | 864 | 829 | 5000 | |
| Panel | mount | 1792 | 1777 | 1000 | |
| Persona | mount | 793 | 888 | 1000 | |
| Pivot | mount | 1649 | 1226 | 1000 | |
| PrimaryButton | mount | 1007 | 1004 | 5000 | |
| Rating | mount | 6447 | 6448 | 5000 | |
| SearchBox | mount | 1150 | 1130 | 5000 | |
| Shimmer | mount | 2001 | 2048 | 5000 | |
| Slider | mount | 1591 | 1614 | 5000 | |
| SpinButton | mount | 4202 | 4067 | 5000 | |
| Spinner | mount | 367 | 358 | 5000 | |
| SplitButton | mount | 2703 | 2626 | 5000 | |
| Stack | mount | 394 | 439 | 5000 | |
| StackWithIntrinsicChildren | mount | 1927 | 1964 | 5000 | |
| StackWithTextChildren | mount | 4275 | 4337 | 5000 | |
| SwatchColorPicker | mount | 9500 | 9312 | 5000 | |
| TagPicker | mount | 2216 | 2279 | 5000 | |
| TeachingBubble | mount | 84510 | 83659 | 5000 | |
| Text | mount | 334 | 377 | 5000 | |
| TextField | mount | 1109 | 1189 | 5000 | |
| ThemeProvider | mount | 979 | 987 | 5000 | |
| ThemeProvider | virtual-rerender | 557 | 568 | 5000 | |
| ThemeProvider | virtual-rerender-with-unmount | 1601 | 1560 | 5000 | |
| Toggle | mount | 627 | 636 | 5000 | |
| buttonNative | mount | 106 | 113 | 5000 |
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Hotell
commented
Apr 27, 2022
| ```sh | ||
| |- <package-name>/ | ||
| |- dist/ | ||
| |- |- index.d.ts # rolluped declaration file |
Contributor
Author
There was a problem hiding this comment.
this setup is already in place and being published, so I decided to update to not introduce additional changes that dont provide much value (having index.d.ts in root )
Hotell
commented
Apr 27, 2022
| "docModel": { | ||
| "apiJsonFilePath": "<projectFolder>/dist/<unscopedPackageName>.api.json", | ||
| "enabled": true | ||
| "enabled": true, |
Hotell
commented
Apr 27, 2022
| outDir: 'dist', | ||
| declaration: true, | ||
| declarationDir: 'dist/types', | ||
| inlineSources: true, |
Contributor
Author
There was a problem hiding this comment.
this is the bread and butter to make sourcemaps work
theerebuss
approved these changes
Apr 27, 2022
39bf92f to
5e20e84
Compare
5e20e84 to
a5f308d
Compare
marwan38
pushed a commit
to marwan38/fluentui
that referenced
this pull request
Jun 13, 2022
…soft#22663) * feat(tools): apply d.ts rolluping setup in migration generator * docs(rfcs): update packaging for npm doc * chore(scripts): prepare api-extractor v9 config for shipping rolluped dts only
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes partially #22429