docs(rfc): update packaging with shipping types rfc#22469
docs(rfc): update packaging with shipping types rfc#22469Hotell merged 2 commits intomicrosoft:masterfrom
Conversation
📊 Bundle size report🤖 This report was generated against b48c03cff249019cf845af18a7f63dacf46d5218 |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 133412c:
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 543b0c6b1e1d950b454c43662fa3e7b911139919 (build) |
theerebuss
left a comment
There was a problem hiding this comment.
Both approaches seem good to me 👌
3 (shipping only rollup-ed(bundled) implementation files) and 4 (package.json post-processing) won't be tackled in this PR, correct?
| - TBA | ||
| - additional configuration to maintain within our legacy tool chain | ||
|
|
||
| ### 3. shipping only rollup-ed(bundled) implementation files |
There was a problem hiding this comment.
This solution is what's mentioned as an approach for problem 1 of section 2, right?
There was a problem hiding this comment.
no, there is nothing regarding implementation files in this PR/RFC
There was a problem hiding this comment.
is it confusing ? if yes what would you suggest ? I'm following proper a11y heading outline in general
36d7492 to
876cc60
Compare
Co-authored-by: André Dias (he/him) <39736248+andrefcdias@users.noreply.github.com>
khmakoto
left a comment
There was a problem hiding this comment.
I think this makes sense, I especially like not exposing internals if we don't need to.
| - TBA | ||
| **Problem 1 solution:** | ||
|
|
||
| - ship only [rolluped declaration files `.d.ts`](https://medium.com/@martin_hotell/typescript-library-tips-rollup-your-types-995153cc81c7) for all public API entrances. We can leverage already existing setup via api-extractor. |
There was a problem hiding this comment.
The diagram mentions rollup, but the solution using api-extractor is still comptible with how we currently build with tsc right ?
There was a problem hiding this comment.
diagram is taken from my blogpost, where rollup.js was used for bundling implementation. the rest of diagram uses api-extractor for declaration bundling (rollup-ing).
is still comptible with how we currently build with tsc right
yes
* docs(rfc): update packaging with shipping types rfc * Apply suggestions from code review Co-authored-by: André Dias (he/him) <39736248+andrefcdias@users.noreply.github.com> Co-authored-by: André Dias (he/him) <39736248+andrefcdias@users.noreply.github.com>
Pre-requisite:
Adds shipping types RFC chapter
Preview 👀
Related Issue(s)
Fixes partially #22429