chore(migrate-converged-pk): Update migration generator for IE11 EOL#19039
Merged
ling1726 merged 2 commits intomicrosoft:masterfrom Jul 21, 2021
Merged
chore(migrate-converged-pk): Update migration generator for IE11 EOL#19039ling1726 merged 2 commits intomicrosoft:masterfrom
ling1726 merged 2 commits intomicrosoft:masterfrom
Conversation
Collaborator
📊 Bundle size report🤖 This report was generated against e2360defc46ab144907bcd01b12e76fe35c4edbf |
Hotell
approved these changes
Jul 21, 2021
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit a399ee9:
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: e2360defc46ab144907bcd01b12e76fe35c4edbf (build) |
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 828 | 781 | 5000 | |
| BaseButton | mount | 928 | 952 | 5000 | |
| Breadcrumb | mount | 2713 | 2635 | 1000 | |
| ButtonNext | mount | 525 | 524 | 5000 | |
| Checkbox | mount | 1500 | 1497 | 5000 | |
| CheckboxBase | mount | 1296 | 1240 | 5000 | |
| ChoiceGroup | mount | 4626 | 4578 | 5000 | |
| ComboBox | mount | 953 | 986 | 1000 | |
| CommandBar | mount | 9902 | 9963 | 1000 | |
| ContextualMenu | mount | 6163 | 6208 | 1000 | |
| DefaultButton | mount | 1125 | 1088 | 5000 | |
| DetailsRow | mount | 3651 | 3618 | 5000 | |
| DetailsRowFast | mount | 3717 | 3623 | 5000 | |
| DetailsRowNoStyles | mount | 3529 | 3489 | 5000 | |
| Dialog | mount | 2100 | 2082 | 1000 | |
| DocumentCardTitle | mount | 148 | 152 | 1000 | |
| Dropdown | mount | 3219 | 3171 | 5000 | |
| FluentProviderNext | mount | 7184 | 7215 | 5000 | |
| FocusTrapZone | mount | 1766 | 1811 | 5000 | |
| FocusZone | mount | 1763 | 1809 | 5000 | |
| IconButton | mount | 1703 | 1681 | 5000 | |
| Label | mount | 342 | 348 | 5000 | |
| Layer | mount | 1756 | 1761 | 5000 | |
| Link | mount | 442 | 454 | 5000 | |
| MakeStyles | mount | 1773 | 1767 | 50000 | |
| MenuButton | mount | 1486 | 1452 | 5000 | |
| MessageBar | mount | 1943 | 1940 | 5000 | |
| Nav | mount | 3165 | 3135 | 1000 | |
| OverflowSet | mount | 1013 | 1005 | 5000 | |
| Panel | mount | 2077 | 2073 | 1000 | |
| Persona | mount | 836 | 783 | 1000 | |
| Pivot | mount | 1397 | 1399 | 1000 | |
| PrimaryButton | mount | 1283 | 1236 | 5000 | |
| Rating | mount | 7569 | 7651 | 5000 | |
| SearchBox | mount | 1282 | 1280 | 5000 | |
| Shimmer | mount | 2533 | 2482 | 5000 | |
| Slider | mount | 1928 | 1924 | 5000 | |
| SpinButton | mount | 4935 | 4961 | 5000 | |
| Spinner | mount | 405 | 428 | 5000 | |
| SplitButton | mount | 3139 | 3085 | 5000 | |
| Stack | mount | 496 | 486 | 5000 | |
| StackWithIntrinsicChildren | mount | 1535 | 1568 | 5000 | |
| StackWithTextChildren | mount | 4468 | 4485 | 5000 | |
| SwatchColorPicker | mount | 10134 | 10278 | 5000 | |
| Tabs | mount | 1380 | 1379 | 1000 | |
| TagPicker | mount | 2399 | 2356 | 5000 | |
| TeachingBubble | mount | 11664 | 11684 | 5000 | |
| Text | mount | 430 | 408 | 5000 | |
| TextField | mount | 1374 | 1331 | 5000 | |
| ThemeProvider | mount | 1160 | 1152 | 5000 | |
| ThemeProvider | virtual-rerender | 582 | 625 | 5000 | |
| Toggle | mount | 812 | 802 | 5000 | |
| buttonNative | mount | 117 | 115 | 5000 |
Perf Analysis (@fluentui/react-northstar)
Perf tests with no regressions
| Scenario | Current PR Ticks | Baseline Ticks | Ratio |
|---|---|---|---|
| AttachmentMinimalPerf.default | 158 | 146 | 1.08:1 |
| TableMinimalPerf.default | 399 | 369 | 1.08:1 |
| RefMinimalPerf.default | 244 | 231 | 1.06:1 |
| SkeletonMinimalPerf.default | 356 | 340 | 1.05:1 |
| StatusMinimalPerf.default | 678 | 645 | 1.05:1 |
| TreeWith60ListItems.default | 169 | 161 | 1.05:1 |
| ButtonSlotsPerf.default | 551 | 528 | 1.04:1 |
| ImageMinimalPerf.default | 370 | 357 | 1.04:1 |
| RadioGroupMinimalPerf.default | 429 | 413 | 1.04:1 |
| ReactionMinimalPerf.default | 374 | 359 | 1.04:1 |
| VideoMinimalPerf.default | 628 | 602 | 1.04:1 |
| CarouselMinimalPerf.default | 454 | 439 | 1.03:1 |
| ChatWithPopoverPerf.default | 364 | 352 | 1.03:1 |
| CheckboxMinimalPerf.default | 2730 | 2654 | 1.03:1 |
| HeaderMinimalPerf.default | 361 | 349 | 1.03:1 |
| ButtonMinimalPerf.default | 162 | 159 | 1.02:1 |
| ButtonOverridesMissPerf.default | 1700 | 1660 | 1.02:1 |
| ChatDuplicateMessagesPerf.default | 279 | 273 | 1.02:1 |
| DatepickerMinimalPerf.default | 5311 | 5231 | 1.02:1 |
| FormMinimalPerf.default | 411 | 402 | 1.02:1 |
| EmbedMinimalPerf.default | 4088 | 4060 | 1.01:1 |
| ListCommonPerf.default | 621 | 617 | 1.01:1 |
| LoaderMinimalPerf.default | 679 | 675 | 1.01:1 |
| MenuMinimalPerf.default | 839 | 833 | 1.01:1 |
| MenuButtonMinimalPerf.default | 1615 | 1604 | 1.01:1 |
| PopupMinimalPerf.default | 573 | 565 | 1.01:1 |
| SliderMinimalPerf.default | 1573 | 1553 | 1.01:1 |
| CustomToolbarPrototype.default | 3838 | 3812 | 1.01:1 |
| TooltipMinimalPerf.default | 987 | 979 | 1.01:1 |
| AlertMinimalPerf.default | 259 | 258 | 1:1 |
| AnimationMinimalPerf.default | 402 | 400 | 1:1 |
| CardMinimalPerf.default | 544 | 544 | 1:1 |
| PortalMinimalPerf.default | 165 | 165 | 1:1 |
| ProviderMinimalPerf.default | 981 | 981 | 1:1 |
| TableManyItemsPerf.default | 1839 | 1838 | 1:1 |
| TextAreaMinimalPerf.default | 472 | 470 | 1:1 |
| ChatMinimalPerf.default | 649 | 655 | 0.99:1 |
| FlexMinimalPerf.default | 275 | 278 | 0.99:1 |
| HeaderSlotsPerf.default | 729 | 733 | 0.99:1 |
| LabelMinimalPerf.default | 377 | 381 | 0.99:1 |
| RosterPerf.default | 1134 | 1150 | 0.99:1 |
| ProviderMergeThemesPerf.default | 1616 | 1637 | 0.99:1 |
| SplitButtonMinimalPerf.default | 3731 | 3751 | 0.99:1 |
| IconMinimalPerf.default | 591 | 594 | 0.99:1 |
| ToolbarMinimalPerf.default | 902 | 912 | 0.99:1 |
| TreeMinimalPerf.default | 757 | 768 | 0.99:1 |
| DropdownManyItemsPerf.default | 650 | 660 | 0.98:1 |
| GridMinimalPerf.default | 320 | 326 | 0.98:1 |
| ListMinimalPerf.default | 490 | 498 | 0.98:1 |
| AccordionMinimalPerf.default | 148 | 152 | 0.97:1 |
| DropdownMinimalPerf.default | 3020 | 3102 | 0.97:1 |
| LayoutMinimalPerf.default | 347 | 359 | 0.97:1 |
| InputMinimalPerf.default | 1213 | 1266 | 0.96:1 |
| ListWith60ListItems.default | 602 | 626 | 0.96:1 |
| AttachmentSlotsPerf.default | 1026 | 1081 | 0.95:1 |
| DialogMinimalPerf.default | 733 | 769 | 0.95:1 |
| ItemLayoutMinimalPerf.default | 1143 | 1201 | 0.95:1 |
| ListNestedPerf.default | 525 | 552 | 0.95:1 |
| TextMinimalPerf.default | 337 | 356 | 0.95:1 |
| DividerMinimalPerf.default | 344 | 366 | 0.94:1 |
| AvatarMinimalPerf.default | 180 | 196 | 0.92:1 |
| SegmentMinimalPerf.default | 316 | 343 | 0.92:1 |
| BoxMinimalPerf.default | 326 | 357 | 0.91:1 |
PeterDraex
pushed a commit
to PeterDraex/fluentui
that referenced
this pull request
Aug 6, 2021
…icrosoft#19039) * chore(migrate-converged-pk): Update migration generator for IE11 EOL * update lib
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ yarn changeDescription of changes
Per the agreement on #18978, updates the converged DX generator to use ES2015 target and lib for converged package tsconfigs
Focus areas to test
(optional)