RFC(IE11): Ending support for IE11 in Fluent v9 by ling1726 · Pull Request #18978 · microsoft/fluentui

ling1726 · 2021-07-16T16:00:06Z

Pull request checklist

Addresses an existing issue: Fixes #0000
Include a change request file using $ yarn change

Description of changes

(give an overview)

Focus areas to test

(optional)

size-auditor · 2021-07-16T16:11:37Z

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: ae8112bc7da5245739ec1c125479c6debdc7b8e3 (build)

codesandbox-ci · 2021-07-16T16:12:04Z

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 2f4339d:

Sandbox	Source
Fluent UI React Starter	Configuration

fabricteam · 2021-07-16T16:15:39Z

📊 Bundle size report

Unchanged fixtures

Package & Exports	Size (minified/GZIP)
`react-divider` Divider	`15.889 kB` `5.747 kB`
`react-image` Image	`10.642 kB` `4.264 kB`
`react-make-styles` makeStaticStyles (runtime)	`7.59 kB` `3.321 kB`
`react-make-styles` makeStyles + mergeClasses (runtime)	`22.135 kB` `8.356 kB`
`react-make-styles` makeStyles + mergeClasses (build time)	`2.557 kB` `1.202 kB`
`react-menu` Menu - Default	`113.947 kB` `34.389 kB`
`react-menu` Menu - Selectable	`115.959 kB` `34.649 kB`
`react-popover` Popover	`140.938 kB` `41.968 kB`
`react-theme` Teams: all themes	`31.935 kB` `6.49 kB`
`react-theme` Teams: Light theme	`19.527 kB` `5.504 kB`

_{🤖 This report was generated against ae8112bc7da5245739ec1c125479c6debdc7b8e3}

fabricteam · 2021-07-16T16:27:46Z

Perf Analysis (`@fluentui/react`)

No significant results to display.

All results

Scenario	Render type	Master Ticks	PR Ticks	Iterations
Avatar	mount	813	791	5000
BaseButton	mount	890	902	5000
Breadcrumb	mount	2725	2695	1000
ButtonNext	mount	529	537	5000
Checkbox	mount	1616	1554	5000
CheckboxBase	mount	1277	1313	5000
ChoiceGroup	mount	4762	4739	5000
ComboBox	mount	979	980	1000
CommandBar	mount	10186	10291	1000
ContextualMenu	mount	6361	6287	1000
DefaultButton	mount	1142	1142	5000
DetailsRow	mount	3783	3669	5000
DetailsRowFast	mount	3701	3776	5000
DetailsRowNoStyles	mount	3514	3494	5000
Dialog	mount	2154	2129	1000
DocumentCardTitle	mount	135	142	1000
Dropdown	mount	3287	3260	5000
FluentProviderNext	mount	7328	7311	5000
FocusTrapZone	mount	1799	1832	5000
FocusZone	mount	1791	1848	5000
IconButton	mount	1714	1756	5000
Label	mount	342	340	5000
Layer	mount	1840	1759	5000
Link	mount	464	469	5000
MakeStyles	mount	1860	1782	50000
MenuButton	mount	1436	1492	5000
MessageBar	mount	2037	2029	5000
Nav	mount	3289	3272	1000
OverflowSet	mount	1065	1044	5000
Panel	mount	2153	2074	1000
Persona	mount	847	829	1000
Pivot	mount	1453	1396	1000
PrimaryButton	mount	1285	1268	5000
Rating	mount	7689	7760	5000
SearchBox	mount	1303	1297	5000
Shimmer	mount	2562	2498	5000
Slider	mount	1997	1971	5000
SpinButton	mount	5004	5286	5000
Spinner	mount	426	431	5000
SplitButton	mount	3174	3127	5000
Stack	mount	490	501	5000
StackWithIntrinsicChildren	mount	1514	1549	5000
StackWithTextChildren	mount	4547	4503	5000
SwatchColorPicker	mount	10950	10135	5000
Tabs	mount	1413	1375	1000
TagPicker	mount	2391	2417	5000
TeachingBubble	mount	11905	11994	5000
Text	mount	426	421	5000
TextField	mount	1396	1385	5000
ThemeProvider	mount	1213	1206	5000
ThemeProvider	virtual-rerender	596	626	5000
Toggle	mount	816	800	5000
buttonNative	mount	119	115	5000

Perf Analysis (`@fluentui/react-northstar`)

Perf tests with no regressions

Scenario	Current PR Ticks	Baseline Ticks	Ratio
BoxMinimalPerf.default	361	334	1.08:1
ChatWithPopoverPerf.default	388	358	1.08:1
AnimationMinimalPerf.default	426	399	1.07:1
AttachmentMinimalPerf.default	156	146	1.07:1
TreeWith60ListItems.default	173	161	1.07:1
VideoMinimalPerf.default	653	616	1.06:1
AvatarMinimalPerf.default	207	198	1.05:1
ListNestedPerf.default	579	549	1.05:1
LoaderMinimalPerf.default	716	683	1.05:1
FormMinimalPerf.default	397	383	1.04:1
RadioGroupMinimalPerf.default	461	445	1.04:1
SegmentMinimalPerf.default	349	337	1.04:1
TableMinimalPerf.default	404	389	1.04:1
ButtonMinimalPerf.default	172	167	1.03:1
PortalMinimalPerf.default	182	176	1.03:1
SkeletonMinimalPerf.default	359	349	1.03:1
StatusMinimalPerf.default	690	669	1.03:1
FlexMinimalPerf.default	279	273	1.02:1
GridMinimalPerf.default	352	346	1.02:1
InputMinimalPerf.default	1285	1265	1.02:1
LabelMinimalPerf.default	385	377	1.02:1
ListMinimalPerf.default	507	499	1.02:1
TextAreaMinimalPerf.default	494	486	1.02:1
ToolbarMinimalPerf.default	960	941	1.02:1
ButtonOverridesMissPerf.default	1689	1676	1.01:1
ButtonSlotsPerf.default	536	532	1.01:1
CardMinimalPerf.default	536	530	1.01:1
CarouselMinimalPerf.default	463	457	1.01:1
DialogMinimalPerf.default	761	751	1.01:1
DividerMinimalPerf.default	359	357	1.01:1
DropdownMinimalPerf.default	3131	3109	1.01:1
HeaderSlotsPerf.default	774	766	1.01:1
LayoutMinimalPerf.default	365	362	1.01:1
ListCommonPerf.default	628	621	1.01:1
ListWith60ListItems.default	647	641	1.01:1
MenuButtonMinimalPerf.default	1634	1614	1.01:1
ProviderMergeThemesPerf.default	1710	1697	1.01:1
RefMinimalPerf.default	233	231	1.01:1
TableManyItemsPerf.default	1906	1887	1.01:1
TextMinimalPerf.default	351	349	1.01:1
CustomToolbarPrototype.default	3871	3833	1.01:1
TreeMinimalPerf.default	810	802	1.01:1
ChatMinimalPerf.default	645	644	1:1
DatepickerMinimalPerf.default	5501	5489	1:1
DropdownManyItemsPerf.default	682	681	1:1
EmbedMinimalPerf.default	4144	4145	1:1
ImageMinimalPerf.default	379	378	1:1
MenuMinimalPerf.default	851	854	1:1
ReactionMinimalPerf.default	367	368	1:1
SplitButtonMinimalPerf.default	3796	3784	1:1
AlertMinimalPerf.default	272	276	0.99:1
AttachmentSlotsPerf.default	1069	1082	0.99:1
HeaderMinimalPerf.default	346	350	0.99:1
PopupMinimalPerf.default	592	595	0.99:1
SliderMinimalPerf.default	1550	1569	0.99:1
CheckboxMinimalPerf.default	2692	2736	0.98:1
ItemLayoutMinimalPerf.default	1210	1237	0.98:1
ProviderMinimalPerf.default	981	1003	0.98:1
RosterPerf.default	1107	1146	0.97:1
TooltipMinimalPerf.default	1002	1034	0.97:1
ChatDuplicateMessagesPerf.default	289	302	0.96:1
IconMinimalPerf.default	613	639	0.96:1
AccordionMinimalPerf.default	139	146	0.95:1

rfcs/convergence/ending-ie11-support.md

Co-authored-by: Martin Hochel <hochelmartin@gmail.com>

Hotell

onwards to the better web !

rfcs/convergence/ending-ie11-support.md

ecraig12345

Thanks for doing this! Left some comments above which would be nice to address but overall LGTM.

* RFC(IE11): Ending support for IE11 in Fluent v9 * update proxy usage * Update rfcs/convergence/ending-ie11-support.md Co-authored-by: Martin Hochel <hochelmartin@gmail.com> * Update rfcs/convergence/ending-ie11-support.md Co-authored-by: Martin Hochel <hochelmartin@gmail.com> * update pros/cons * update RFC Co-authored-by: Martin Hochel <hochelmartin@gmail.com>

ling1726 added 2 commits July 16, 2021 17:45

RFC(IE11): Ending support for IE11 in Fluent v9

284a2ae

update proxy usage

1a835aa

ling1726 added the Type: RFC Request for Feedback label Jul 16, 2021

msft-fluent-ui-bot assigned ling1726 Jul 16, 2021

miroslavstastny approved these changes Jul 19, 2021

View reviewed changes

Hotell reviewed Jul 19, 2021

View reviewed changes

rfcs/convergence/ending-ie11-support.md Outdated Show resolved Hide resolved

Hotell reviewed Jul 19, 2021

View reviewed changes

rfcs/convergence/ending-ie11-support.md Outdated Show resolved Hide resolved

Hotell reviewed Jul 19, 2021

View reviewed changes

rfcs/convergence/ending-ie11-support.md Show resolved Hide resolved

ling1726 and others added 3 commits July 19, 2021 13:57

Update rfcs/convergence/ending-ie11-support.md

eb917c3

Co-authored-by: Martin Hochel <hochelmartin@gmail.com>

Update rfcs/convergence/ending-ie11-support.md

4f5dc6e

Co-authored-by: Martin Hochel <hochelmartin@gmail.com>

update pros/cons

f2e877d

ling1726 marked this pull request as ready for review July 19, 2021 11:58

ling1726 requested review from a team July 19, 2021 11:58

Hotell approved these changes Jul 19, 2021

View reviewed changes

ecraig12345 reviewed Jul 19, 2021

View reviewed changes

rfcs/convergence/ending-ie11-support.md Outdated Show resolved Hide resolved

ecraig12345 reviewed Jul 19, 2021

View reviewed changes

rfcs/convergence/ending-ie11-support.md Outdated Show resolved Hide resolved

ecraig12345 reviewed Jul 19, 2021

View reviewed changes

rfcs/convergence/ending-ie11-support.md Outdated Show resolved Hide resolved

ecraig12345 approved these changes Jul 19, 2021

View reviewed changes

update RFC

2f4339d

ecraig12345 approved these changes Jul 21, 2021

View reviewed changes

ling1726 merged commit 1107e58 into microsoft:master Jul 21, 2021

ling1726 mentioned this pull request Jul 21, 2021

chore(migrate-converged-pk): Update migration generator for IE11 EOL #19039

Merged

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

RFC(IE11): Ending support for IE11 in Fluent v9#18978

RFC(IE11): Ending support for IE11 in Fluent v9#18978
ling1726 merged 6 commits intomicrosoft:masterfrom
ling1726:rfc/ie11-eol

ling1726 commented Jul 16, 2021

Uh oh!

size-auditor bot commented Jul 16, 2021 •

edited

Loading

Uh oh!

codesandbox-ci bot commented Jul 16, 2021 •

edited

Loading

Uh oh!

fabricteam commented Jul 16, 2021 •

edited

Loading

Uh oh!

fabricteam commented Jul 16, 2021 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Hotell left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ecraig12345 left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

ling1726 commented Jul 16, 2021

Pull request checklist

Description of changes

Focus areas to test

Uh oh!

size-auditor bot commented Jul 16, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Asset size changes

Uh oh!

codesandbox-ci bot commented Jul 16, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fabricteam commented Jul 16, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📊 Bundle size report

Uh oh!

fabricteam commented Jul 16, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Perf Analysis (@fluentui/react)

Perf Analysis (@fluentui/react-northstar)

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Hotell left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ecraig12345 left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

size-auditor bot commented Jul 16, 2021 •

edited

Loading

codesandbox-ci bot commented Jul 16, 2021 •

edited

Loading

fabricteam commented Jul 16, 2021 •

edited

Loading

fabricteam commented Jul 16, 2021 •

edited

Loading

Perf Analysis (`@fluentui/react`)

Perf Analysis (`@fluentui/react-northstar`)