chore: implement test in memory execution based on TS aliases#17161
chore: implement test in memory execution based on TS aliases#17161Hotell merged 7 commits intomicrosoft:masterfrom
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit d2570b4:
|
Perf AnalysisNo significant results to display. All results
Perf Analysis (Fluent)Potential regressions comparing to master
Perf comparison
Perf tests with no regressions
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 7f5086718eec496063c6830302c162117fcfc4ec (build) |
b709efc to
e19ae57
Compare
|
another interesting CI failure. on local machine I'm getting api extractor error on Local machine issue when running Ci issue |
|
@chrisdholt Can you help with the web-components build error above? |
@ecraig12345 @Hotell It looks like API extractor was (possibly) completed successfully. There are two commands running, can you confirm that running |
That error is happening on my local machine, on CI, the error is completely different 🎲 😀 |
Sure, I'm just trying to confirm as I don't repro locally on my part so I'm trying to identify which part of the script it's coming from. If you run both of the above in isolation, which spurs the error? |
all good. Note I run |
|
Is it possible that this could be caused by different yarn installation layouts between local and CI, causing different dep versions to be used? We have the same API Extractor versions currently but different TS, and I'm not sure if it could vary which TS version API Extractor uses. |
6ae178e to
4494020
Compare
|
I found and fixed the issue (with temporary workarounds). 2 main issues:
Going forward all of this needs to be resolved, otherwise these kind of issues will constantly happen
|
|
After #17197 |
tsconfig.base.json
Outdated
| "@fluentui/utilities": ["packages/utilities/src/index.ts"], | ||
| "@fluentui/merge-styles": ["packages/merge-styles/src/index.ts"], | ||
| "@fluentui/dom-utilities": ["packages/dom-utilities/src/index.ts"], | ||
| "@fluentui/theme": ["packages/theme/src/index.ts"], | ||
| "@fluentui/react-window-provider": ["packages/react-window-provider/src/index.ts"], | ||
| "@fluentui/react-focus-management": ["packages/react-focus-management/src/index.ts"], | ||
| "@fluentui/react-menu": ["packages/react-menu/src/index.ts"] |
There was a problem hiding this comment.
| "@fluentui/utilities": ["packages/utilities/src/index.ts"], | |
| "@fluentui/merge-styles": ["packages/merge-styles/src/index.ts"], | |
| "@fluentui/dom-utilities": ["packages/dom-utilities/src/index.ts"], | |
| "@fluentui/theme": ["packages/theme/src/index.ts"], | |
| "@fluentui/react-window-provider": ["packages/react-window-provider/src/index.ts"], | |
| "@fluentui/react-focus-management": ["packages/react-focus-management/src/index.ts"], | |
| "@fluentui/react-menu": ["packages/react-menu/src/index.ts"] | |
| "@fluentui/react-focus-management": ["packages/react-focus-management/src/index.ts"], | |
| "@fluentui/react-menu": ["packages/react-menu/src/index.ts"] |
FYI: As #17197 have been merged (and @ling1726 pointed out), we don't need these packages for convergence, so you can remove these aliases if it will help you somehow 🙂
There was a problem hiding this comment.
that's great :) wish I got this info sooner to save lot of time
There was a problem hiding this comment.
btw can you help me understand what can be removed in particular, when there are still those direct deps in react menu?
on the left: react-menu
There was a problem hiding this comment.
I mentioned packages that can be removed (are not part of converged packages) in a diff:
- @fluentui/utilities
- @fluentui/merge-styles
- @fluentui/dom-utilities
- @fluentui/theme
- @fluentui/react-window-provider
Sorry, but I don't understand that screenshot, what package do you have on right? Is it @fluentui/react-make-styles? I don't see any dependencies from the list above either on master or on this branch in it.
fluentui/packages/react-menu/package.json
Lines 48 to 52 in 2ca35f1
fluentui/packages/react-make-styles/package.json
Lines 37 to 40 in 2ca35f1
There was a problem hiding this comment.
but I don't understand that screenshot, what package do you have on right? Is it @fluentui/react-make-styles? I don't see any dependencies from the list above either on master or on this branch in it.
yes, sorry I thought that arrow is self explanatory.
those deps are still there (except set-version)
react-make-styles deps
88b0844 to
d2570b4
Compare
Recently microsoft#17161 changed `react-menu` to use native `jest` command for testing which does not support the `--production` flag
Recently #17161 changed `react-menu` to use native `jest` command for testing which does not support the `--production` flag
|
🎉 Handy links: |
|
🎉 Handy links: |
|
🎉 Handy links: |
|
🎉 Handy links: |
|
🎉 Handy links: |
|
🎉 Handy links: |
|
🎉 Handy links: |
|
🎉 Handy links: |
|
🎉 Handy links: |
|
🎉 Handy links: |
|
🎉 Handy links: |
|
🎉 Handy links: |
|
🎉 Handy links: |
|
🎉 Handy links: |
|
🎉 Handy links: |
|
🎉 Handy links: |
|
🎉 Handy links: |
…oft#17161) * chore(react-menu): implement in memory test execution * fix(react-conformance): remove esModuleInterop so the package is compliant with other packages * fix(utilities): make pkg compile in strict mode * chore(make-styles): propagate deps to root and remove path overrides so the package can be properly consumed by ts path aliases converged packages * chore(react-menu): add global types from dependant packages until we properly define globals type resolution for all * chore: remove packages from path aliases that have been removed from convergence * Change files
Recently microsoft#17161 changed `react-menu` to use native `jest` command for testing which does not support the `--production` flag
…oft#17161) * chore(react-menu): implement in memory test execution * fix(react-conformance): remove esModuleInterop so the package is compliant with other packages * fix(utilities): make pkg compile in strict mode * chore(make-styles): propagate deps to root and remove path overrides so the package can be properly consumed by ts path aliases converged packages * chore(react-menu): add global types from dependant packages until we properly define globals type resolution for all * chore: remove packages from path aliases that have been removed from convergence * Change files
Recently microsoft#17161 changed `react-menu` to use native `jest` command for testing which does not support the `--production` flag
Pull request checklist
$ yarn changeDescription of changes
Before:
After:
Focus areas to test
(optional)