chore: cleanup dependencies for converged components#17197
Merged
layershifter merged 12 commits intomasterfrom Mar 1, 2021
Merged
chore: cleanup dependencies for converged components#17197layershifter merged 12 commits intomasterfrom
layershifter merged 12 commits intomasterfrom
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit c74b092:
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: e81ec9a409a5c16f1ba6c0333a9df41f6375f92f (build) |
layershifter
commented
Feb 26, 2021
layershifter
commented
Feb 26, 2021
layershifter
commented
Feb 26, 2021
| "@fluentui/keyboard-key": "^0.2.14", | ||
| "@fluentui/react-icons-mdl2": "^1.0.1", | ||
| "@fluentui/react-make-styles": "^9.0.0-alpha.4", | ||
| "@fluentui/react-shared-contexts": "^1.0.0-beta.10", |
Member
Author
There was a problem hiding this comment.
These deps were simply not used at all 😮
Member
There was a problem hiding this comment.
FYI, this happened because a bunch of things were deleted in #17060. Once some of them come back we might want to find out how to deal with this.
Member
There was a problem hiding this comment.
If we're removing this, should react-shared-contexts be released as 1.0 now? Or entirely removed for the time being (and remove usage from v8 as well)?
layershifter
commented
Feb 26, 2021
layershifter
commented
Feb 26, 2021
layershifter
commented
Feb 26, 2021
Collaborator
Perf Analysis
All results
Perf Analysis (Fluent)Perf comparison
Perf tests with no regressions
|
khmakoto
approved these changes
Feb 26, 2021
ecraig12345
approved these changes
Feb 26, 2021
ling1726
approved these changes
Mar 1, 2021
Contributor
|
Great job, thanks for following up on this so quickly 🚀 |
miroslavstastny
approved these changes
Mar 1, 2021
2 tasks
Collaborator
|
🎉 Handy links: |
Collaborator
|
🎉 Handy links: |
Collaborator
|
🎉 Handy links: |
Collaborator
|
🎉 Handy links: |
Collaborator
|
🎉 Handy links: |
Collaborator
|
🎉 Handy links: |
Collaborator
|
🎉 Handy links: |
Collaborator
|
🎉 Handy links: |
joshualamusga1
pushed a commit
to joshualamusga1/fluentui
that referenced
this pull request
Mar 25, 2021
* chore: cleanup dependencies for converged components * fix exports * fix lint error * update API, move css() util * remove cruft file * Change files * fix lint errors * fix lint errors * Update packages/react-utilities/src/hooks/useId.ts * Update packages/react-theme/src/utils/mergeThemes.ts * Update packages/react-utilities/src/compose/makeMergeProps.ts * fix fmt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
- [ ] Addresses an existing issue: Fixes #0000$ yarn changeDependency graph for this PR
@fluentui/react-avatarDependency on
@fluentui/utilitieswas removed:nullRenderis reused from@fluentui/react-utilities(it have been already there)useFocusRects()(according to the spec, it's not focusable via keyboard)getInitials()was copied as an util to@fluentui/react-avataras it's a single component that uses it in convergence@fluentui/react-button@fluentui/react-icons-mdl2&@fluentui/react-shared-contextswere removed as they are not used at all.@fluentui/react-link@fluentui/utilitieswere used onlyconfig/tests.jsfor functionality that is not required, usages and a dependency were removed.@fluentui/react-themeHad a dependency on
merge()inmergeThemes(),merge()is temporary copied as there is no clear decision about theme shape yet.@fluentui/react-utilitiesgetNativeProps(),omit()and*propertieswere copied from from@fluentui/utilitiesas they are used in converged utilsuseId()hook now temporary uses simplifiedgetId()version, we anyway should reimplement it to be compatible with SSR and scenarios with different globals (document,window)css()were temporary copied tomakeMergeProps(), we should useax()there, but it's not possible now due circular possible dependencies between@fluentui/react-make-stylesand@fluentui/react-utilities(via@fluentui/react-provider)/makeClassesdirectory was removed as we don't have anymore components that are using.scss