chore(deps): Move typescript to peerDependencies#295
chore(deps): Move typescript to peerDependencies#295sandersn merged 1 commit intomicrosoft:masterfrom
typescript to peerDependencies#295Conversation
|
I think it's actually the fault of dtslint's dependencies dts-critic and @definitelytyped/definitions-parser. dtslint needs to depend directly on typescript so that it can be run via package.json's |
|
That will also work with peer dependencies. |
|
#296 updated dtslint's dependencies. I published it and will watch DT to see if it works. |
|
(It works locally.) |
That doesn't seem to be the case. Even with latest
|
|
I just tried this fork (PR) on my project using ./node_modules/.bin/dtslint types/gapi.client.abusiveexperiencereport |
IvanGoncharov
left a comment
There was a problem hiding this comment.
This is exactly the fix we need to make dtslint reliably working in graphql-js 👍
sandersn
left a comment
There was a problem hiding this comment.
I'll merge this and ship it as soon as DefinitelyTyped/DefinitelyTyped#45226 is in.
|
OK, 3.6.10 is published, let me know if there are problems. |
|
@sandersn It fixed every for |
It seems the prettier settings can conflit with the 'whitespace' rule of dtslint. Also forces the dtslint version to be sure Travis use a version with this fix: microsoft/dtslint#295
`dtslint` moved typescript to a peer dependency so now we need to include it in our package.json. microsoft/dtslint#295
`dtslint` moved typescript to a peer dependency so now we need to include it in our package.json. microsoft/dtslint#295
`dtslint` moved typescript to a peer dependency so now we need to include it in our package.json. microsoft/dtslint#295

Fixes #281
Depends on:
typescript@nexttodevDependenciesDefinitelyTyped/DefinitelyTyped#45148