Conversation
package.json
Outdated
| } | ||
| }, | ||
| "dependencies": {} | ||
| "dependencies": { |
There was a problem hiding this comment.
because DefinitelyTyped isn't on npm so nothing can take a dependency on it? But I guess it makes more sense there.
|
/azp run DefinitelyTyped.BenchmarkPR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings. Let’s review the numbers, shall we? webpack-sources/v*Comparison details for webpack-sources/* 📊
It looks like nothing changed too much. I won’t post performance data again unless it gets worse. webpack-sources/v*Comparison details for webpack-sources/* 📊
It looks like nothing changed too much. I won’t post performance data again unless it gets worse. |
package.json
Outdated
| "@definitelytyped/dtslint-runner": "latest", | ||
| "typescript": "next" |
There was a problem hiding this comment.
To make the diff cleaner, I suggest putting typescript@next before @definitelytyped/dtslint‑runner, like in #45148:
| "@definitelytyped/dtslint-runner": "latest", | |
| "typescript": "next" | |
| "typescript": "next", | |
| "@definitelytyped/dtslint-runner": "latest" |
There was a problem hiding this comment.
And I suggest using npx sort-package-json that will produce this:
"devDependencies": {
"@definitelytyped/dtslint-runner": "latest",
"danger": "^10.1.1",
"dtslint": "latest",
"prettier": "^2.0.2",
"typescript": "next"
}The reason is that package.json will be re-ordered anyway in case if a package will be added/removed using npm cli.
* add typescript dependency * move typescript to devDependencies * try ts version that matches perf * try ts@next again * reorder devDeps
* add typescript dependency * move typescript to devDependencies * try ts version that matches perf * try ts@next again * reorder devDeps
In preparation for merging microsoft/dtslint#295 and shipping a new version of dtslint that has typescript as a peer dependency.