Skip to content

Create OAI_CONFIG_LIST#315

Closed
thegreatestcompany wants to merge 1 commit into
microsoft:mainfrom
thegreatestcompany:patch-1
Closed

Create OAI_CONFIG_LIST#315
thegreatestcompany wants to merge 1 commit into
microsoft:mainfrom
thegreatestcompany:patch-1

Conversation

@thegreatestcompany

Copy link
Copy Markdown

Why are these changes needed?

Related issue number

Checks

@sonichi sonichi requested review from a team and AaronWard October 21, 2023 00:46
@gagb

gagb commented Oct 21, 2023

Copy link
Copy Markdown
Collaborator

@thegreatestcompany, can you please expand why are these changes necessary? There is a sample config in the root.

@BeibinLi

Copy link
Copy Markdown
Contributor

Are we going to use "base_url" instead of "api_base" here?

If yes, should we wait #383 first?

@gagb

gagb commented Oct 23, 2023

Copy link
Copy Markdown
Collaborator

Are we going to use "base_url" instead of "api_base" here?

If yes, should we wait #383 first?

This PR is adding a new file to the notebooks folder. I still see it using api_base

@sonichi

sonichi commented Oct 24, 2023

Copy link
Copy Markdown
Contributor

#383 and all the subtasks for #203 are merged to the dev/v0.2 branch. We won't merge #393 to main until all the subtasks are solved.

@AaronWard AaronWard left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not quite sure what the purpose of this PR is

@gagb

gagb commented Oct 27, 2023

Copy link
Copy Markdown
Collaborator

I think this PR is not necessary given the instruction number 2 in https://github.com/microsoft/autogen#quickstart

@thegreatestcompany if this makes sense, I'd like to close this PR.

@AaronWard

Copy link
Copy Markdown
Contributor

@gagb @thegreatestcompany Seeing as there is no response i will go ahead and close this PR

@AaronWard AaronWard closed this Nov 1, 2023
jackgerrits pushed a commit that referenced this pull request Oct 2, 2024
* add Azure Active Directory auth for samples

* Update README
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants