Conversation
* openai client * client test
3 tasks
rabbabansh
approved these changes
Oct 29, 2023
rabbabansh
approved these changes
Oct 29, 2023
masterujjval
approved these changes
Oct 29, 2023
qingyun-wu
reviewed
Oct 29, 2023
Contributor
|
In this notebook https://github.com/microsoft/autogen/blob/82f3712b8c583771af8122d2cfd5b74f1280b870/notebook/agentchat_qdrant_RetrieveChat.ipynb, "api_base" should be changed to "base_urls" |
qingyun-wu
approved these changes
Oct 29, 2023
qingyun-wu
left a comment
Contributor
There was a problem hiding this comment.
I am approving this PR. It is fine to address the two comments in the migration PR.
* migration guide * change in kwargs * simplify header * update optigude description
3 tasks
sagarsdesai
approved these changes
Oct 30, 2023
Gourav2609
approved these changes
Oct 30, 2023
manish7017
approved these changes
Nov 1, 2023
qingyun-wu
reviewed
Nov 2, 2023
manish7017
approved these changes
Nov 2, 2023
Steellgold
approved these changes
Nov 4, 2023
* Add back tests for RetrieveChat * Fix format * Update dependencies order * Fix path * Fix path * Fix path * Fix tests * Add not run openai on MacOS or Win * Update skip openai tests * Remove unnecessary dependencies, improve format * Add py3.8 for testing qdrant * Fix multiline error of windows * Add openai tests * Add dependency mathchat, remove unused envs
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This is WIP to address #203
Subtasks in #203 are addressed as smaller PRs merging into the dev/v0.2 branch.
Please review those smaller PRs before the PR is ready for the final review.
This PR will cause breaking changes. For example,
use_cacheis removed as a kwarg in.create()for being automatically decided byseed: int | None.Please check the migration guide: https://github.com/microsoft/autogen/pull/393/files#diff-1861c86f207554494e035c330ae1df296ccd9d976e2b6ffe7bd23fb2e8f91b06
Related issue number
close #203
Checks