openai base url default to None; read files when env vars exist; remove deprecated models by sonichi · Pull Request #1110 · microsoft/autogen

sonichi · 2023-12-31T16:09:39Z

Why are these changes needed?

[Core] Extending inline docs for openai_utils.py, boosting coverage in test_utils.py, fixing #762 #1046 introduces a bug of defaulting openai base url to "". It causes test failures in https://github.com/microsoft/autogen/actions/runs/7366572506/job/20050787096?pr=1026
This PR changes the default to None.
[Core] Extending inline docs for openai_utils.py, boosting coverage in test_utils.py, fixing #762 #1046 introduces a test which fails with the current utils when env vars already exist: https://github.com/microsoft/autogen/actions/runs/7371478796/job/20058910737?pr=1110
This PR changes the utility such that it tries to read from files even when the env vars exist, unless the file path or file names are explicitly set to None.
This PR also removes models from the test which are going to be deprecated from Jan 4.

Related issue number

Checks

I've included any doc changes needed for https://microsoft.github.io/autogen/. See https://microsoft.github.io/autogen/docs/Contribute#documentation to build and test documentation locally.
I've added tests (if relevant) corresponding to the changes introduced in this PR.
I've made sure all auto checks have passed.

codecov-commenter · 2023-12-31T16:10:32Z

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (a9483a4) 30.56% compared to head (fd2ea5e) 64.76%.

Files	Patch %	Lines
autogen/oai/openai_utils.py	86.66%	0 Missing and 4 partials ⚠️
autogen/oai/client.py	66.66%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #1110       +/-   ##
===========================================
+ Coverage   30.56%   64.76%   +34.20%     
===========================================
  Files          30       30               
  Lines        4028     4033        +5     
  Branches      911      962       +51     
===========================================
+ Hits         1231     2612     +1381     
+ Misses       2723     1154     -1569     
- Partials       74      267      +193

Flag	Coverage Δ
unittests	`64.66% <84.84%> (+34.15%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

yiranwu0

LGTM!

* Remove GPT-4 as the default model. * Updated test_compressible_agent to work around a bug that would otherwise default to gpt-4. Revist after #1073 is addressed. * Worked around another bug in test_compressible_agent. It seems the config_list was always empty! * Reverted changes to compressible agent. * Noted that GPT-4 is the preferred model in the OAI_CONFIG_LIST_sample and README. * Fixed failing tests after #1110 * Update OAI_CONFIG_LIST_sample Co-authored-by: Chi Wang <wang.chi@microsoft.com> --------- Co-authored-by: Chi Wang <wang.chi@microsoft.com>

* Initial commit of WebSurfer. Adds the browser_utils, and related tests. WebSurfer will be added in a subsequent commit. * Added the web surfer agent, and related tests. * Added a notebook to show how WebSurferAgent works. * Fixed a typo. * Updated test_web_surfer for compatibility with #1110. * Updated skip_oai logic. * Fixed code formatting. * More pre-commit fixes. * Added block to contrib-openai.yml * Added block to contrib-openai.yml * Added hook for BING_API_KEY * Temporarily commented out other tests, per request. * Fixed indentation (maybe?) * Restoring contrib-openai.yml

…#1093) * Initial commit of WebSurfer. Adds the browser_utils, and related tests. WebSurfer will be added in a subsequent commit. * Added the web surfer agent, and related tests. * Added a notebook to show how WebSurferAgent works. * Fixed a typo. * Updated test_web_surfer for compatibility with microsoft#1110. * Updated skip_oai logic. * Fixed code formatting. * More pre-commit fixes. * Added block to contrib-openai.yml * Added block to contrib-openai.yml * Added hook for BING_API_KEY * Temporarily commented out other tests, per request. * Fixed indentation (maybe?) * Restoring contrib-openai.yml

* add funccall example and doc * revise to comments * Update website/docs/Use-Cases/Auto-Generation.md Co-authored-by: Chi Wang <wang.chi@microsoft.com> * revise * update * minor update * add test notebook * update --------- Co-authored-by: Chi Wang <wang.chi@microsoft.com>

…ve deprecated models (microsoft#1110) * openai base url default to None * read from files when env vars exist

* Remove GPT-4 as the default model. * Updated test_compressible_agent to work around a bug that would otherwise default to gpt-4. Revist after microsoft#1073 is addressed. * Worked around another bug in test_compressible_agent. It seems the config_list was always empty! * Reverted changes to compressible agent. * Noted that GPT-4 is the preferred model in the OAI_CONFIG_LIST_sample and README. * Fixed failing tests after microsoft#1110 * Update OAI_CONFIG_LIST_sample Co-authored-by: Chi Wang <wang.chi@microsoft.com> --------- Co-authored-by: Chi Wang <wang.chi@microsoft.com>

…#1093) * Initial commit of WebSurfer. Adds the browser_utils, and related tests. WebSurfer will be added in a subsequent commit. * Added the web surfer agent, and related tests. * Added a notebook to show how WebSurferAgent works. * Fixed a typo. * Updated test_web_surfer for compatibility with microsoft#1110. * Updated skip_oai logic. * Fixed code formatting. * More pre-commit fixes. * Added block to contrib-openai.yml * Added block to contrib-openai.yml * Added hook for BING_API_KEY * Temporarily commented out other tests, per request. * Fixed indentation (maybe?) * Restoring contrib-openai.yml

openai base url default to None

8ab5103

sonichi had a problem deploying to openai1 December 31, 2023 16:09 — with GitHub Actions Failure

sonichi temporarily deployed to openai1 December 31, 2023 16:09 — with GitHub Actions Inactive

sonichi had a problem deploying to openai1 December 31, 2023 16:09 — with GitHub Actions Failure

sonichi temporarily deployed to openai1 December 31, 2023 16:09 — with GitHub Actions Inactive

sonichi had a problem deploying to openai1 December 31, 2023 16:09 — with GitHub Actions Failure

sonichi requested review from ekzhu, maxim-saplin, qingyun-wu and yiranwu0 December 31, 2023 16:10

sonichi requested review from BeibinLi and afourney December 31, 2023 16:10

read from files when env vars exist

fd2ea5e

sonichi temporarily deployed to openai1 December 31, 2023 17:08 — with GitHub Actions Inactive

sonichi temporarily deployed to openai1 December 31, 2023 17:09 — with GitHub Actions Inactive

sonichi changed the title ~~openai base url default to None~~ openai base url default to None; read files when env vars exist; remove deprecated models Dec 31, 2023

sonichi added bug labels Dec 31, 2023

sonichi enabled auto-merge December 31, 2023 17:59

sonichi mentioned this pull request Dec 31, 2023

[Core] Fix update_usage_summary when response doesn't have usage attribute #1008

Merged

3 tasks

yiranwu0 approved these changes Dec 31, 2023

View reviewed changes

sonichi added this pull request to the merge queue Dec 31, 2023

Merged via the queue into main with commit 3b0e059 Dec 31, 2023

sonichi deleted the baseurl branch December 31, 2023 18:29

sonichi mentioned this pull request Dec 31, 2023

[Core] Throw an error when the OAI_CONFIG_LIST is missing. #1082

Merged

3 tasks

afourney mentioned this pull request Jan 2, 2024

[Bug]: [Low Priority] Cannot run tests from a test's local folder. conftest is not found. #1120

Closed

afourney added a commit that referenced this pull request Jan 2, 2024

Updated test_web_surfer for compatibility with #1110.

40e3fa5

afourney added a commit that referenced this pull request Jan 3, 2024

Fixed failing tests after #1110

d28d160

afourney mentioned this pull request Jan 3, 2024

Remove GPT-4 as the default model. #1072

Merged

3 tasks

whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024

openai base url default to None; read files when env vars exist; remo…

c22cd33

…ve deprecated models (microsoft#1110) * openai base url default to None * read from files when env vars exist

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

openai base url default to None; read files when env vars exist; remove deprecated models#1110

openai base url default to None; read files when env vars exist; remove deprecated models#1110
sonichi merged 2 commits into
mainfrom
baseurl

sonichi commented Dec 31, 2023 •

edited

Loading

Uh oh!

codecov-commenter commented Dec 31, 2023 •

edited

Loading

Uh oh!

yiranwu0 left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

sonichi commented Dec 31, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Why are these changes needed?

Related issue number

Checks

Uh oh!

codecov-commenter commented Dec 31, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

yiranwu0 left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

sonichi commented Dec 31, 2023 •

edited

Loading

codecov-commenter commented Dec 31, 2023 •

edited

Loading