[Core] Extending inline docs for openai_utils.py, boosting coverage in test_utils.py, fixing #762#1046
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1046 +/- ##
===========================================
+ Coverage 30.14% 40.96% +10.81%
===========================================
Files 30 30
Lines 4020 4028 +8
Branches 908 960 +52
===========================================
+ Hits 1212 1650 +438
+ Misses 2729 2252 -477
- Partials 79 126 +47
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Contributor
Author
|
@ekzhu - I've fixed Codecov warnings, should be good |
sonichi
reviewed
Dec 28, 2023
ekzhu
approved these changes
Dec 29, 2023
Merged
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
openai_utils.pytest_utils.pyhas more cases tested ramping up coveragetest_utils.pyno longer depends on files that are part of .gitignore (and hence not downloaded when cloning), utilises temp files and fake dataopenai_utils.get_config_list()has an assertion verifying that number of items in files is equal (replacing the current behaviour with out of index being thrown)Related issue number
Closes #762
Checks
P.S. settings up the full suite with all required open configs is a challenge, though I made sure the parts and tests impacted by the changes ran fine