chore: Typescript Cleanup- Part 3 for Test Files by JeevaniChinthala · Pull Request #7291 · microsoft/accessibility-insights-web

JeevaniChinthala · 2024-04-01T05:47:24Z

Details

As part of Typescript migration added/removed the error causing fields.

Motivation

TypeScript 5.0 has marked some options as deprecated. We can temporarily override these deprecations, but the documented plan is for the ability to override the flag to go away in TypeScript 5.5

Context

featureFlagStoreData

Error: Type '{ backLinkHandler: () => void; diagnosticViewToggleFactory: DiagnosticViewToggleFactory; featureFlagStoreData: FeatureFlagStoreData; }' is not assignable to type 'IntrinsicAttributes & AdHocToolsPanelProps & { children?: ReactNode; }'.
Property 'featureFlagStoreData' does not exist on type 'IntrinsicAttributes & AdHocToolsPanelProps & { children?: ReactNode; }'.

avatarUrl: 'avatarUrl'

Error: Type '{ featureFlagStoreData: { 'test-flag': true; }; avatarUrl: string; tabClosed: boolean; deps: InteractiveHeaderDeps;
selectedPivot: DetailsViewPivotType.assessment; navMenu: ReactFCWithDisplayName<...>; narrowModeStatus: NarrowModeStatus; isSideNavOpen: false; setSideNavOpen: null; }' is not assignable to type 'InteractiveHeaderProps'.
Object literal may only specify known properties, and 'avatarUrl' does not exist in type 'InteractiveHeaderProps'.

status: ManualTestStatus.FAIL

Error: Type '{ step: string; test: VisualizationType.HeadingsAssessment; status: ManualTestStatus; assessmentInstanceTableHandler: AssessmentInstanceTableHandler; manualTestStepResultMap: { ...; }; assessmentsProvider: AssessmentsProvider; featureFlagStoreData: FeatureFlagStoreData; pathSnippetStoreData: { ...; }; }' is not assignable to type 'ManualTestStepViewProps'.
Object literal may only specify known properties, and 'status' does not exist in type 'ManualTestStepViewProps'.

supportLinkHandler: null

Error: Type '{ deps: LaunchPanelHeaderDeps; title: string; subtitle: string; supportLinkHandler: null; popupWindow: null; featureFlags: null; openAdhocToolsPanel: null; dropdownClickHandler: null; }' is not assignable to type 'LaunchPanelHeaderProps'.
Object literal may only specify known properties, and 'supportLinkHandler' does not exist in type 'LaunchPanelHeaderProps'.
In the reference file the supportLinkHandler is removed and dropdownClickHandler is already defined in LaunchPanelHeaderDeps

browserAdapter: browserAdapterMock.object

Error: Type '{ diagnosticViewClickHandler: DiagnosticViewClickHandler; popupViewControllerHandler: PopupViewControllerHandler; launchPanelHeaderClickHandler: LaunchPanelHeaderClickHandler; browserAdapter: BrowserAdapter; }' is not assignable to type 'PopupHandlers'.
Object literal may only specify known properties, and 'browserAdapter' does not exist in type 'PopupHandlers'.

targetAppInfo

Error: Type '{ targetAppInfo: { name: string; url: string; }; description: string; environmentInfo: { browserSpec: string; extensionVersion: string; axeCoreVersion: string; }; toUtcString: (date: Date) => string; scanMetadata: ScanMetadata; }' is not assignable to type 'DetailsSectionProps'.
Object literal may only specify known properties, and 'targetAppInfo' does not exist in type 'DetailsSectionProps'.
Removed 'environmentInfo' property as there are no references defined in 'DetailsSectionProps' type

outcomeType: outcomeType,

Error: Type '{ customCongratsContinueInvestigatingMessage: string; outcomeType: InstanceOutcomeType; }' is not assignable to type 'NoFailedInstancesCongratsDeps'.
Object literal may only specify known properties, and 'outcomeType' does not exist in type 'NoFailedInstancesCongratsDeps'.

pageTitle

Error: Type '{ deps: ResultSectionContentDeps; fixInstructionProcessor: FixInstructionProcessor; recommendColor: RecommendColor; ... 13 more ...; sectionHeadingLevel: 3; }' is not assignable to type 'SectionProps'.
Object literal may only specify known properties, and 'pageTitle' does not exist in type 'SectionProps'
pageUrl,toolData,scanResult doesn't exist in type 'SectionProps'. Hence removed.

deps:null

Error: Type '{ [x: string]: string | number | boolean | JSX.Element; id: string; header: JSX.Element; content: JSX.Element; headingLevel: number; deps: null; isExpanded: boolean; }' is not assignable to type 'ReportCollapsibleContainerProps'.
Object literal may only specify known properties, and 'deps' does not exist in type 'ReportCollapsibleContainerProps'.
isExpanded doesn't exist in type 'ReportCollapsibleContainerProps'. Hence removed.

{ name: 'Any', key: 'any' }

Error : Type '{ name: string; key: string; }' is not assignable to type 'IRequirementSubsetForSummary'.
Object literal may only specify known properties, and 'key' does not exist in type 'IRequirementSubsetForSummary'.

cardSelectionMessageCreator

Error: Type '{ serviceName: string; axeVersion: string; userAgent: string; browserResolution: string; scanDetails: ScanSummaryDetails; results: CombinedReportResults; cardSelectionMessageCreator: CardSelectionMessageCreator; }' is not assignable to type 'CombinedReportParameters'.
Object literal may only specify known properties, and 'cardSelectionMessageCreator' does not exist in type 'CombinedReportParameters'.

Pull request checklist

Addresses an existing issue: #[0000](chore: Remove deprecated TypeScript options #6611)
Ran yarn fastpass
Added/updated relevant unit test(s) (and ran yarn test)
Verified code coverage for the changes made. Check coverage report at: <rootDir>/test-results/unit/coverage
PR title AND final merge commit title both start with a semantic tag (fix:, chore:, feat(feature-name):, refactor:). See CONTRIBUTING.md.
(UI changes only) Added screenshots/GIFs to description above
(UI changes only) Verified usability with NVDA/JAWS

…ScriptFeatureV3

src/tests/unit/tests/reports/get-quick-assess-summary-model.test.ts

DaveTryon

Some of the items that were removed (like the featureFlagStoreData accessor) were likely used for features that were at one point still under development. I like removing them now, even though it means potentially re-adding them (with correct support in the types) at some future time.

There's always the risk that we've broken something, but since we need to a full accessibility test pass before releasing with the FluentUI update, this seems like the right time to make this sort of extensive change.

v-viyada · 2024-04-02T20:57:25Z

Some of the items that were removed (like the featureFlagStoreData accessor) were likely used for features that were at one point still under development. I like removing them now, even though it means potentially re-adding them (with correct support in the types) at some future time.

There's always the risk that we've broken something, but since we need to a full accessibility test pass before releasing with the FluentUI update, this seems like the right time to make this sort of extensive change.

Hi @DaveTryon,
This will go with axe-core update release if merged before #7274 . Should we hold this PR and merge after axe-core update PR?

madalynrose

A couple small changes but overall looks good! love seeing so much deleted code!

src/tests/unit/tests/views/content/content-page.test.tsx

src/tests/unit/tests/reports/package/combined-results-report.test.ts

src/tests/unit/tests/reports/get-quick-assess-summary-model.test.ts

madalynrose · 2024-04-05T17:21:40Z

Some of the items that were removed (like the featureFlagStoreData accessor) were likely used for features that were at one point still under development. I like removing them now, even though it means potentially re-adding them (with correct support in the types) at some future time.

There's always the risk that we've broken something, but since we need to a full accessibility test pass before releasing with the FluentUI update, this seems like the right time to make this sort of extensive change.

I looked and this instance of featureFlagStoreData was added in #5736 and should have been removed in #5971. Looks like this particular instance was just missed.

madalynrose

One small tweak and then I think this is good to go!

madalynrose · 2024-04-09T14:35:45Z

src/views/content/markup.tsx

 export interface MarkupOptions {
    setPageTitle?: boolean;
 }
+export interface ExtendedMarkupOptions extends MarkupOptions {


Let's move this to the top of the test file since it isn't needed for any production code.

madalynrose

One small tweak and then I think this is ready to go! (Double review I guess because GH errored out when I submitted the other one and I thought it hadn't gone through)

madalynrose

One additional small tweak!

src/tests/unit/tests/views/content/content-page.test.tsx

Co-authored-by: Madalyn <3230904+madalynrose@users.noreply.github.com>

JeevaniChinthala added 3 commits March 14, 2024 12:57

Typescript Testfile changes

2d1c69a

Merge remote-tracking branch 'origin/main' into users/v-jeevanic/Type…

1722270

…ScriptFeatureV3

Format fix

b8f1dd7

JeevaniChinthala changed the title ~~chore: Typescript Cleanup- Part 3~~ chore: Typescript Cleanup- Part 3 for Test Files Apr 1, 2024

v-viyada marked this pull request as ready for review April 1, 2024 22:42

v-viyada requested a review from a team as a code owner April 1, 2024 22:42

DaveTryon reviewed Apr 2, 2024

View reviewed changes

src/tests/unit/tests/reports/get-quick-assess-summary-model.test.ts Outdated Show resolved Hide resolved

DaveTryon approved these changes Apr 2, 2024

View reviewed changes

madalynrose approved these changes Apr 5, 2024

View reviewed changes

madalynrose self-requested a review April 5, 2024 16:37

madalynrose requested changes Apr 5, 2024

View reviewed changes

src/tests/unit/tests/views/content/content-page.test.tsx Show resolved Hide resolved

src/tests/unit/tests/reports/package/combined-results-report.test.ts Show resolved Hide resolved

src/tests/unit/tests/reports/get-quick-assess-summary-model.test.ts Outdated Show resolved Hide resolved

PR Comments - Fix

587769d

v-viyada requested a review from madalynrose April 8, 2024 16:14

madalynrose requested changes Apr 9, 2024

View reviewed changes

Added ExtendedMarkupOptions interface

c653b8f

madalynrose requested changes Apr 10, 2024

View reviewed changes

src/tests/unit/tests/views/content/content-page.test.tsx Outdated Show resolved Hide resolved

Update src/tests/unit/tests/views/content/content-page.test.tsx

db0b560

Co-authored-by: Madalyn <3230904+madalynrose@users.noreply.github.com>

madalynrose approved these changes Apr 11, 2024

View reviewed changes

v-viyada merged commit 15c1507 into main Apr 11, 2024

JeevaniChinthala deleted the users/v-jeevanic/TypeScriptFeatureV3 branch May 23, 2024 05:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: Typescript Cleanup- Part 3 for Test Files#7291

chore: Typescript Cleanup- Part 3 for Test Files#7291
v-viyada merged 6 commits intomainfrom
users/v-jeevanic/TypeScriptFeatureV3

JeevaniChinthala commented Apr 1, 2024 •

edited

Loading

Uh oh!

Uh oh!

DaveTryon left a comment •

edited

Loading

Uh oh!

v-viyada commented Apr 2, 2024

Uh oh!

madalynrose left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

madalynrose commented Apr 5, 2024

Uh oh!

madalynrose left a comment

Uh oh!

madalynrose Apr 9, 2024

Uh oh!

JeevaniChinthala Apr 10, 2024

Uh oh!

madalynrose left a comment •

edited

Loading

Uh oh!

madalynrose left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

JeevaniChinthala commented Apr 1, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Motivation

Context

Pull request checklist

Uh oh!

Uh oh!

DaveTryon left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

v-viyada commented Apr 2, 2024

Uh oh!

madalynrose left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

madalynrose commented Apr 5, 2024

Uh oh!

madalynrose left a comment

Choose a reason for hiding this comment

Uh oh!

madalynrose Apr 9, 2024

Choose a reason for hiding this comment

Uh oh!

JeevaniChinthala Apr 10, 2024

Choose a reason for hiding this comment

Uh oh!

madalynrose left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

madalynrose left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

JeevaniChinthala commented Apr 1, 2024 •

edited

Loading

DaveTryon left a comment •

edited

Loading

madalynrose left a comment •

edited

Loading