Skip to content

feat(adhoc-tools-accessible-names): remove feature flag#5971

Merged
ZakiyaN0 merged 2 commits intomicrosoft:mainfrom
ZakiyaN0:zanasiru_removeFeatureFlag
Aug 29, 2022
Merged

feat(adhoc-tools-accessible-names): remove feature flag#5971
ZakiyaN0 merged 2 commits intomicrosoft:mainfrom
ZakiyaN0:zanasiru_removeFeatureFlag

Conversation

@ZakiyaN0
Copy link
Copy Markdown
Contributor

@ZakiyaN0 ZakiyaN0 commented Aug 29, 2022

Details

This PR removes the feature flag under which development of the accessible names feature took place. Although the main goal of this PR is to remove the feature flag, it also contains very small changes related to the "display-accessible-names" rule; with respect to that, this PR adds another native element attribute (summary, to be specific,) check for elements that get their names from author-provided attributes. The PR also includes the addition of the "section" element to the selectors we query.

Motivation
Context

The "summary" attribute check was added to this PR because some elements like table can get their accessible name from the summary attribute. For more information, please refer to PR #5960

Pull request checklist

  • Addresses an existing issue: #0000
  • Ran yarn null:autoadd
  • Ran yarn fastpass
  • Added/updated relevant unit test(s) (and ran yarn test)
  • Verified code coverage for the changes made. Check coverage report at: <rootDir>/test-results/unit/coverage
  • PR title AND final merge commit title both start with a semantic tag (fix:, chore:, feat(feature-name):, refactor:). See CONTRIBUTING.md.
  • (UI changes only) Added screenshots/GIFs to description above
  • (UI changes only) Verified usability with NVDA/JAWS
    rFF

@ZakiyaN0 ZakiyaN0 requested a review from a team as a code owner August 29, 2022 17:10
@ZakiyaN0 ZakiyaN0 merged commit fdf77b2 into microsoft:main Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants