feat(adhoc-tools-accessible-names): adding toggle for accessible names visualization#5736
Merged
ZakiyaN0 merged 20 commits intomicrosoft:mainfrom Jul 15, 2022
Merged
feat(adhoc-tools-accessible-names): adding toggle for accessible names visualization#5736ZakiyaN0 merged 20 commits intomicrosoft:mainfrom
ZakiyaN0 merged 20 commits intomicrosoft:mainfrom
Conversation
added 17 commits
June 21, 2022 09:37
Member
|
For the title of the PR name, we usually do i.e. something like |
waabid
reviewed
Jul 13, 2022
waabid
reviewed
Jul 13, 2022
waabid
reviewed
Jul 13, 2022
waabid
reviewed
Jul 13, 2022
waabid
reviewed
Jul 13, 2022
waabid
reviewed
Jul 13, 2022
waabid
reviewed
Jul 13, 2022
waabid
reviewed
Jul 13, 2022
waabid
reviewed
Jul 13, 2022
waabid
reviewed
Jul 13, 2022
waabid
suggested changes
Jul 13, 2022
Member
waabid
left a comment
There was a problem hiding this comment.
PR largely looks good! Just some minor comments/nits.
waabid
reviewed
Jul 15, 2022
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Adds a new Adhoc tool toggle- Accessible Names- to the current Adhoc tools panel under a feature flag.
Motivation
Addresses issue #4864
Context
This PR is meant to address a new feature addition to the AI web. The main goal is to add a new Adhoc tool that displays the accessible names of UI components to the current tools panel. This PR does not included the functionality of the new tool; it only adds a toggle for the new accessible names tool on the current Adhoc tools panel.
N/A
Pull request checklist
yarn fastpassyarn test)<rootDir>/test-results/unit/coveragefix:,chore:,feat(feature-name):,refactor:). SeeCONTRIBUTING.md.demo video.pptx