GVFS.SignFiles.csproj: include more DLLs for signing#1683
Merged
derrickstolee merged 1 commit intomicrosoft:masterfrom Jul 22, 2020
Merged
GVFS.SignFiles.csproj: include more DLLs for signing#1683derrickstolee merged 1 commit intomicrosoft:masterfrom
derrickstolee merged 1 commit intomicrosoft:masterfrom
Conversation
It appears that during our build, we send some DLLs for signing, but the versions we send have already been copied to other projects. Thus, we ship versions of those DLLs that are unsigned. Add extra versions of the DLLs that are currently being signed, except include them in the GVFS.Windows project that is likely where they are being copied as part of the build. Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
Contributor
Author
|
This PR used to target
|
jeffhostetler
approved these changes
Jul 22, 2020
derrickstolee
added a commit
that referenced
this pull request
Jul 28, 2020
Major Updates ----------------- * Comes with Git for Windows 2.28.0 * Previous builds were not including fully-signed DLLs. This is now fixed. Pull Requests --------------- * #1672: ProductUpgrader: be extra careful about a copy loop * #1674: Config: disable status.submoduleSummary * #1675: PreCommandHook: don't lock pack-objects * #1676: Update Git to v2.27.0.vfs.1.0 * #1679: BuildGVFSForWindows.bat: use nuget on PATH * #1683: GVFS.SignFiles.csproj: include more DLLs for signing * #1685: minor path comparison fixup in ProductUpgrader * #1682: Update Git to v2.28.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It appears that during our build, we send some DLLs for signing, but the
versions we send have already been copied to other projects. Thus, we
ship versions of those DLLs that are unsigned.
Add extra versions of the DLLs that are currently being signed, except
include them in the GVFS.Windows project that is likely where they are
being copied as part of the build.