ProductUpgrader: be extra careful about a copy loop#1672
Merged
derrickstolee merged 3 commits intomicrosoft:masterfrom Jun 3, 2020
Merged
ProductUpgrader: be extra careful about a copy loop#1672derrickstolee merged 3 commits intomicrosoft:masterfrom
derrickstolee merged 3 commits intomicrosoft:masterfrom
Conversation
Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
Contributor
Author
|
The log message said this on the user's machine: So, not a case issue. I have no idea why this works for most users. However, this situation did fix the issue for the user with the problem! |
dscho
approved these changes
Jun 2, 2020
Member
dscho
left a comment
There was a problem hiding this comment.
Caveat: I'm not an expert in this area, but from what I gather via the commit messages, the PR description and the diffs, this looks correct.
Contributor
Author
Because IT DOESN'T WORK. This means |
derrickstolee
added a commit
that referenced
this pull request
Jun 2, 2020
…opy loop The `ProductUpgrader` makes a backup of the `C:\Program Files\GVFS` folder before running the install, as a mechanism for backing out a failed upgrade. However, it copies that data into `C:\Program Files\GVFS\ProgramData\GVFS.Upgrade\Tools`, which can create a copy loop! This affected an actual user. I'm not sure why this affects that one user but not another. In addition to adding more defensive programming (adding the target of the copy to the list of exclusions), I also added some extra tracing so we can see how these strings differ on this machine. See #1672 for the master PR.
Contributor
Author
|
I'm going to add documentation into the |
…...- Checking for GVFS upgrades...\ Checking for GVFS upgrades...\ Checking for GVFS upgrades...| Checking for GVFS upgrades...| Checking for GVFS upgrades...Succeeded New version 1.0.19346.2 is available. Upgrade will unmount and remount gvfs repos, ensure you are at a stopping point. When ready, run `gvfs upgrade --confirm` from an elevated command prompt. bug Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
derrickstolee
added a commit
that referenced
this pull request
Jul 28, 2020
Major Updates ----------------- * Comes with Git for Windows 2.28.0 * Previous builds were not including fully-signed DLLs. This is now fixed. Pull Requests --------------- * #1672: ProductUpgrader: be extra careful about a copy loop * #1674: Config: disable status.submoduleSummary * #1675: PreCommandHook: don't lock pack-objects * #1676: Update Git to v2.27.0.vfs.1.0 * #1679: BuildGVFSForWindows.bat: use nuget on PATH * #1683: GVFS.SignFiles.csproj: include more DLLs for signing * #1685: minor path comparison fixup in ProductUpgrader * #1682: Update Git to v2.28.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
ProductUpgradermakes a backup of theC:\Program Files\GVFSfolder before running the install, as a mechanism for backing out a failed upgrade. However, it copies that data intoC:\Program Files\GVFS\ProgramData\GVFS.Upgrade\Tools, which can create a copy loop! This affected an actual user.I'm not sure why this affects that one user but not another. In addition to adding more defensive programming (adding the target of the copy to the list of exclusions), I also added some extra tracing so we can see how these strings differ on this machine.