Adds the codeowners action for offering the ability to merge PRs#899
Merged
Conversation
Contributor
|
Contributor
Contributor
Author
|
That's a review, not a comment - I'll add support for that |
Contributor
Author
|
It should handle that now, assuming I understand the semver in GH actions |
Contributor
|
I could get it to trigger by commenting, but it looks like it is checking to see if the PR creator has merge access, instead of the approver: |
Contributor
|
Awesome! This will make things a LOT easier! |
Contributor
|
I reviewed #815 but it seems not to merge 🤔 --- EDIT I commented again, it merged. Does it only works on single comments? |
danilofuchs
added a commit
to danilofuchs/TypeScript-Website
that referenced
this pull request
Aug 14, 2020
The new codeowners merge action is awesome! (See microsoft#899) Playground examples are written in TS, so codeowners should be able to merge them. (This action failed because of these missing permissions: https://github.com/microsoft/TypeScript-Website/pull/870/checks?check_run_id=985887055, microsoft#870)
Contributor
Author
|
It might only work on single comments? Will try next time |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using https://github.com/orta/code-owner-self-merge to let people merge PRs to their translations without waiting on me
/cc @khaosdoctor @danilofuchs @sasurau4 @Quramy @Naturalclar @Takepepe @KingDarBoja @Kingwl