some Fixits translates to pt#870
Merged
github-actions[bot] merged 10 commits intomicrosoft:v2from Aug 14, 2020
Merged
Conversation
|
|
danilofuchs
suggested changes
Aug 14, 2020
Contributor
danilofuchs
left a comment
There was a problem hiding this comment.
Great job!
We are translating some code in the examples as well, to greatly reduce the barrier of entry for Portuguese-only speakers.
You could translate the code to use maiorValorPositivo instead of maxHighValue, for instance. However, I would happily approve the PR with the code in English, after some small adjustments!
packages/playground-examples/copy/pt/3-7/Fixits/Big number literals.ts
Outdated
Show resolved
Hide resolved
packages/playground-examples/copy/pt/3-7/Fixits/Const to let.ts
Outdated
Show resolved
Hide resolved
packages/playground-examples/copy/pt/3-7/Fixits/Const to let.ts
Outdated
Show resolved
Hide resolved
packages/playground-examples/copy/pt/3-7/Fixits/Infer From Usage Changes.ts
Outdated
Show resolved
Hide resolved
packages/playground-examples/copy/pt/3-7/Fixits/Infer From Usage Changes.ts
Outdated
Show resolved
Hide resolved
packages/playground-examples/copy/pt/3-7/Fixits/Infer From Usage Changes.ts
Outdated
Show resolved
Hide resolved
packages/playground-examples/copy/pt/3-7/Fixits/Infer From Usage Changes.ts
Outdated
Show resolved
Hide resolved
packages/playground-examples/copy/pt/3-7/Syntax and Messaging/Flattened Error Reporting.ts
Outdated
Show resolved
Hide resolved
packages/playground-examples/copy/pt/3-7/Syntax and Messaging/Flattened Error Reporting.ts
Outdated
Show resolved
Hide resolved
…erals.ts Co-authored-by: Danilo Campana Fuchs <danilo_fuchs@hotmail.com>
Co-authored-by: Danilo Campana Fuchs <danilo_fuchs@hotmail.com>
…Flattened Error Reporting.ts Co-authored-by: Danilo Campana Fuchs <danilo_fuchs@hotmail.com>
…Flattened Error Reporting.ts Co-authored-by: Danilo Campana Fuchs <danilo_fuchs@hotmail.com>
…ge Changes.ts Co-authored-by: Danilo Campana Fuchs <danilo_fuchs@hotmail.com>
…ge Changes.ts Co-authored-by: Danilo Campana Fuchs <danilo_fuchs@hotmail.com>
…ge Changes.ts Co-authored-by: Danilo Campana Fuchs <danilo_fuchs@hotmail.com>
Co-authored-by: Danilo Campana Fuchs <danilo_fuchs@hotmail.com>
…ge Changes.ts Co-authored-by: Danilo Campana Fuchs <danilo_fuchs@hotmail.com>
Contributor
Author
|
Thank you @danilofuchs! This Portuguese corrections is so much better! 😀 |
danilofuchs
added a commit
to danilofuchs/TypeScript-Website
that referenced
this pull request
Aug 14, 2020
The new codeowners merge action is awesome! (See microsoft#899) Playground examples are written in TS, so codeowners should be able to merge them. (This action failed because of these missing permissions: https://github.com/microsoft/TypeScript-Website/pull/870/checks?check_run_id=985887055, microsoft#870)
Contributor
|
LGTM |
Contributor
|
Merging because @orta is a code-owner of all the changes - thanks! |
Contributor
|
Cool, #906 fixed the logic |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some translates to PT.