Skip to content

Fix incorrect assert about configFileName when watch is created with explicit options, projectReferences etc#53468

Merged
sheetalkamat merged 2 commits intomainfrom
watchApi
Mar 23, 2023
Merged

Fix incorrect assert about configFileName when watch is created with explicit options, projectReferences etc#53468
sheetalkamat merged 2 commits intomainfrom
watchApi

Conversation

@sheetalkamat
Copy link
Copy Markdown
Member

Fixes issue detected in TypeStrong/ts-loader#1601

@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Mar 23, 2023
@sheetalkamat
Copy link
Copy Markdown
Member Author

@typescript-bot cherry-pick this to release-5.0

@typescript-bot
Copy link
Copy Markdown
Collaborator

typescript-bot commented Mar 23, 2023

Heya @sheetalkamat, I've started to run the task to cherry-pick this into release-5.0 on this PR at fadd862. You can monitor the build here.

@typescript-bot
Copy link
Copy Markdown
Collaborator

Hey @sheetalkamat, I've opened #53469 for you.

typescript-bot pushed a commit to typescript-bot/TypeScript that referenced this pull request Mar 23, 2023
Component commits:
e133b08 Add failing test

fadd862 Fix incorrect assert
@sheetalkamat sheetalkamat merged commit c66f8de into main Mar 23, 2023
@sheetalkamat sheetalkamat deleted the watchApi branch March 23, 2023 19:40
sheetalkamat added a commit that referenced this pull request Mar 23, 2023
@DanielRosenwasser DanielRosenwasser added this to the TypeScript 5.0.3 milestone Mar 23, 2023
drivron pushed a commit to scenari/typescript that referenced this pull request Sep 14, 2023
@microsoft microsoft locked as resolved and limited conversation to collaborators Oct 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants