This repository was archived by the owner on Aug 7, 2024. It is now read-only.
[8/x] make single linear profiling script work with Float8 scaling type#299
Closed
vkuzo wants to merge 1 commit intogh/vkuzo/18/basefrom
Closed
[8/x] make single linear profiling script work with Float8 scaling type#299vkuzo wants to merge 1 commit intogh/vkuzo/18/basefrom
vkuzo wants to merge 1 commit intogh/vkuzo/18/basefrom
Conversation
Summary: Makes `benchmarks/bench_linear_float8.py` support per-tensor scaling configurations. Verified that performance is as we expect Test Plan: paste of testing for delayed -> dynamic, changing the tensors one by one: https://gist.github.com/vkuzo/9e8f995e51ef16f483347c0f86bb0ac3 Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
This was referenced Jul 2, 2024
vkuzo
added a commit
that referenced
this pull request
Jul 2, 2024
Summary: Makes `benchmarks/bench_linear_float8.py` support per-tensor scaling configurations. Verified that performance is as we expect Test Plan: paste of testing for delayed -> dynamic, changing the tensors one by one: https://gist.github.com/vkuzo/9e8f995e51ef16f483347c0f86bb0ac3 Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: bb0c5ac Pull Request resolved: #299
drisspg
approved these changes
Jul 2, 2024
Contributor
Author
|
@vkuzo has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
|
This pull request has been merged in 4fb0ada. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Summary:
Makes
benchmarks/bench_linear_float8.pysupport per-tensor scalingconfigurations.
Verified that performance is as we expect
Test Plan:
paste of testing for delayed -> dynamic, changing the tensors one by
one:
https://gist.github.com/vkuzo/9e8f995e51ef16f483347c0f86bb0ac3
Reviewers:
Subscribers:
Tasks:
Tags:
Differential Revision: D59305789