This repository was archived by the owner on Aug 7, 2024. It is now read-only.
[3/x]: simplify FSDP1 test and add coverage for dynamic scaling#293
Closed
vkuzo wants to merge 1 commit intogh/vkuzo/13/basefrom
Closed
[3/x]: simplify FSDP1 test and add coverage for dynamic scaling#293vkuzo wants to merge 1 commit intogh/vkuzo/13/basefrom
vkuzo wants to merge 1 commit intogh/vkuzo/13/basefrom
Conversation
Summary: 1. simplify the FSDP test, instead of testing 1 GPU vs N GPUs, instead hold the number of GPUs constant and test bf16 vs float8. Remove various technical debt that accumulated in this test. 2. add testing for dynamic scaling of weights Test Plan: ``` ./test/test_fsdp.sh ``` Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
This was referenced Jul 1, 2024
vkuzo
added a commit
that referenced
this pull request
Jul 1, 2024
Summary: 1. simplify the FSDP test, instead of testing 1 GPU vs N GPUs, instead hold the number of GPUs constant and test bf16 vs float8. Remove various technical debt that accumulated in this test. 2. add testing for dynamic scaling of weights Test Plan: ``` ./test/test_fsdp.sh ``` Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: fcd6368 Pull Request resolved: #293
This was referenced Jul 2, 2024
Contributor
Author
|
@vkuzo has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
|
This pull request has been merged in 006f89a. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Summary:
hold the number of GPUs constant and test bf16 vs float8. Remove
various technical debt that accumulated in this test.
Test Plan:
Reviewers:
Subscribers:
Tasks:
Tags:
Differential Revision: D59305791