[DataLoader2] Handle empty queue exception#785
Closed
NivekT wants to merge 4 commits intogh/NivekT/92/basefrom
Closed
[DataLoader2] Handle empty queue exception#785NivekT wants to merge 4 commits intogh/NivekT/92/basefrom
NivekT wants to merge 4 commits intogh/NivekT/92/basefrom
Conversation
[ghstack-poisoned]
Contributor
Author
|
@NivekT has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
VitalyFedyunin
approved these changes
Oct 20, 2022
Contributor
|
Bunch of failed tests here. We discovered some hidden code error? |
Contributor
I have already landed a fix in pytorch core. We just need to wait until nightly update. pytorch/pytorch#87285 |
Fixes #625 Fixes #627 Fixes #628 Differential Revision: [D40517690](https://our.internmc.facebook.com/intern/diff/D40517690) [ghstack-poisoned]
Contributor
Author
|
@NivekT has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
ejguan
pushed a commit
to ejguan/data
that referenced
this pull request
Oct 21, 2022
Summary: Pull Request resolved: meta-pytorch#785 Fixes meta-pytorch#625 Fixes meta-pytorch#627 Fixes meta-pytorch#628 Test Plan: Imported from OSS Reviewed By: VitalyFedyunin Differential Revision: D40517690 Pulled By: NivekT fbshipit-source-id: a95b921dbdb9737d67a912f200cb674acefbad90
ejguan
pushed a commit
that referenced
this pull request
Oct 21, 2022
ejguan
pushed a commit
to ejguan/data
that referenced
this pull request
Oct 23, 2022
Summary: Pull Request resolved: meta-pytorch#785 Fixes meta-pytorch#625 Fixes meta-pytorch#627 Fixes meta-pytorch#628 Test Plan: Imported from OSS Reviewed By: VitalyFedyunin Differential Revision: D40517690 Pulled By: NivekT fbshipit-source-id: a95b921dbdb9737d67a912f200cb674acefbad90
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Fixes #625
Fixes #627
Fixes #628
Differential Revision: D40517690