Skip to content

[DataPipe] Fix type checking to accept both Iter and Map DataPipe#87285

Closed
ejguan wants to merge 1 commit intopytorch:masterfrom
ejguan:fix_sharding_init_fn
Closed

[DataPipe] Fix type checking to accept both Iter and Map DataPipe#87285
ejguan wants to merge 1 commit intopytorch:masterfrom
ejguan:fix_sharding_init_fn

Conversation

@ejguan
Copy link
Contributor

@ejguan ejguan commented Oct 19, 2022

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 19, 2022

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/87285

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 2b33223:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@ejguan ejguan requested a review from NivekT October 19, 2022 13:49
@pytorch-bot pytorch-bot bot added the release notes: dataloader release notes category label Oct 19, 2022
Copy link
Contributor

@NivekT NivekT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 19, 2022
@NivekT
Copy link
Contributor

NivekT commented Oct 19, 2022

This will need to be cherry-picked into core release, right?

@ejguan ejguan added the topic: bug fixes topic category label Oct 19, 2022
@ejguan
Copy link
Contributor Author

ejguan commented Oct 19, 2022

This will need to be cherry-picked into core release, right?

I don't think so as this is just a follow-up PR for #87017. And, as #87017 is not going to be cherrypicked, this should not.

And, the CI is broken for nightly release. Our RC release is fine.

@ejguan
Copy link
Contributor Author

ejguan commented Oct 19, 2022

@pytorchbot merge -g

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks on your PR pass since you used the green (-g) flag (ETA: 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: The following mandatory check(s) failed (Rule superuser):

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

@ejguan
Copy link
Contributor Author

ejguan commented Oct 20, 2022

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: The following mandatory check(s) failed (Rule superuser):

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

@ejguan
Copy link
Contributor Author

ejguan commented Oct 20, 2022

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a rebase job. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased fix_sharding_init_fn onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout fix_sharding_init_fn && git pull --rebase)

@ejguan
Copy link
Contributor Author

ejguan commented Oct 20, 2022

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged release notes: dataloader release notes category topic: bug fixes topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Failing DataLoader2Integration Test

3 participants