kommander-karma: Remove trailing slash from ingress path#354
Merged
alejandroEsc merged 1 commit intoJan 14, 2020
Merged
Conversation
branden
approved these changes
Jan 14, 2020
samvantran
reviewed
Jan 14, 2020
| traefik.ingress.kubernetes.io/auth-url: "http://traefik-forward-auth-kubeaddons.kubeaddons.svc.cluster.local:4181/" | ||
| traefik.ingress.kubernetes.io/priority: "2" | ||
| path: "/ops/portal/kommander/monitoring/karma/" | ||
| path: "/ops/portal/kommander/monitoring/karma" |
There was a problem hiding this comment.
wasn't this needed bc there was a bug of some sort? or this was due to the kommander-ui hijacking?
Contributor
Author
There was a problem hiding this comment.
there is another bug with the slash but we were able to sidestep it via our traefik/karma settings
samvantran
approved these changes
Jan 14, 2020
alejandroEsc
approved these changes
Jan 14, 2020
alejandroEsc
left a comment
Contributor
There was a problem hiding this comment.
thanks for the background info, lgtm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My bad, the trailing slash shouldn't have been added - fixing this here and will follow the same protocol as #347