[kommander-karma] [kommander-thanos] Modify UI links#347
Merged
alejandroEsc merged 2 commits intoJan 13, 2020
Conversation
Contributor
|
@gracedo wouldn't this break until UI is moved to its own path? |
Contributor
Author
|
@GoelDeepak Yes, but I will be making the dependency bumps for these two charts in a followup PR, in kommander, which will also include changing the UI to its own path - so these changes will all be pulled in together. |
joejulian
approved these changes
Jan 13, 2020
alejandroEsc
approved these changes
Jan 13, 2020
alejandroEsc
left a comment
Contributor
There was a problem hiding this comment.
looks good. thanks for adding the details!
mesosphere-teamcity
pushed a commit
that referenced
this pull request
Jan 13, 2020
…er-karma: Update path to /ops/portal/kommander * kommander-thanos: Update path to /ops/portal/kommander
Contributor
|
Does this PR include https://jira.mesosphere.com/browse/DCOS-62690 ? |
Contributor
Author
|
@georgi-minchev that was done in the followup PR #351 |
gracedo
commented
Jan 14, 2020
| traefik.ingress.kubernetes.io/auth-url: "http://traefik-forward-auth-kubeaddons.kubeaddons.svc.cluster.local:4181/" | ||
| traefik.ingress.kubernetes.io/priority: "2" | ||
| path: "/kommander/monitoring/karma" | ||
| path: "/ops/portal/kommander/monitoring/karma/" |
Contributor
Author
There was a problem hiding this comment.
ugh, just caught that this slash shouldn't have been added. putting up a fix asap.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://jira.mesosphere.com/browse/DCOS-62153
We are modifying karma and thanos (and grafana, done in followup PR) links to be behind
/ops/portal/kommander/monitoring/<>instead of/kommander/monitoring/<>. Those ingress changes are done here along with chart bumps. After this PR is merged, I will open up a followup PR to do the following:/ops/portal/kommander/ui(see https://jira.mesosphere.com/browse/DCOS-62690 and we can close this PR DCOS-62690: Move UI under the /ui suffix #338)Following the above PR, I will close out this ticket by bumping kommander to the updated version^ in
kubernetes-base-addons.Testing
This was tested by hosting kommander-thanos and kommander-karma charts on my personal GH, then pointing kommander to my hosted charts as well as self hosting the kommander chart. I changed kommander to point to my hosted kommander chart in a branch of
kubernetes-base-addonsand used that to deploy a konvoy cluster. You can test this by using that branch:gracedo/test_kommander_path_changes. See below for the scrnshts of new urls working as expected: