unittests: expect mtest logs to be utf-8#8362
Merged
jpakkane merged 1 commit intomesonbuild:masterfrom Feb 17, 2021
Merged
Conversation
Member
|
Did this change during test refactorings during the last cycle or is the actual error older? Or, in other words, does this need to go to 0.57.1? |
Contributor
Author
|
The 0.57 changes did not affect the text logs, so I'm not sure why it was not visible before. I also am not sure why the problem would surface specifically after #8362; for that matter, it seems to me that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed a UnicodeDecodeError in the logs for #8332. This should fix it.