Skip to content

unittests: expect mtest logs to be utf-8#8362

Merged
jpakkane merged 1 commit intomesonbuild:masterfrom
bonzini:fix-testsetup-default-decodeerror
Feb 17, 2021
Merged

unittests: expect mtest logs to be utf-8#8362
jpakkane merged 1 commit intomesonbuild:masterfrom
bonzini:fix-testsetup-default-decodeerror

Conversation

@bonzini
Copy link
Copy Markdown
Contributor

@bonzini bonzini commented Feb 16, 2021

I noticed a UnicodeDecodeError in the logs for #8332. This should fix it.

@bonzini bonzini marked this pull request as ready for review February 17, 2021 10:18
@bonzini bonzini requested a review from jpakkane as a code owner February 17, 2021 10:18
@jpakkane
Copy link
Copy Markdown
Member

Did this change during test refactorings during the last cycle or is the actual error older? Or, in other words, does this need to go to 0.57.1?

@bonzini
Copy link
Copy Markdown
Contributor Author

bonzini commented Feb 17, 2021

The 0.57 changes did not affect the text logs, so I'm not sure why it was not visible before. I also am not sure why the problem would surface specifically after #8362; for that matter, it seems to me that TestProtocol.__str__ is dead code (it is okay to have it for e.g. debugging purposes but it should never be invoked) so I don't think either of those are 0.57 material.

@jpakkane jpakkane merged commit 92134ba into mesonbuild:master Feb 17, 2021
@bonzini bonzini deleted the fix-testsetup-default-decodeerror branch October 14, 2021 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants