Don't access other enum members from self#8332
Merged
jpakkane merged 1 commit intomesonbuild:masterfrom Feb 17, 2021
Merged
Conversation
Member
|
@jpakkane we should get this in sooner than later, as the existing code will probably stop working in 3.12 or 3.13 |
Member
|
I'll merge this as soon as #8362 is in and this can be rebased to rerun the tests. |
Member
|
@hroncok: could you rebase this, so we can get the unit tests working? I'd like to merge this ASAP |
This is deprecated in Python 3.10. Instead, acces them from the class. Fixes mesonbuild#8318
Contributor
Author
|
Done. |
Contributor
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is deprecated in Python 3.10.
Instead, acces them from the class.
Fixes #8318