release(#508): v2.3.0#509
Conversation
#118) * chore(#109): project-configurable ticket / branch / commit / PR schema Lift the prefix / type whitelists hardcoded across skills, hooks, and CI into a versioned JSON config read through a shared shell library. Shipped defaults at .claude/project-config.defaults.json; per-fork overrides at the optional .claude/project-config.json; one reader (_lib-read-config.sh) that every consumer now uses. Added: - .claude/project-config.defaults.json (v1 schema) - .claude/hooks/_lib-read-config.sh (shared reader) - docs/project-config.md (schema reference + extension guide) - docs/agdr/AgDR-0006-project-configurable-ticket-schema.md Migrated (still pass with no config present via last-resort fallback): - validate-branch-name.sh → .branch.type_whitelist - validate-commit-format.sh → .commit.type_whitelist (legacy `commit_types` top-level key honoured as backward-compat fallback) - validate-pr-create.sh → .pr.title_type_whitelist - /feature, /task, /bug skills reference the config in their Rules sections; none hardcodes the list any more Unlocks subsequent config-readers for #107 / #110 / #111 / #112 / #113 / #114 / #115 — each extends the schema under its own subtree without further changes to the loader. #109 * fix(#109): satisfy markdownlint MD032 and MD060 on new docs Auto-fix MD032 (blank lines around lists) in AgDR-0006 and format table-separator rows with surrounding spaces (MD060) in both new doc files. Content unchanged; CI green. --------- Co-authored-by: me2resh <ahmed.abdelaliem@gmail.com>
Adds a new PreToolUse hook that blocks gh issue/PR/comment creation and gh api .../issues|/pulls calls targeting a public framework repo (default: me2resh/apexyard + whatever `upstream` resolves to) when the title or body references any registered private project from apexyard.projects.yaml (by name, repo slug, owner/repo#N ticket ref, or workspace path). The hook is a sibling to check-secrets.sh — both scan outgoing content for identifiers that should never leave the local environment. Skip marker `<!-- private-refs: allow -->` in the body lets a deliberate reference through with a visible warning. Files touched: - .claude/hooks/block-private-refs-in-public-repos.sh (new) - .claude/hooks/tests/test_block_private_refs.sh (new) - .claude/rules/leak-protection.md (new) - .claude/settings.json (wire PreToolUse matchers for the 5 gh shapes) - docs/rule-audit.md (append section 10 + bump counts) Refs: #110 Co-authored-by: me2resh <ahmed.abdelaliem@gmail.com>
Fires after `git push` to surface review markers that have gone stale
because new commits were pushed past an existing Rex / CEO / design
approval. The merge gate already catches this at `gh pr merge` time,
but only then -- this hook closes the gap by flagging it immediately
at push-time so the author isn't surprised at merge.
- `.claude/hooks/warn-stale-review-markers.sh`
- PostToolUse, non-blocking (PostToolUse exit 2 would push noise
into the conversation; this hook is purely informational).
- Resolves the PR HEAD via `gh pr view --json headRefOid` -- same
source-of-truth as the merge-gate hooks post-apexyard#47 / #55.
Falls back to local HEAD with a visible WARN when gh is offline.
- Silent on: no PR for branch, no markers, fresh markers,
failed push (detected via `rejected` / `failed to push` /
`fatal:` / `error:` markers in tool_response.stderr).
- Modes: `warn` (default) prints one stderr line per stale marker;
`delete` opts in to auto-removal via
`.claude/project-config.json` -> `review_markers.on_stale`.
TODO(apexyard#109): switch to the shared project-config reader
once it lands.
- `.claude/settings.json`
- Wires the hook on PostToolUse / Bash / `git push *`.
- `docs/rule-audit.md`
- Adds a row under section 3 (Code review & PR quality) and
bumps the mechanized count 26 -> 27 / total 73 -> 74.
- `.claude/hooks/tests/test_warn_stale_review_markers.sh`
- 8 cases: no PR, no markers, fresh markers, stale rex / ceo /
design (warn), delete mode, failed push. All pass locally.
Co-authored-by: me2resh <ahmed.abdelaliem@gmail.com>
… check-runner (#121) * chore(#111): upgrade pre-push-gate from reminder to blocking check-runner Previously pre-push-gate.sh just printed a checklist of things to run locally before pushing — it was advisory. The rule it enforces is a HARD STOP per pr-workflow.md. That asymmetry meant agents routinely pushed broken work and discovered it only when CI went red. Replaces the reminder with a blocking runner that reads the list of shell commands from project config (.pre_push.commands) and executes them in sequence before a push is allowed through. First non-zero exit blocks the push with exit 2 and prints the failing command plus the last 20 lines of its output. - Config key: .pre_push.commands[] — array of {name, run} objects. Shipped default is an empty list (hook stays a no-op on repos that haven't configured their checks yet, including the framework repo itself until it wires its own CI). - Emergency bypass: '<!-- pre-push: skip -->' in the HEAD commit message. Grep-able on purpose so bypasses stay auditable. - Fail-fast: once a command fails, the rest don't run. Parallel execution is a follow-up polish. - 7 test cases in .claude/hooks/tests/test_pre_push_gate.sh — all pass on the shipped default + a minimal custom config. Updates docs/rule-audit.md to flip "partial" → "yes" for the "before git push" rule. Integrates with the shared config reader landed in #109. #111 * fix(#111): remove orphaned footnote reference from rule-audit The previous advisory-mode footnote was superseded by pre-push-111 but its definition was accidentally kept, tripping markdownlint MD053 (unused reference definition). Drop it. --------- Co-authored-by: me2resh <ahmed.abdelaliem@gmail.com>
Mechanically enforces the ticket body schema when an agent files raw `gh issue create` calls instead of going through the interactive /feature, /task, /bug skills. Matches bracketed title prefix ([Feature] / [Chore] / [Bug] / [Docs] / etc.) against `.ticket.required_sections` in project-config, and blocks (exit 2) when any required section is missing or empty. Skip marker `<!-- validate-issue-structure: skip -->` bypasses with a visible stderr WARN for legitimate off-template tickets (epics, meta-threads). Changes: - .claude/hooks/validate-issue-structure.sh — the hook; reads schema via the shared _lib-read-config.sh, with inlined defaults for bare checkouts predating the config-schema rollout. Handles --body / --body-file / -F path. - .claude/project-config.defaults.json — extends .ticket with required_sections (Feature/Chore/Refactor/Testing/CI/Docs/Bug) and skip_marker; other .ticket fields untouched. - .claude/settings.json — new PreToolUse matcher on Bash(gh issue create *) alongside the existing suggest-ticket-template.sh and block-private-refs-in-public-repos.sh hooks. - .claude/hooks/tests/test_validate_issue_structure.sh — 15 cases covering pass + fail paths per prefix, empty section detection, skip marker, unknown prefix, non-gh invocation, --body-file path. - docs/rule-audit.md — new section 11 row, mechanized count +1. Upstream ticket: #107 Co-authored-by: me2resh <ahmed.abdelaliem@gmail.com>
Closes the asymmetry noted in .claude/rules/agdr-decisions.md: every
other HARD STOP in the ruleset (merge approval, ticket-first,
migration-first) is mechanically enforced, but the /decide HARD STOP
was prose-only. The commit-time hook require-agdr-for-arch-changes.sh
catches one architectural change at commit; this new PR-time hook
catches the cumulative diff so reviewers always have a pointer to the
decision record.
- New hook at .claude/hooks/require-agdr-for-arch-pr.sh
- Fires on Bash(gh pr create *)
- Parses --title/--body/--body-file/-F <path>
- Resolves base branch from --base, else upstream/dev, origin/dev,
upstream/main, origin/main, main, master (in that order)
- Computes `git diff <merge-base>..HEAD --name-only`
- Triggers on any changed file matching .agdr_trigger_paths[], OR any
dep-file addition (package.json via jq key-set diff; other
dep files via a commented +/- line-count heuristic — version
bumps match +/- counts and do not fire)
- Blocks (exit 2) with a helpful message naming the triggers and
pointing at /decide if the body has no `AgDR-\d+-[a-z0-9-]+`
reference
- Skip marker `<!-- agdr: not-applicable -->` bypasses with a
visible WARN on stderr
- Silent exit 0 on non-gh commands, empty diffs, unresolvable base
- Wired via .claude/settings.json PreToolUse Bash(gh pr create *)
- Adds two new top-level keys to .claude/project-config.defaults.json:
agdr_trigger_paths (shell globs — domain/, infrastructure/,
migrations/, *.tf, .github/workflows/, etc.)
agdr_trigger_dep_files (literal basenames — package.json,
pyproject.toml, Cargo.toml, go.mod, Gemfile)
Hook has inline fallback defaults kept in sync.
- Adds docs/rule-audit.md entry in the AgDR section; bumps mechanized
count 26 to 27 and total rows 73 to 74.
- Adds .claude/hooks/tests/test_require_agdr_for_arch_pr.sh (7 cases;
all green): path-triggered without AgDR (block), with AgDR (pass),
dep-file added (block), version-only bump (no fire), skip marker
(pass + warn), non-matching diff (pass), non-gh command (no-op).
Closes #112
Co-authored-by: me2resh <ahmed.abdelaliem@gmail.com>
Extends validate-pr-create.sh with a required-sections check that replaces the hardcoded Glossary-only grep. The list of required H2 headings is project-configurable via `.pr.required_sections[]`. Shipped default is ["Testing", "Glossary"], matching the canonical PR description shape in workflows/code-review.md. - Each entry must appear as `## <Name>` (case-insensitive). - Empty sections are tolerated at this layer (the issue-structure hook #107 does stricter empty-content checks for issue bodies; for PR bodies, empty sections are left to the reviewer's judgement). - Skip marker `<!-- pr-sections: skip -->` bypasses with a visible stderr WARN — for trivial PRs (lint-only fixes, version bumps) where the full template is overkill. - Reads from project config via the shared _lib-read-config.sh (#109). Inline fallback matches shipped defaults so bare checkouts predating #109 keep working. - 8 test cases cover: all-sections pass, each missing section, missing-both (both errors printed), skip marker, case-insensitive headings, H3 rejection. #113 Co-authored-by: me2resh <ahmed.abdelaliem@gmail.com>
* chore(#114): enforce single Closes-keyword per PR body Caps distinct auto-closing references (close/closes/closed, fix/fixes/ fixed, resolve/resolves/resolved + N or owner/repo+N) at one per PR body. Closes the loophole where the title validator limited the title to one ticket but multiple Closes lines in the body would still auto- close all of them on merge. - Scans stripped of fenced code blocks so closing keywords inside a code sample do not count. - Distinct counting: the same number referenced twice (e.g. via Fixes and Closes) counts as one. - Cross-repo refs (owner/repo+N) count normally. - Opt-in escape hatch: pr.allow_multiple_closes=true in project-config disables the check for teams that deliberately batch rollbacks or dependency bumps. - Per-PR bypass: a multi-close-approved HTML comment in the body prints a visible stderr WARN and lets that PR through. Grep-able trace so bypasses are auditable. - 10 test cases cover: one close passes, no-keyword passes, two distinct block, three mixed block, same-number-twice passes, code- fence-ignored, skip marker, cross-ref without keyword, opt-in config, cross-repo close. Reads configuration via the shared _lib-read-config.sh (apexyard+109). #114 * fix(#114): strip inline backticks and tilde fences from close-count scan Rex caught a self-reflexive bug in the initial commit: documentation mentioning closing keywords inside inline backticks (say a PR body that explains the new hook with examples) counted as real closes, and a skip marker inside inline backticks silently bypassed the check. Future PRs that document the feature would trip the same trap. Fix the code-region stripper to cover: - Triple-backtick fences (already handled) - Tilde fences (new) - Inline-backtick spans (new) Also run the skip-marker check against the stripped body, so a marker used purely as documentation no longer activates a real bypass. Three new test cases pin the behaviour: - closing keywords in inline backticks are ignored - skip marker inside inline backticks does NOT bypass - tilde fences also get stripped 13/13 tests pass. --------- Co-authored-by: me2resh <ahmed.abdelaliem@gmail.com>
The fast happy path for filing 5–20 structured tickets in one intent without dropping to raw `gh issue create` (non-conformant) or running `/feature` 20 times serially (~100 turns of interview). - .claude/skills/tickets-batch/SKILL.md — new skill spec. Asks shared-context questions (priority, epic, area-labels, repo) ONCE for the whole batch, then runs a ≤3-question micro-interview per ticket (type, one-line purpose, optional clarification when the inference is low-confidence). Confirms the full batch as a table, then files each via specific `gh issue create` calls (never a bulk JSON dump — the validator runs per-issue). Output conforms to `.ticket.required_sections` by construction. Caps at 20 tickets per invocation. - CLAUDE.md — added a row for /tickets-batch in the Available Skills table; bumped the count references from 33 to 34. Refs #108 Co-authored-by: me2resh <ahmed.abdelaliem@gmail.com>
- Add `.claude/skills/fan-out/SKILL.md` — spawns N parallel Agent calls in a single assistant message, with per-task agent type, worktree isolation, and foreground/background mode. Caps at 5 concurrent agents. Refuses fan-out when tasks share file write targets or have sequential dependencies. Includes pre-spawn active-ticket safety check and worktree merge-back flow that pauses on conflict. - Add `.claude/rules/parallel-work.md` — trigger heuristic for when an agent should proactively offer fan-out (>= 2 file-independent, context-independent, individually substantial work items). Pairs with the skill: rule says when, skill says how. - Update `CLAUDE.md` — bump rules count to 9, skills count to 34, add `/fan-out` row to the skills table. Refs #117 Co-authored-by: me2resh <ahmed.abdelaliem@gmail.com>
…work only (#126) * chore(#116): adopt release-cut branch model (dev/main + tags) Formalises the dev/main split that already exists informally — dev is the daily-work branch where every PR lands, main is release-only, tagged with semver on each merge. Framework-only: managed projects under apexyard governance stay trunk-based. Added: - AgDR-0007 — decision record (options table covers full git flow vs trunk-only vs gitflow-lite; chose gitflow-lite) - /release skill — diff dev against main, propose semver bump from conventional commits, generate CHANGELOG, open release PR, tag after merge - docs/release-process.md — prose runbook for cutting a release (manual fallback for the skill) - .git.protected_branches in project-config.defaults.json (main/master/dev/develop) Modified: - block-main-push.sh — now blocks direct pushes/commits to all configured protected branches (was: hardcoded main/master). Reads .git.protected_branches via the shared config reader (apexyard#109). - CLAUDE.md — new section under Git Conventions explaining the dev/main model + the framework-only scope. Skill table entry for /release. Skills count bumped to 34. - docs/multi-project.md — note that upstream/main is release-only and the dev/main split is framework-only. Non-consequences (per AgDR-0007): - No release/* or hotfix/* branches. Hotfixes are normal patches cut quickly. Revisit if multi-version maintenance becomes a need. - No automatic on-merge issue closing for dev PRs. The release PR's body aggregates all Closes references for the batch and triggers auto-close en masse when it merges to main. Manual close in the meantime. - CI workflows trigger on pull_request regardless of base, so dev-targeting PRs already get the full check matrix — no workflow file edits needed. #116 * fix(#116): satisfy markdownlint MD032 + MD060 in 116 docs Auto-fix added blank lines around lists in AgDR-0007 (MD032) and spaced the table separators in AgDR-0007 + multi-project.md (MD060). Content unchanged. --------- Co-authored-by: me2resh <ahmed.abdelaliem@gmail.com>
…129) * fix(#106): CHANGELOG fallback in drift hook for squash-merged forks The v1.1.0 tag-reachability check (`git tag --merged main`) misfires on forks that sync via GitHub's default squash-merge: the squash collapses the upstream-tag commit into a synthetic SHA, the tag stops being reachable, and the banner keeps firing forever. Discovered live on the first real-world `/update` flow: ops fork squash-merged the v1.1.0 sync PR, banner kept saying "v1.1.0 available" even though the fork was content-caught-up. This commit adds a CHANGELOG-content fallback that fires only when the primary tag check fails. If the fork's main has a heading `## [X.Y.Z]` matching the upstream tag's version, treat the release as absorbed and stay silent. Tolerant grep (matches the apexyard CHANGELOG format from v1.1.0 onward, with leading-`v` stripping for tag→heading conversion). The merge-commit and rebase paths are unchanged — primary tag check still works for them, and the fallback never fires when it shouldn't. Test coverage (5 cases): - squash-merge fork caught up to v1.1.0 → silent (the fix) - merge-commit fork caught up to v1.1.0 → silent (regression check) - fork stopped at v1.0.0 → banner fires - fork has its own newer tag → silent - squash-merge but no CHANGELOG on fork → banner fires (no false silence) Records the strategy update in docs/agdr/AgDR-0008-…md (extends AgDR-0005's tag-based-drift design). #106 * fix(#106): satisfy markdownlint MD032/MD060 + shellcheck SC2164 Rex flagged two CI-blocking issues on the original 106 commit: - AgDR-0008 had three bulleted sub-lists in the Consequences section without surrounding blank lines (MD032). Added blanks and padded the one tight-pipe table separator (MD060). - The 106 test fixture had five subshell `cd "$fk"` calls without `|| exit 1` (SC2164). Added the guard to all five. 5/5 tests still pass after the fix. No semantic change to the hook or the test logic. --------- Co-authored-by: me2resh <ahmed.abdelaliem@gmail.com>
A 10-minute, 5-question check that sits between /idea and /write-spec.
Designed for solo founders running ApexYard — not a heavyweight
methodology like event storming or Wardley mapping.
Five questions, asked one at a time:
1. Who is this specifically for?
2. What do they do today instead?
3. What's the smallest version that proves the value?
4. What would prove this is wrong? (kill criteria)
5. Build, buy, or rent?
Output: a one-page validation doc with a GREEN/YELLOW/RED verdict.
RED auto-updates the IDEA-NNN backlog row to WONTDO.
Integration:
/idea — adds an optional default-no "Validate now?" step after
capture (and after the optional GitHub Issue offer).
/handover — adds a conditional "this looks dormant, validate?"
step at the end of the integration plan, gated on the dormancy
heuristic (last commit > 90d AND zero open PRs AND no recent
issue activity). Healthy projects don't see the prompt.
CLAUDE.md skills count bumped to 35; new skills row added.
#130
Co-authored-by: me2resh <ahmed.abdelaliem@gmail.com>
…prompts-on-pause) (#135) Stop hook that speaks the assistant's question aloud (Jarvis-style) when it pauses for user input. Initial phase is macOS-only via `say`, no voice input — user replies via keyboard. Default OFF. Adopters opt in by overriding `voice_prompts.enabled` to true in `.claude/project-config.json`. Files: - .claude/hooks/voice-prompt-on-pause.sh — Stop hook with config gate, trigger heuristic (questions-only by default), markdown stripping, sentence-boundary truncation, fire-and-forget say invocation - .claude/hooks/tests/test_voice_prompt_on_pause.sh — 9 cases covering disabled-default, enabled+question, enabled+statement, approved-pattern, abc-menu, malformed-transcript, no-say-on-PATH, trigger-always, markdown-stripping - .claude/project-config.defaults.json — voice_prompts schema block added (enabled, voice, max_chars, rate_wpm, trigger), default OFF - .claude/settings.json — new Stop hook entry wired with the standard ops-root resolver wrapper - docs/agdr/AgDR-0009-voice-prompts-on-pause.md — design rationale, options matrix (status quo / macOS say / cloud TTS / ML detection), consequences, future phases - docs/project-config.md — new "Voice prompts" section with override examples and privacy notes Test mode: hook respects VOICE_PROMPTS_SYNC=1 to run say synchronously (test runners need this so assertions don't race against orphaned background processes). Production invocations always run async. Future phases (out of scope here, AgDR §"Future phases"): - Phase 2: cross-platform TTS (Linux espeak, Windows SpeechSynthesizer) - Phase 3: cloud TTS providers (OpenAI, ElevenLabs) — privacy AgDR-worthy - Phase 4: voice input via Whisper-based STT - Phase 5: per-message overrides Refs: #134 Co-authored-by: me2resh <ahmed.abdelaliem@gmail.com>
…#142) * feat(#141): add /debug skill — structured hypothesis-driven debugging Adds a methodology skill that enforces five disciplines: 1. Capture the symptom precisely (exact URL, exact response, exact step) 2. Read the architecture before guessing (map every layer the request touches, file by file) 3. Form a hypothesis ladder (3–5 candidates, each with an explicit evidence test that confirms or refutes it) 4. Gather evidence first, fix second 5. Verify the fix against the original symptom evidence (re-run the same `curl` / browser repro you used in step 4 — unit tests verify code, not feature, correctness) Stack appendices (Web, Desktop) carry stack-specific surface-evidence requirements (step 1), architecture-surface maps (step 2), and evidence-tests cookbooks (step 4). The methodology body stays portable across stacks; appendices are where stack-specific knowledge accrues over time. Web appendix covers browser routing, framework configs (Next/Nuxt/Vite), SPA-fallback layers, CDN, origin, the shared API client, backend handlers, and auth providers. Desktop appendix covers Electron / Tauri / native-shell concerns: app entry points, IPC bridges, native modules, auto-updater, sandbox / entitlements, code signing, crash reports. Includes "When NOT to use" guidance so the methodology overhead doesn't sandbag simple bugs (typos, off-by-ones, greenfield exploration). Motivated by a real OAuth debug session in a managed project where three sequential fixes chased adjacent symptoms because each was hypothesis-then-fix without evidence in between. The skill is the "never do that again" guardrail. Closes #141 * fix(#141): scrub private project issue numbers from anti-pattern table Rex review on PR #142 caught that line 155 of the skill's anti-pattern table still named the originating PRs (#375, #377, #380) from the private project where the methodology was first exercised. The PR body and commit message were correctly abstracted earlier, but this in-file reference slipped through — the leak-protection hook only scans gh issue/pr writes, not staged file content, so mechanical enforcement didn't catch it. Replaced with "Three sequential PRs chasing the same symptom because each was based on a different guess (no evidence test in between cycles)" — same pedagogical value, zero attribution. Refs #141 --------- Co-authored-by: me2resh <ahmed.abdelaliem@gmail.com>
…144) Adopters on GitHub Free with any private project hit a silent privacy bug following today's docs: forking apexyard makes a public fork that you cannot later flip to private (GitHub policy), and committing `apexyard.projects.yaml` + `projects/<name>/` to the fork publishes private project names + handover findings on a public GitHub repo. This PR documents the supported workaround — split-portfolio mode — and adds an upfront privacy gate to the /setup skill so new adopters never hit the trip-wire silently. docs/multi-project.md: - New "Two setup modes — pick the one that matches your privacy needs" section before TL;DR, with a side-by-side table and the explicit trip-wire callout. - Existing TL;DR retitled "TL;DR — single-fork mode (default)" with a one-line pointer to the split-portfolio section. - New "Split-portfolio mode — public framework + private portfolio" section between the existing setup steps and the directory-layout section. Includes: - The two-repo layout (~/ops/apexyard public + ~/ops/portfolio private) - 7-step setup walkthrough with copy-pasteable commands - Daily workflow + upstream sync notes (both unchanged) - Trade-offs (two repos to maintain, two clones per machine, one upstream-sync conflict path on `projects/README.md`) - "Migrating from single-fork to split-portfolio" recovery flow with the explicit warning that GitHub Issue / PR edit history survives a force-push and must be redacted separately .claude/skills/setup/SKILL.md: - New Step 2a: privacy gate — asks "are any projects private?" before proposing the config. Branches on the answer: - All public → single-fork mode - GitHub Pro / Team / Enterprise → single-fork mode (private forks of public repos are supported on those plans) - Any private + GitHub Free → split-portfolio mode - New Step 2b: walks through the split-portfolio setup interactively (private repo create, sibling clone, gitignore + symlink) when the privacy gate triggers. - Detection: `test -L apexyard.projects.yaml` short-circuits Step 2b for adopters already in split mode. - Explicit "do NOT auto-migrate" rule for adopters already in single-fork mode with private names already pushed — that path is destructive (force-push history rewrite + redact issue/PR bodies + delete backup branch) and warrants a deliberate, eyes-open run, not a /setup side effect. Out of scope for this PR (tracked separately on #143): - `portfolio:` config block in `onboarding.yaml` schema - Skill audit + refactor to honour configured `registry` / `projects_dir` / `ideas_backlog` paths instead of hardcoded fork-relative paths - `/split-portfolio` migration helper skill that automates the recovery flow currently documented manually This is the docs-and-setup-question minimum-viable starter — the framework code refactor is mechanical and lands as a follow-up. Refs #143 Co-authored-by: me2resh <ahmed.abdelaliem@gmail.com>
…#147) * feat(#145): portfolio config block + self-healing + /split-portfolio helper Closes the framework primitive deferred from #144. Adds first-class config-driven path resolution for the portfolio registry, projects dir, and ideas backlog, with self-healing surfacing of broken config at session start, plus a new /split-portfolio skill that automates the destructive recovery flow. Schema, helper, and hook: - .claude/project-config.defaults.json: new portfolio: block (registry, projects_dir, ideas_backlog) with defaults matching today's single-fork layout - .claude/hooks/_lib-portfolio-paths.sh: new sourceable helper exposing portfolio_registry, portfolio_projects_dir, portfolio_ideas_backlog, portfolio_validate, portfolio_clear_cache. Resolves relative paths against the ops-fork root. - .claude/hooks/check-portfolio-config.sh: new SessionStart hook — silent on OK, one-line banner on broken config, never blocks session - .claude/hooks/tests/test_portfolio_paths.sh: 13 cases covering defaults, absolute/relative overrides, validate states, cache clear Skill audit (18 SKILL.md files): - Adds Path resolution callout pointing at the helper - handover bash blocks now source helper and use $(portfolio_registry) instead of literal apexyard.projects.yaml - setup Step 2b now writes the portfolio: config block (recommended) and validates via portfolio_validate before declaring success; symlink approach kept as legacy fallback New skill (.claude/skills/split-portfolio/SKILL.md): - 10-step migration with explicit operator-confirmation gates at each destructive step (force-push, body redaction, branch deletion) - --verify mode: read-only state report (mode, paths, validate, drift) - --dry-run mode: prints commands without executing - Pre-flight refusals: already-private fork, paid GitHub plan, dirty working tree, already-migrated state - Step 9 writes the portfolio: config block (not symlinks) — symlink fallback documented for adopters on older framework versions - Step 9 surfaces the GitHub timeline-API survival caveat verbatim - Idempotent re-runs: detects partial-migration state and resumes Docs (docs/multi-project.md): - Layout section describes both modes (config-block recommended, symlink legacy) with self-healing notes - Setup steps split into config-block mode and legacy symlink mode - Migration section now points at /split-portfolio skill; manual recipe preserved as fallback AgDR (docs/agdr/AgDR-0010-portfolio-config-and-self-healing.md): - Full Y-statement, options, decision, consequences, future phases - Schema decision rationale: project-config.json over onboarding.yaml because runtime path resolution belongs in project-config Closes #145 Refs #146 (delivered same PR; closed manually post-merge per the single-Closes-keyword rule in validate-pr-create.sh) Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(#145): markdownlint MD031 — blank lines around fences CI's markdownlint-cli2 (v0.34.0) flagged the JSON + bash fenced code blocks I added in setup/SKILL.md Step 2b without surrounding blank lines. Added the required blanks. No content change. Refs #147 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> --------- Co-authored-by: me2resh <ahmed.abdelaliem@gmail.com> Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…ork auto-publish (#149) The privacy-gate wording introduced in PR #144 (and unchanged in PR #147) attributed the publication to the framework rather than the adopter: "the standard fork-and-commit setup will silently publish your private project names on a public GitHub repo" That's factually wrong. ApexYard never pushes anything without explicit operator approval — the publication only happens when the adopter themselves runs git push. The "silently publish" framing read as if the framework auto-publishes, which is misleading and undermines trust in the rest of the framework's safety claims. Two prose-only edits, no code, no behavior change: - .claude/skills/setup/SKILL.md Step 2a — replaced "will silently publish ..." with adopter-action language ("you might accidentally publish ... a stray git push after registering them — I won't push without your approval, but the risk is on the adopter once the data is committed locally") - docs/multi-project.md trip-wire callout — replaced "silently publish their portfolio names the moment they push" with "risk accidentally publishing their portfolio names with a stray push (the framework itself never pushes without operator approval, but once the registry is committed locally the next push exposes it)" Verified: `grep -r "silently publish" .claude/skills/ docs/` returns no hits. Closes #148 Co-authored-by: me2resh <ahmed.abdelaliem@gmail.com> Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Closes the legitimate-bypass case (#150) and the illegitimate-bypass case (#151) together so the ticket-first gate is coherent. Shipping either alone would leave a window where the framework is internally inconsistent — see AgDR-0011 for the full rationale. Bootstrap exemption (#150): - .claude/session/active-bootstrap marker, written by /setup, /handover, /update, /split-portfolio on entry; cleared on exit - SessionStart sweep (clear-bootstrap-marker.sh) for stale markers from interrupted sessions - require-active-ticket.sh reads the marker and exempts skills on the configured ticket.bootstrap_skills list - bootstrap_skills list lives in .claude/project-config.defaults.json (extendable per fork via .claude/project-config.json) Bash-write coverage (#151): - new _lib-detect-bash-write.sh — heuristic detector for output redirection, tee, sed -i, awk -i inplace, python/node/ruby embedded interpreters - require-active-ticket.sh + require-migration-ticket.sh now fire on Bash in addition to Edit|Write|MultiEdit - design choice: false-negatives preferred over false-positives (the matcher errs toward "let through" rather than block legit read-only commands) Tests: 32 unit cases on the lib + 12 integration cases on the hook, including the exact #151 bypass repro from the issue body. Closes #150 Will manually close #151 post-merge per the single-Closes-per-PR rule (precedent: AgDR-0010 / PR #147). Co-authored-by: me2resh <ahmed.abdelaliem@gmail.com> Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…155) Closes #153. Extends `_lib-detect-bash-write.sh` (introduced for #151 in PR #152) with the matcher families flagged by Rex's review of #152. AgDR-0011 already frames the matcher as a living list extended on observation; this commit just walks the list. New matcher families: - File-moving builtins: `cp`, `mv`, `rm`, `dd`, `install` (anchored at command-start; `--help`/`--version` and `git rm`/`git mv` excluded) - Archive / network writes: `tar -x` / `tar --extract`, `curl -o` / `--output`, `wget -O` / `--output-document` - Additional embedded interpreters: `perl -e`, `php -r` (keyword-gated like python/node/ruby); `go run`, `deno run`/`deno script.ts`, `bun run`/`bun script.ts` (categorical script runners) - Python helpers: `pathlib.Path().touch()`, `shutil.copy*`, `shutil.move`, `os.rename` added to the `python -c` and python heredoc keyword list - Heredoc variants for `ruby` and `node` (previously only python heredoc was covered) Extractor extensions: - `cp` / `mv`: last positional arg - `curl -o` / `--output`: file argument - `wget -O` / `--output-document`: file argument - `tar -x`, `go run`, `deno`, `bun`, `perl -e`, `php -r`: return empty (caller applies gate categorically per AgDR-0011) Test count rose from 32 to 86. Negative-class counterexamples cover the trickiest false-positive surfaces: `tar -t` listing, `cp --help`, `rm --version`, `git rm`, `curl` bare URL fetch, `wget` bare URL fetch, `deno fmt`, `deno test`, `go build`. Existing `test_require_active_ticket_bash.sh` regression suite still passes 12/12. Co-authored-by: me2resh <ahmed.abdelaliem@gmail.com> Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…cy (#156) - add _lib-mock-gh.sh helper that installs a fake `gh` on the sandbox PATH; intercepts `gh issue view <N> ... --json ...` and returns synthetic `{"number":N,"state":"OPEN"}` (overridable per-num via mock_gh_set_state) - wire the shim into test_single_closes_per_pr.sh and test_validate_pr_required_sections.sh so the validator's CLOSED-issue refusal no longer breaks the suite when upstream issues are closed - both files previously failed every case (0/13 and 0/8) because their PR titles reference #114 / #113, which are now CLOSED upstream - post-fix: 13/13 and 8/8; full suite remains green Closes #154 Co-authored-by: me2resh <ahmed.abdelaliem@gmail.com>
…#158) * feat(#132): structured CEO marker + same-turn merge in /approve-merge Closes #132 (drop the "stop before merge" rule) and #48 (harden CEO marker against self-approval bypass) together. The two threads compose — see AgDR-0012 for the full rationale. Streamline (#132): - /approve-merge now runs `gh pr merge --squash --delete-branch` in the same turn as the marker write, by default - --no-merge opt-out preserves the deferred-merge case - The discrete approval moment is the SKILL INVOCATION, not a follow-up "now do the merge" message Harden (#48): - CEO marker is now a structured key/value file with required fields: sha=<HEAD> approved_by=user skill_version=2 Validated by block-unreviewed-merge.sh; bare-SHA legacy markers rejected with a clear "stale format" error pointing at /approve-merge - The model's bare `echo SHA > <pr>-ceo.approved` bypass is now mechanically rejected. Forging the structured fields requires a deliberate, visible rule violation rather than a one-line accident - Optional audit fields (approved_at, approval_summary) capture the "what did the user say when they approved" trail - Rex marker stays bare-SHA — different threat model (automated reviewer, not human authorization moment) pr-workflow.md reframed: "the load-bearing rule is explicit per-PR approval, not two user messages." The merge is a deterministic consequence of the approval invocation. Tests: 12 cases on the hardened hook covering the new format end-to-end (valid v2, missing rex/ceo, bare-SHA legacy rejected, missing approved_by, wrong approved_by, skill_version=1, sha mismatch, non-merge no-op, gh-api shape gated). Full suite: 205/205 across 13 test files. Will manually close #48 post-merge per the single-Closes-per-PR rule (precedent: PR #152 / AgDR-0011). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * chore(#132): redact private project reference from AgDR-0012 Abstracted two references to a registered private project that named the project's owner/repo. The leak-protection hook caught one in the PR body; this fixup removes the matching references from the AgDR-0012 file content (which would otherwise have shipped the names to me2resh/apexyard public repo via the merge). The pre-existing reference at .claude/rules/pr-workflow.md:130 (documenting #47) is untouched — it predates this PR and is already on the public repo's history. Refs #132. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * chore(#132): markdownlint blanks-around-fences + typo fix Two small fixups against red CI / Rex feedback: - AgDR-0012 line 63: fenced code block now has a blank line before it (MD031). markdownlint-cli2 0.13.0 was rejecting the indented fence inside the bullet because the fence's preceding line was the bullet text (no blank). - approve-merge SKILL.md line 172: typo `deferes` → `defers` (Rex flag on PR #158). Refs #132. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> --------- Co-authored-by: me2resh <ahmed.abdelaliem@gmail.com> Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…#161) * chore(#157): remove voice-prompts-on-pause feature + correct hook/skill counts Closes #157 (sunset the voice-prompts feature) and #77 (hook count off-by-one in CHANGELOG / CLAUDE.md) in one bundled PR. AgDR-0013 supersedes AgDR-0009 with the full rationale; both AgDRs are preserved (decision records are append-only history). Removed (#157): - .claude/hooks/voice-prompt-on-pause.sh - .claude/hooks/tests/test_voice_prompt_on_pause.sh - Stop matcher block in .claude/settings.json (became empty after voice removal) - voice_prompts block in .claude/project-config.defaults.json - "## Voice prompts" section in docs/project-config.md - voice_prompts mention in AgDR-0010 line 32 (replaced with leak_protection / ticket as still-current example config blocks) Preserved: - docs/agdr/AgDR-0009-voice-prompts-on-pause.md — historical record; new "Superseded by: AgDR-0013" header at the top - AgDR-0010 line 115 reference to AgDR-0009 — still accurate as a historical pattern reference Counts corrected (#77): - CHANGELOG.md v0.3.0 stats: "17 hooks" → "18 hooks" (historical fix — at v0.3.0 there were actually 18 hooks) - CLAUDE.md table line: "18 shell scripts" → "24 shell scripts" (current count after this removal) - CLAUDE.md table line: "35 slash commands" → "39 slash commands" - CLAUDE.md "Available skills (34)" → "Available skills (39)" - CLAUDE.md quick-reference "Skills (35 slash commands)" → "(39 slash commands)" Why bundled: #77's correct count depends on whether voice is still in the framework. Shipping #77 before #157 would write a number that's wrong by one again the moment #157 lands. Same shape as previous bundles (PR #152 / AgDR-0011, PR #158 / AgDR-0012). Why no adopter-facing changelog mention of the voice removal: the feature never reached a tagged release on main. v1.1.0 didn't have it; v1.2.0 won't have it. From the adopter's perspective there's nothing to retire. AgDR-0013 captures the framework's internal record for future contributors. See AgDR-0013 § "No adopter-facing changelog mention". Tests: full hook test suite green (196 cases across 12 files — test_voice_prompt_on_pause.sh removed). No regressions. Will manually close #77 post-merge per the single-Closes-per-PR rule (precedent: PRs #152, #158). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * chore(#157): unwire voice from settings + configs + docs + AgDR-0013 Continuation of d78eb08 (the file deletions). Squash-merge will collapse both into one PR commit. This commit captures: - .claude/settings.json — Stop matcher block removed (was the only hook in it; entire matcher gone) - .claude/project-config.defaults.json — voice_prompts block + its _comment removed - docs/project-config.md — "## Voice prompts" section removed - docs/agdr/AgDR-0009-voice-prompts-on-pause.md — "Superseded by" header added at the top, content otherwise preserved as history - docs/agdr/AgDR-0010-portfolio-config-and-self-healing.md — line 32 example reference swapped from voice_prompts to leak_protection / ticket (still-current config blocks) - docs/agdr/AgDR-0013-sunset-voice-prompts.md — new supersession AgDR - CLAUDE.md — hook count 18 → 24, skill count 35 → 39 (three occurrences each, all aligned to current reality) - CHANGELOG.md v0.3.0 stats — "17 hooks" → "18 hooks" historical fix (#77 acceptance criterion 1) Refs #157 + #77. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * chore(#157): markdownlint MD028 + resolve stale AgDR-numbering ref Three small fixups against Rex CHANGES-REQUESTED on PR #161: - AgDR-0009 line 3: promote "Superseded by:" header out of a blockquote. The original "I decided ..." canonical blockquote at line 5 was being merged with the new supersession blockquote (markdownlint MD028 — "no blanks inside blockquote"). - AgDR-0013 line 3: same shape — "Supersedes:" header now a plain bold paragraph, canonical "I decided ..." blockquote untouched. - approve-merge SKILL.md line ~187: stale conditional reference "AgDR-0012 (or 0013 — depends on whether voice-removal lands first)" — order is now resolved (12 = approve-merge bundle, 13 = voice removal). Drop the parenthetical. Refs #157 + #77. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> --------- Co-authored-by: me2resh <ahmed.abdelaliem@gmail.com> Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Landing-site `site/index.html` terminal demo previously played one
canonical flow ("one ticket, start to finish") on autoplay. With the
v1.2.0 skill surface expansion (4 new skills, 8+ new hooks), one flow
no longer represents the framework's breadth.
Adds tabs to the terminal chrome — four flows visitors can either let
auto-cycle or click directly:
1. one ticket — existing flow, unchanged content
2. /handover — adopt an external repo into the portfolio
3. /setup — first-run framework bootstrap on a fresh fork
4. /fan-out — spawn 3 parallel agents on independent tickets
Auto-advance: on completion of the active tab's script, the demo
pauses ~1.8s then advances to the next tab. Loops at the end. User
can interrupt by clicking any tab or hitting Replay.
Implementation:
- HTML chrome — single title span replaced with a tablist of 4 button
tabs. ARIA `role="tablist"` / `role="tab"` / `aria-selected` so
keyboard + screen-reader users get the same semantics as sighted
ones.
- CSS — new `.shell-demo__tabs` + `.shell-demo__tab` with an accent
underline on the active tab. Tabs scroll horizontally on narrow
viewports (mobile responsive).
- JS — refactored the existing IIFE from one `script` array to an
array of four. Added `setActiveTab()` for ARIA state, `play(idx)`
takes a tab index, end-of-script auto-advances to `(idx + 1) % N`
unless the user clicked away during the pause. Adds a new `cmd`
type alongside `you` for slash-command invocations (renders with
the same `>` prompt prefix). prefers-reduced-motion still bails
early and leaves the static seed visible.
- Static seed (the non-JS fallback) still shows tab 0's content, so
reduced-motion / no-JS visitors see the one-ticket flow as before.
Hero metrics also corrected to current reality (#77 / PR #161 covers
CLAUDE.md and CHANGELOG.md; this PR catches the same numbers in the
landing site):
Skills 32 → 39
Hooks 18 → 24
The tabs ship in v1.2.0 alongside the framework changes that make
the new flows worth showcasing.
Refs #160 (release v1.2.0 + landing-site refresh).
Co-authored-by: me2resh <ahmed.abdelaliem@gmail.com>
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…portfolio (#164) Closes #163. The split-portfolio mode docs and skills previously suggested `your-org/ops` as the default name for the private sibling repo, and `portfolio/` as the local clone directory. Both too generic — adopters running multiple ops setups end up with `your-org/ops` collisions, and a bare `portfolio/` dir gives no signal about which framework it belongs to when it sits next to other unrelated `portfolio/` dirs. `<fork>-portfolio` is now the default — keeps the relationship to the public fork explicit on disk and on GitHub. If the fork is named `your-org/apexyard`, the portfolio defaults to `your-org/apexyard-portfolio`. If the fork was renamed (e.g. `cos`), the portfolio defaults to `cos-portfolio`. Adopters with custom names keep working — the `portfolio:` config block resolves whatever path they configured. Files updated: docs/multi-project.md - Layout diagrams use `apexyard-portfolio/` as the sibling - Setup walkthrough Step 2 + Step 3 use `your-org/apexyard-portfolio` and explain the `<fork>-portfolio` pattern - Config-block + symlink path examples updated to `../apexyard-portfolio/...` - Daily workflow + cross-machine clone commands updated - The two existing `your-org/ops` references that remain are fork-rename examples (lines 52, 64) — kept as-is, since renaming the fork to `ops` is still valid (the portfolio would then default to `ops-portfolio`) .claude/skills/setup/SKILL.md - Step 2b's "default suggestion" for the private repo name is now `your-org/<fork>-portfolio`, computed dynamically from the fork's repo name via `gh repo view --json name -q .name` so the suggestion is correct even when the fork was renamed - Clone command no longer needs a second arg — the repo name IS the directory name - Config-block paths updated to `../apexyard-portfolio/...` .claude/skills/split-portfolio/SKILL.md - Step 3's suggested-name template is now `<account>/<fork>-portfolio` with the same dynamic-fork-name resolution Mechanism unchanged. The `portfolio:` config block in `.claude/project-config.json` still takes any path; this PR is purely default-suggestion + example prose. No tests required (skills are markdown instructions; no automated coverage today). Refs `apexyard.projects.yaml.example` uses "ops repo" as a generic term meaning "the operational management fork" — not a name — kept as-is. Co-authored-by: me2resh <ahmed.abdelaliem@gmail.com> Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
#167) Closes #165. Adds a public, browseable index of every apexyard slash command alongside a one-click changelog link from the homepage nav. site/skills.html (new): - Lists all 39 skills currently shipping in .claude/skills/ - Each entry: slash command, argument hint, description (taken verbatim from the SKILL.md frontmatter so the page matches the runtime exactly) - 10 categories: Setup & onboarding, Daily ops, Tickets & ideas, Specs & decisions, Code review & merge, Architecture & dev tools, Production-readiness audits, Workflow primitives, Communications, Deprecated - Same brutalist-terminal design tokens as the homepage — JetBrains Mono, paper-cream background, single warning-red accent, sharp corners. Inlined CSS to keep the static-only no-build-step convention; design vars duplicated rather than extracted to a shared file (~18 vars; cheap to keep in sync). - Mobile responsive — skill grid collapses to single-column under 720px; titlebar nav hides non-CTA items on narrow viewports. - Reduced-motion friendly (no animation in the first place). - Internal anchor TOC at the top so the page scans in seconds. site/index.html (nav addition): - Added two nav links to the titlebar between "what's in the box" and the github CTA: • skills → ./skills.html • changelog → https://github.com/me2resh/apexyard/releases - The changelog link points at the GitHub releases page (not the raw CHANGELOG.md file) so it auto-resolves to the latest tagged release on each visit. v1.2.0 lands and the link is already there. No new dependencies, no build step, no JS for the skills page. The existing site convention (one-html-file-per-route, inlined CSS, optional progressive-enhancement JS) is preserved. Refs #160 (release v1.2.0 + landing-site refresh) — this is the second site-side deliverable for that ticket; the release tag itself follows once #159 (testing) closes. Follow-up worth a separate ticket: a small generator script that walks .claude/skills/*/SKILL.md, parses YAML frontmatter, and emits the skills.html sections automatically. Out of scope for v1.2.0 — first version is hand-curated and will need maintenance until that generator lands. Co-authored-by: me2resh <ahmed.abdelaliem@gmail.com> Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…169) Closes #168. The /release skill prescribed `release/vA.B.C` as the source-branch name and `release: vA.B.C` as the PR title for the dev → main release PR (per AgDR-0007). Both were rejected by the framework's own validators: validate-branch-name.sh required {type}/{TICKET-ID}-{description}; release/v1.2.0 has no ticket-id portion. validate-pr-create.sh required type(SCOPE): form with `release` not in pr.title_type_whitelist. The contradiction surfaced cutting v1.2.0 — the first release under the dev/main model. Three small changes: 1. .claude/hooks/validate-branch-name.sh — added an early-out branch that accepts ^release/vN.N.N(-rcN)?$ as a valid name. Narrow, intentional exception for the framework's release-cut convention; release branches don't carry a ticket-id because the release itself IS the ticket. 2. .claude/project-config.defaults.json — added "release" to pr.title_type_whitelist so a title like `release(#160): v1.2.0` passes validate-pr-create.sh's existing regex unchanged. 3. .claude/skills/release/SKILL.md step 4 — corrected the prescribed PR title to `release(#<release-ticket>): vA.B.C` so future /release invocations produce a title that satisfies the validators by construction. Tested: bash .claude/hooks/validate-branch-name.sh against: release/v1.2.0 → 0 (allowed, release-special-case) release/v1.2.0-rc1 → 0 (allowed, RC variant) release/v9.9.9 → 0 (allowed) release/foo → 2 (correctly blocked) release/v1 → 2 (correctly blocked) chore/GH-168-fix → 0 (allowed, standard pattern) feature/GH-1-x → 0 (allowed, standard pattern) Full hook test suite: 196/196 cases green across 12 test files. Refs: surfaced 2026-05-04 cutting the first release under AgDR-0007. Co-authored-by: me2resh <ahmed.abdelaliem@gmail.com> Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…d check (#171) Closes #170. Completes the work started in #169 (closing #168). #169 added a release-pattern early-out to validate-branch-name.sh so release/vN.N.N branches pass the branch-name validator. But validate-pr-create.sh has its own independent branch-id check at line 273 that #169 didn't touch — and it still rejects release/v1.2.0 because that name doesn't contain a ticket-id substring. This is the same class of contradiction #168 fixed; the fix is the same shape. Add the same release-pattern early-out to the branch-id check in validate-pr-create.sh: - if the branch matches ^release/vN.N.N(-rcN)?$ → exempt (release branches don't carry ticket-ids; the release itself is the ticket) - otherwise → require a ticket-id substring as before #168's acceptance criterion 3 ("validate-pr-create.sh accepts a PR title `release(#160): v1.2.0` against the `release/v1.2.0` branch") was checked off based on the title regex alone but didn't catch the secondary branch-id check living in the same file. Surfaced trying to open the v1.2.0 release PR. Tested: bash .claude/hooks/validate-pr-create.sh against: release/v1.2.0 → 0 (allowed, exempt) release/v1.2.0-rc1 → 0 (allowed, RC variant) chore/GH-1-fix → 0 (allowed, has ticket-id) release/foo → 2 (correctly blocked) chore/no-ticket → 2 (correctly blocked) Refs #168 (the parent bug) + #169 (the partial fix). Co-authored-by: me2resh <ahmed.abdelaliem@gmail.com> Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Closes #173. The release-cut model (AgDR-0007 / #116) squash-merges release/vN.N.N → main, which means the v1.2.0 CHANGELOG section that landed on main via PR #172 was never propagated back to dev. This commit copies main's CHANGELOG.md verbatim onto dev so the v1.2.0 section is now present on both branches. The diff is exactly the v1.2.0 entry being prepended; no other lines change. Without this sync, the next release PR cut from dev would build a v1.3.0 section on top of v1.1.0, silently dropping v1.2.0 from dev's running history. The corollary skill-level fix (option B in the ticket) — updating /release to source the previous CHANGELOG from upstream/main — is filed as a follow-up and out of scope for this PR. Co-authored-by: me2resh <ahmed.abdelaliem@gmail.com> Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Adds /agdr — a portfolio-wide index for Agent Decision Records.
Walks apexyard.projects.yaml, reads each project's docs/agdr/*.md
(local clone if available, else gh api fallback), parses the optional
YAML frontmatter for category + projects, and answers four queries:
- /agdr browse list across the portfolio, grouped by category
- /agdr search <term> full-text grep across all bodies, returns
<project>/AgDR-NNNN paths + matching paragraph
- /agdr show <id> print a specific record, disambiguates duplicates
- /agdr stats counts per category (the marketing-slide tile,
now backed by real data)
Six-category taxonomy: architecture | tech-stack | security | patterns
| integrations | other. Legacy AgDRs without frontmatter remain
first-class — they bucket as `other` and are flagged in browse so
operators can migrate at their own pace.
Backwards-compatible template change: templates/agdr.md gains an
optional `category:` (and optional `projects:`) line in the existing
frontmatter block. Omitting the line keeps every existing AgDR valid;
the skill defaults to `other` when missing.
Doc note in workflows/sdlc.md § Phase 2 points at /agdr search for
"have we decided this before?" lookups before drafting a design.
Smoke test in .claude/hooks/tests/test_agdr_skill.sh covers the
parser the spec specifies — frontmatter extraction, category
bucketing (including the legacy default-to-other path), id reading,
stats aggregation, and search match counts. 18 assertions, all green;
12 pre-existing test suites also green (no regressions).
Closes #181
Co-authored-by: me2resh <ahmed.abdelaliem@gmail.com>
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* release(#160): v1.2.0 (#172)
* chore(#109): project-configurable ticket / branch / commit / PR schema (#118)
* chore(#109): project-configurable ticket / branch / commit / PR schema
Lift the prefix / type whitelists hardcoded across skills, hooks, and
CI into a versioned JSON config read through a shared shell library.
Shipped defaults at .claude/project-config.defaults.json; per-fork
overrides at the optional .claude/project-config.json; one reader
(_lib-read-config.sh) that every consumer now uses.
Added:
- .claude/project-config.defaults.json (v1 schema)
- .claude/hooks/_lib-read-config.sh (shared reader)
- docs/project-config.md (schema reference + extension guide)
- docs/agdr/AgDR-0006-project-configurable-ticket-schema.md
Migrated (still pass with no config present via last-resort fallback):
- validate-branch-name.sh → .branch.type_whitelist
- validate-commit-format.sh → .commit.type_whitelist (legacy
`commit_types` top-level key honoured as backward-compat fallback)
- validate-pr-create.sh → .pr.title_type_whitelist
- /feature, /task, /bug skills reference the config in their Rules
sections; none hardcodes the list any more
Unlocks subsequent config-readers for #107 / #110 / #111 / #112 /
#113 / #114 / #115 — each extends the schema under its own subtree
without further changes to the loader.
https://github.com/me2resh/apexyard/issues/109
* fix(#109): satisfy markdownlint MD032 and MD060 on new docs
Auto-fix MD032 (blank lines around lists) in AgDR-0006 and format
table-separator rows with surrounding spaces (MD060) in both new
doc files. Content unchanged; CI green.
---------
Co-authored-by: me2resh <ahmed.abdelaliem@gmail.com>
* chore(#110): add block-private-refs-in-public-repos.sh hook (#119)
Adds a new PreToolUse hook that blocks gh issue/PR/comment creation and
gh api .../issues|/pulls calls targeting a public framework repo
(default: me2resh/apexyard + whatever `upstream` resolves to) when the
title or body references any registered private project from
apexyard.projects.yaml (by name, repo slug, owner/repo#N ticket ref, or
workspace path).
The hook is a sibling to check-secrets.sh — both scan outgoing content
for identifiers that should never leave the local environment. Skip
marker `<!-- private-refs: allow -->` in the body lets a deliberate
reference through with a visible warning.
Files touched:
- .claude/hooks/block-private-refs-in-public-repos.sh (new)
- .claude/hooks/tests/test_block_private_refs.sh (new)
- .claude/rules/leak-protection.md (new)
- .claude/settings.json (wire PreToolUse matchers for the 5 gh shapes)
- docs/rule-audit.md (append section 10 + bump counts)
Refs: https://github.com/me2resh/apexyard/issues/110
Co-authored-by: me2resh <ahmed.abdelaliem@gmail.com>
* chore(#115): add warn-stale-review-markers.sh PostToolUse hook (#120)
Fires after `git push` to surface review markers that have gone stale
because new commits were pushed past an existing Rex / CEO / design
approval. The merge gate already catches this at `gh pr merge` time,
but only then -- this hook closes the gap by flagging it immediately
at push-time so the author isn't surprised at merge.
- `.claude/hooks/warn-stale-review-markers.sh`
- PostToolUse, non-blocking (PostToolUse exit 2 would push noise
into the conversation; this hook is purely informational).
- Resolves the PR HEAD via `gh pr view --json headRefOid` -- same
source-of-truth as the merge-gate hooks post-apexyard#47 / #55.
Falls back to local HEAD with a visible WARN when gh is offline.
- Silent on: no PR for branch, no markers, fresh markers,
failed push (detected via `rejected` / `failed to push` /
`fatal:` / `error:` markers in tool_response.stderr).
- Modes: `warn` (default) prints one stderr line per stale marker;
`delete` opts in to auto-removal via
`.claude/project-config.json` -> `review_markers.on_stale`.
TODO(apexyard#109): switch to the shared project-config reader
once it lands.
- `.claude/settings.json`
- Wires the hook on PostToolUse / Bash / `git push *`.
- `docs/rule-audit.md`
- Adds a row under section 3 (Code review & PR quality) and
bumps the mechanized count 26 -> 27 / total 73 -> 74.
- `.claude/hooks/tests/test_warn_stale_review_markers.sh`
- 8 cases: no PR, no markers, fresh markers, stale rex / ceo /
design (warn), delete mode, failed push. All pass locally.
Co-authored-by: me2resh <ahmed.abdelaliem@gmail.com>
* chore(#111): upgrade pre-push-gate from advisory reminder to blocking check-runner (#121)
* chore(#111): upgrade pre-push-gate from reminder to blocking check-runner
Previously pre-push-gate.sh just printed a checklist of things to run
locally before pushing — it was advisory. The rule it enforces is a
HARD STOP per pr-workflow.md. That asymmetry meant agents routinely
pushed broken work and discovered it only when CI went red.
Replaces the reminder with a blocking runner that reads the list of
shell commands from project config (.pre_push.commands) and executes
them in sequence before a push is allowed through. First non-zero
exit blocks the push with exit 2 and prints the failing command plus
the last 20 lines of its output.
- Config key: .pre_push.commands[] — array of {name, run} objects.
Shipped default is an empty list (hook stays a no-op on repos that
haven't configured their checks yet, including the framework repo
itself until it wires its own CI).
- Emergency bypass: '<!-- pre-push: skip -->' in the HEAD commit
message. Grep-able on purpose so bypasses stay auditable.
- Fail-fast: once a command fails, the rest don't run. Parallel
execution is a follow-up polish.
- 7 test cases in .claude/hooks/tests/test_pre_push_gate.sh — all
pass on the shipped default + a minimal custom config.
Updates docs/rule-audit.md to flip "partial" → "yes" for the
"before git push" rule.
Integrates with the shared config reader landed in #109.
https://github.com/me2resh/apexyard/issues/111
* fix(#111): remove orphaned footnote reference from rule-audit
The previous advisory-mode footnote was superseded by pre-push-111
but its definition was accidentally kept, tripping markdownlint MD053
(unused reference definition). Drop it.
---------
Co-authored-by: me2resh <ahmed.abdelaliem@gmail.com>
* chore(#107): add validate-issue-structure.sh PreToolUse hook (#122)
Mechanically enforces the ticket body schema when an agent files raw
`gh issue create` calls instead of going through the interactive
/feature, /task, /bug skills. Matches bracketed title prefix
([Feature] / [Chore] / [Bug] / [Docs] / etc.) against
`.ticket.required_sections` in project-config, and blocks (exit 2)
when any required section is missing or empty. Skip marker
`<!-- validate-issue-structure: skip -->` bypasses with a visible
stderr WARN for legitimate off-template tickets (epics, meta-threads).
Changes:
- .claude/hooks/validate-issue-structure.sh — the hook; reads schema
via the shared _lib-read-config.sh, with inlined defaults for bare
checkouts predating the config-schema rollout. Handles
--body / --body-file / -F path.
- .claude/project-config.defaults.json — extends .ticket with
required_sections (Feature/Chore/Refactor/Testing/CI/Docs/Bug) and
skip_marker; other .ticket fields untouched.
- .claude/settings.json — new PreToolUse matcher on Bash(gh issue
create *) alongside the existing suggest-ticket-template.sh and
block-private-refs-in-public-repos.sh hooks.
- .claude/hooks/tests/test_validate_issue_structure.sh — 15 cases
covering pass + fail paths per prefix, empty section detection,
skip marker, unknown prefix, non-gh invocation, --body-file path.
- docs/rule-audit.md — new section 11 row, mechanized count +1.
Upstream ticket: https://github.com/me2resh/apexyard/issues/107
Co-authored-by: me2resh <ahmed.abdelaliem@gmail.com>
* chore(#112): add require-agdr-for-arch-pr.sh PreToolUse hook (#123)
Closes the asymmetry noted in .claude/rules/agdr-decisions.md: every
other HARD STOP in the ruleset (merge approval, ticket-first,
migration-first) is mechanically enforced, but the /decide HARD STOP
was prose-only. The commit-time hook require-agdr-for-arch-changes.sh
catches one architectural change at commit; this new PR-time hook
catches the cumulative diff so reviewers always have a pointer to the
decision record.
- New hook at .claude/hooks/require-agdr-for-arch-pr.sh
- Fires on Bash(gh pr create *)
- Parses --title/--body/--body-file/-F <path>
- Resolves base branch from --base, else upstream/dev, origin/dev,
upstream/main, origin/main, main, master (in that order)
- Computes `git diff <merge-base>..HEAD --name-only`
- Triggers on any changed file matching .agdr_trigger_paths[], OR any
dep-file addition (package.json via jq key-set diff; other
dep files via a commented +/- line-count heuristic — version
bumps match +/- counts and do not fire)
- Blocks (exit 2) with a helpful message naming the triggers and
pointing at /decide if the body has no `AgDR-\d+-[a-z0-9-]+`
reference
- Skip marker `<!-- agdr: not-applicable -->` bypasses with a
visible WARN on stderr
- Silent exit 0 on non-gh commands, empty diffs, unresolvable base
- Wired via .claude/settings.json PreToolUse Bash(gh pr create *)
- Adds two new top-level keys to .claude/project-config.defaults.json:
agdr_trigger_paths (shell globs — domain/, infrastructure/,
migrations/, *.tf, .github/workflows/, etc.)
agdr_trigger_dep_files (literal basenames — package.json,
pyproject.toml, Cargo.toml, go.mod, Gemfile)
Hook has inline fallback defaults kept in sync.
- Adds docs/rule-audit.md entry in the AgDR section; bumps mechanized
count 26 to 27 and total rows 73 to 74.
- Adds .claude/hooks/tests/test_require_agdr_for_arch_pr.sh (7 cases;
all green): path-triggered without AgDR (block), with AgDR (pass),
dep-file added (block), version-only bump (no fire), skip marker
(pass + warn), non-matching diff (pass), non-gh command (no-op).
Closes https://github.com/me2resh/apexyard/issues/112
Co-authored-by: me2resh <ahmed.abdelaliem@gmail.com>
* chore(#113): require Testing section in PR body (config-driven) (#124)
Extends validate-pr-create.sh with a required-sections check that
replaces the hardcoded Glossary-only grep. The list of required H2
headings is project-configurable via `.pr.required_sections[]`.
Shipped default is ["Testing", "Glossary"], matching the canonical PR
description shape in workflows/code-review.md.
- Each entry must appear as `## <Name>` (case-insensitive).
- Empty sections are tolerated at this layer (the issue-structure hook
#107 does stricter empty-content checks for issue bodies; for PR
bodies, empty sections are left to the reviewer's judgement).
- Skip marker `<!-- pr-sections: skip -->` bypasses with a visible
stderr WARN — for trivial PRs (lint-only fixes, version bumps)
where the full template is overkill.
- Reads from project config via the shared _lib-read-config.sh (#109).
Inline fallback matches shipped defaults so bare checkouts predating
#109 keep working.
- 8 test cases cover: all-sections pass, each missing section,
missing-both (both errors printed), skip marker, case-insensitive
headings, H3 rejection.
https://github.com/me2resh/apexyard/issues/113
Co-authored-by: me2resh <ahmed.abdelaliem@gmail.com>
* chore(#114): enforce single Closes-keyword per PR body (#125)
* chore(#114): enforce single Closes-keyword per PR body
Caps distinct auto-closing references (close/closes/closed, fix/fixes/
fixed, resolve/resolves/resolved + N or owner/repo+N) at one per PR
body. Closes the loophole where the title validator limited the title
to one ticket but multiple Closes lines in the body would still auto-
close all of them on merge.
- Scans stripped of fenced code blocks so closing keywords inside a
code sample do not count.
- Distinct counting: the same number referenced twice (e.g. via Fixes
and Closes) counts as one.
- Cross-repo refs (owner/repo+N) count normally.
- Opt-in escape hatch: pr.allow_multiple_closes=true in
project-config disables the check for teams that deliberately batch
rollbacks or dependency bumps.
- Per-PR bypass: a multi-close-approved HTML comment in the body
prints a visible stderr WARN and lets that PR through. Grep-able
trace so bypasses are auditable.
- 10 test cases cover: one close passes, no-keyword passes, two
distinct block, three mixed block, same-number-twice passes, code-
fence-ignored, skip marker, cross-ref without keyword, opt-in
config, cross-repo close.
Reads configuration via the shared _lib-read-config.sh (apexyard+109).
https://github.com/me2resh/apexyard/issues/114
* fix(#114): strip inline backticks and tilde fences from close-count scan
Rex caught a self-reflexive bug in the initial commit: documentation
mentioning closing keywords inside inline backticks (say a PR body
that explains the new hook with examples) counted as real closes, and
a skip marker inside inline backticks silently bypassed the check.
Future PRs that document the feature would trip the same trap.
Fix the code-region stripper to cover:
- Triple-backtick fences (already handled)
- Tilde fences (new)
- Inline-backtick spans (new)
Also run the skip-marker check against the stripped body, so a marker
used purely as documentation no longer activates a real bypass.
Three new test cases pin the behaviour:
- closing keywords in inline backticks are ignored
- skip marker inside inline backticks does NOT bypass
- tilde fences also get stripped
13/13 tests pass.
---------
Co-authored-by: me2resh <ahmed.abdelaliem@gmail.com>
* feat(#108): add /tickets-batch skill for bulk-file flow (#127)
The fast happy path for filing 5–20 structured tickets in one intent
without dropping to raw `gh issue create` (non-conformant) or running
`/feature` 20 times serially (~100 turns of interview).
- .claude/skills/tickets-batch/SKILL.md — new skill spec. Asks
shared-context questions (priority, epic, area-labels, repo) ONCE
for the whole batch, then runs a ≤3-question micro-interview per
ticket (type, one-line purpose, optional clarification when the
inference is low-confidence). Confirms the full batch as a table,
then files each via specific `gh issue create` calls (never a
bulk JSON dump — the validator runs per-issue). Output conforms
to `.ticket.required_sections` by construction. Caps at 20
tickets per invocation.
- CLAUDE.md — added a row for /tickets-batch in the Available
Skills table; bumped the count references from 33 to 34.
Refs https://github.com/me2resh/apexyard/issues/108
Co-authored-by: me2resh <ahmed.abdelaliem@gmail.com>
* feat(#117): add /fan-out skill + parallel-work rule doc (#128)
- Add `.claude/skills/fan-out/SKILL.md` — spawns N parallel Agent calls
in a single assistant message, with per-task agent type, worktree
isolation, and foreground/background mode. Caps at 5 concurrent
agents. Refuses fan-out when tasks share file write targets or have
sequential dependencies. Includes pre-spawn active-ticket safety
check and worktree merge-back flow that pauses on conflict.
- Add `.claude/rules/parallel-work.md` — trigger heuristic for when an
agent should proactively offer fan-out (>= 2 file-independent,
context-independent, individually substantial work items). Pairs
with the skill: rule says when, skill says how.
- Update `CLAUDE.md` — bump rules count to 9, skills count to 34, add
`/fan-out` row to the skills table.
Refs https://github.com/me2resh/apexyard/issues/117
Co-authored-by: me2resh <ahmed.abdelaliem@gmail.com>
* chore(#116): adopt release-cut branch model (dev/main + tags) — framework only (#126)
* chore(#116): adopt release-cut branch model (dev/main + tags)
Formalises the dev/main split that already exists informally — dev is
the daily-work branch where every PR lands, main is release-only,
tagged with semver on each merge. Framework-only: managed projects
under apexyard governance stay trunk-based.
Added:
- AgDR-0007 — decision record (options table covers full git flow vs
trunk-only vs gitflow-lite; chose gitflow-lite)
- /release skill — diff dev against main, propose semver bump from
conventional commits, generate CHANGELOG, open release PR, tag
after merge
- docs/release-process.md — prose runbook for cutting a release
(manual fallback for the skill)
- .git.protected_branches in project-config.defaults.json
(main/master/dev/develop)
Modified:
- block-main-push.sh — now blocks direct pushes/commits to all
configured protected branches (was: hardcoded main/master). Reads
.git.protected_branches via the shared config reader (apexyard#109).
- CLAUDE.md — new section under Git Conventions explaining the
dev/main model + the framework-only scope. Skill table entry for
/release. Skills count bumped to 34.
- docs/multi-project.md — note that upstream/main is release-only
and the dev/main split is framework-only.
Non-consequences (per AgDR-0007):
- No release/* or hotfix/* branches. Hotfixes are normal patches
cut quickly. Revisit if multi-version maintenance becomes a need.
- No automatic on-merge issue closing for dev PRs. The release PR's
body aggregates all Closes references for the batch and triggers
auto-close en masse when it merges to main. Manual close in the
meantime.
- CI workflows trigger on pull_request regardless of base, so
dev-targeting PRs already get the full check matrix — no
workflow file edits needed.
https://github.com/me2resh/apexyard/issues/116
* fix(#116): satisfy markdownlint MD032 + MD060 in 116 docs
Auto-fix added blank lines around lists in AgDR-0007 (MD032) and
spaced the table separators in AgDR-0007 + multi-project.md (MD060).
Content unchanged.
---------
Co-authored-by: me2resh <ahmed.abdelaliem@gmail.com>
* fix(#106): CHANGELOG fallback in drift hook for squash-merged forks (#129)
* fix(#106): CHANGELOG fallback in drift hook for squash-merged forks
The v1.1.0 tag-reachability check (`git tag --merged main`) misfires on
forks that sync via GitHub's default squash-merge: the squash collapses
the upstream-tag commit into a synthetic SHA, the tag stops being
reachable, and the banner keeps firing forever.
Discovered live on the first real-world `/update` flow: ops fork
squash-merged the v1.1.0 sync PR, banner kept saying "v1.1.0 available"
even though the fork was content-caught-up.
This commit adds a CHANGELOG-content fallback that fires only when the
primary tag check fails. If the fork's main has a heading
`## [X.Y.Z]` matching the upstream tag's version, treat the release as
absorbed and stay silent. Tolerant grep (matches the apexyard CHANGELOG
format from v1.1.0 onward, with leading-`v` stripping for tag→heading
conversion).
The merge-commit and rebase paths are unchanged — primary tag check
still works for them, and the fallback never fires when it shouldn't.
Test coverage (5 cases):
- squash-merge fork caught up to v1.1.0 → silent (the fix)
- merge-commit fork caught up to v1.1.0 → silent (regression check)
- fork stopped at v1.0.0 → banner fires
- fork has its own newer tag → silent
- squash-merge but no CHANGELOG on fork → banner fires (no false silence)
Records the strategy update in docs/agdr/AgDR-0008-…md (extends
AgDR-0005's tag-based-drift design).
https://github.com/me2resh/apexyard/issues/106
* fix(#106): satisfy markdownlint MD032/MD060 + shellcheck SC2164
Rex flagged two CI-blocking issues on the original 106 commit:
- AgDR-0008 had three bulleted sub-lists in the Consequences section
without surrounding blank lines (MD032). Added blanks and padded the
one tight-pipe table separator (MD060).
- The 106 test fixture had five subshell `cd "$fk"` calls without
`|| exit 1` (SC2164). Added the guard to all five.
5/5 tests still pass after the fix. No semantic change to the hook
or the test logic.
---------
Co-authored-by: me2resh <ahmed.abdelaliem@gmail.com>
* feat(#130): add /validate-idea skill — lightweight pre-spec gate (#131)
A 10-minute, 5-question check that sits between /idea and /write-spec.
Designed for solo founders running ApexYard — not a heavyweight
methodology like event storming or Wardley mapping.
Five questions, asked one at a time:
1. Who is this specifically for?
2. What do they do today instead?
3. What's the smallest version that proves the value?
4. What would prove this is wrong? (kill criteria)
5. Build, buy, or rent?
Output: a one-page validation doc with a GREEN/YELLOW/RED verdict.
RED auto-updates the IDEA-NNN backlog row to WONTDO.
Integration:
/idea — adds an optional default-no "Validate now?" step after
capture (and after the optional GitHub Issue offer).
/handover — adds a conditional "this looks dormant, validate?"
step at the end of the integration plan, gated on the dormancy
heuristic (last commit > 90d AND zero open PRs AND no recent
issue activity). Healthy projects don't see the prompt.
CLAUDE.md skills count bumped to 35; new skills row added.
https://github.com/me2resh/apexyard/issues/130
Co-authored-by: me2resh <ahmed.abdelaliem@gmail.com>
* feat: configurable voice prompts on assistant pause (AgDR-0009-voice-prompts-on-pause) (#135)
Stop hook that speaks the assistant's question aloud (Jarvis-style)
when it pauses for user input. Initial phase is macOS-only via `say`,
no voice input — user replies via keyboard.
Default OFF. Adopters opt in by overriding `voice_prompts.enabled` to
true in `.claude/project-config.json`.
Files:
- .claude/hooks/voice-prompt-on-pause.sh — Stop hook with config gate,
trigger heuristic (questions-only by default), markdown stripping,
sentence-boundary truncation, fire-and-forget say invocation
- .claude/hooks/tests/test_voice_prompt_on_pause.sh — 9 cases covering
disabled-default, enabled+question, enabled+statement, approved-pattern,
abc-menu, malformed-transcript, no-say-on-PATH, trigger-always,
markdown-stripping
- .claude/project-config.defaults.json — voice_prompts schema block
added (enabled, voice, max_chars, rate_wpm, trigger), default OFF
- .claude/settings.json — new Stop hook entry wired with the standard
ops-root resolver wrapper
- docs/agdr/AgDR-0009-voice-prompts-on-pause.md — design rationale,
options matrix (status quo / macOS say / cloud TTS / ML detection),
consequences, future phases
- docs/project-config.md — new "Voice prompts" section with override
examples and privacy notes
Test mode: hook respects VOICE_PROMPTS_SYNC=1 to run say synchronously
(test runners need this so assertions don't race against orphaned
background processes). Production invocations always run async.
Future phases (out of scope here, AgDR §"Future phases"):
- Phase 2: cross-platform TTS (Linux espeak, Windows SpeechSynthesizer)
- Phase 3: cloud TTS providers (OpenAI, ElevenLabs) — privacy AgDR-worthy
- Phase 4: voice input via Whisper-based STT
- Phase 5: per-message overrides
Refs: https://github.com/me2resh/apexyard/issues/134
Co-authored-by: me2resh <ahmed.abdelaliem@gmail.com>
* feat(#141): add /debug skill — structured hypothesis-driven debugging (#142)
* feat(#141): add /debug skill — structured hypothesis-driven debugging
Adds a methodology skill that enforces five disciplines:
1. Capture the symptom precisely (exact URL, exact response, exact step)
2. Read the architecture before guessing (map every layer the request
touches, file by file)
3. Form a hypothesis ladder (3–5 candidates, each with an explicit
evidence test that confirms or refutes it)
4. Gather evidence first, fix second
5. Verify the fix against the original symptom evidence (re-run the
same `curl` / browser repro you used in step 4 — unit tests
verify code, not feature, correctness)
Stack appendices (Web, Desktop) carry stack-specific surface-evidence
requirements (step 1), architecture-surface maps (step 2), and
evidence-tests cookbooks (step 4). The methodology body stays portable
across stacks; appendices are where stack-specific knowledge accrues
over time.
Web appendix covers browser routing, framework configs (Next/Nuxt/Vite),
SPA-fallback layers, CDN, origin, the shared API client, backend
handlers, and auth providers. Desktop appendix covers Electron / Tauri
/ native-shell concerns: app entry points, IPC bridges, native modules,
auto-updater, sandbox / entitlements, code signing, crash reports.
Includes "When NOT to use" guidance so the methodology overhead doesn't
sandbag simple bugs (typos, off-by-ones, greenfield exploration).
Motivated by a real OAuth debug session in a managed project where
three sequential fixes chased adjacent symptoms because each was
hypothesis-then-fix without evidence in between. The skill is the
"never do that again" guardrail.
Closes #141
* fix(#141): scrub private project issue numbers from anti-pattern table
Rex review on PR #142 caught that line 155 of the skill's anti-pattern
table still named the originating PRs (#375, #377, #380) from the
private project where the methodology was first exercised. The PR body
and commit message were correctly abstracted earlier, but this in-file
reference slipped through — the leak-protection hook only scans gh
issue/pr writes, not staged file content, so mechanical enforcement
didn't catch it.
Replaced with "Three sequential PRs chasing the same symptom because
each was based on a different guess (no evidence test in between
cycles)" — same pedagogical value, zero attribution.
Refs #141
---------
Co-authored-by: me2resh <ahmed.abdelaliem@gmail.com>
* docs(#143): document split-portfolio mode + add /setup privacy gate (#144)
Adopters on GitHub Free with any private project hit a silent privacy bug
following today's docs: forking apexyard makes a public fork that you cannot
later flip to private (GitHub policy), and committing `apexyard.projects.yaml`
+ `projects/<name>/` to the fork publishes private project names + handover
findings on a public GitHub repo.
This PR documents the supported workaround — split-portfolio mode — and
adds an upfront privacy gate to the /setup skill so new adopters never
hit the trip-wire silently.
docs/multi-project.md:
- New "Two setup modes — pick the one that matches your privacy needs"
section before TL;DR, with a side-by-side table and the explicit
trip-wire callout.
- Existing TL;DR retitled "TL;DR — single-fork mode (default)" with a
one-line pointer to the split-portfolio section.
- New "Split-portfolio mode — public framework + private portfolio"
section between the existing setup steps and the directory-layout
section. Includes:
- The two-repo layout (~/ops/apexyard public + ~/ops/portfolio private)
- 7-step setup walkthrough with copy-pasteable commands
- Daily workflow + upstream sync notes (both unchanged)
- Trade-offs (two repos to maintain, two clones per machine, one
upstream-sync conflict path on `projects/README.md`)
- "Migrating from single-fork to split-portfolio" recovery flow with
the explicit warning that GitHub Issue / PR edit history survives a
force-push and must be redacted separately
.claude/skills/setup/SKILL.md:
- New Step 2a: privacy gate — asks "are any projects private?" before
proposing the config. Branches on the answer:
- All public → single-fork mode
- GitHub Pro / Team / Enterprise → single-fork mode (private
forks of public repos
are supported on those
plans)
- Any private + GitHub Free → split-portfolio mode
- New Step 2b: walks through the split-portfolio setup interactively
(private repo create, sibling clone, gitignore + symlink) when the
privacy gate triggers.
- Detection: `test -L apexyard.projects.yaml` short-circuits Step 2b
for adopters already in split mode.
- Explicit "do NOT auto-migrate" rule for adopters already in single-fork
mode with private names already pushed — that path is destructive
(force-push history rewrite + redact issue/PR bodies + delete backup
branch) and warrants a deliberate, eyes-open run, not a /setup side
effect.
Out of scope for this PR (tracked separately on #143):
- `portfolio:` config block in `onboarding.yaml` schema
- Skill audit + refactor to honour configured `registry` / `projects_dir`
/ `ideas_backlog` paths instead of hardcoded fork-relative paths
- `/split-portfolio` migration helper skill that automates the recovery
flow currently documented manually
This is the docs-and-setup-question minimum-viable starter — the
framework code refactor is mechanical and lands as a follow-up.
Refs #143
Co-authored-by: me2resh <ahmed.abdelaliem@gmail.com>
* feat(#145): portfolio config + self-healing + /split-portfolio helper (#147)
* feat(me2resh/apexyard#145): portfolio config block + self-healing + /split-portfolio helper
Closes the framework primitive deferred from me2resh/apexyard#144. Adds
first-class config-driven path resolution for the portfolio registry,
projects dir, and ideas backlog, with self-healing surfacing of broken
config at session start, plus a new /split-portfolio skill that automates
the destructive recovery flow.
Schema, helper, and hook:
- .claude/project-config.defaults.json: new portfolio: block
(registry, projects_dir, ideas_backlog) with defaults matching
today's single-fork layout
- .claude/hooks/_lib-portfolio-paths.sh: new sourceable helper exposing
portfolio_registry, portfolio_projects_dir, portfolio_ideas_backlog,
portfolio_validate, portfolio_clear_cache. Resolves relative paths
against the ops-fork root.
- .claude/hooks/check-portfolio-config.sh: new SessionStart hook —
silent on OK, one-line banner on broken config, never blocks session
- .claude/hooks/tests/test_portfolio_paths.sh: 13 cases covering
defaults, absolute/relative overrides, validate states, cache clear
Skill audit (18 SKILL.md files):
- Adds Path resolution callout pointing at the helper
- handover bash blocks now source helper and use $(portfolio_registry)
instead of literal apexyard.projects.yaml
- setup Step 2b now writes the portfolio: config block (recommended)
and validates via portfolio_validate before declaring success;
symlink approach kept as legacy fallback
New skill (.claude/skills/split-portfolio/SKILL.md):
- 10-step migration with explicit operator-confirmation gates at each
destructive step (force-push, body redaction, branch deletion)
- --verify mode: read-only state report (mode, paths, validate, drift)
- --dry-run mode: prints commands without executing
- Pre-flight refusals: already-private fork, paid GitHub plan, dirty
working tree, already-migrated state
- Step 9 writes the portfolio: config block (not symlinks) — symlink
fallback documented for adopters on older framework versions
- Step 9 surfaces the GitHub timeline-API survival caveat verbatim
- Idempotent re-runs: detects partial-migration state and resumes
Docs (docs/multi-project.md):
- Layout section describes both modes (config-block recommended,
symlink legacy) with self-healing notes
- Setup steps split into config-block mode and legacy symlink mode
- Migration section now points at /split-portfolio skill; manual
recipe preserved as fallback
AgDR (docs/agdr/AgDR-0010-portfolio-config-and-self-healing.md):
- Full Y-statement, options, decision, consequences, future phases
- Schema decision rationale: project-config.json over onboarding.yaml
because runtime path resolution belongs in project-config
Closes me2resh/apexyard#145
Refs me2resh/apexyard#146 (delivered same PR; closed manually post-merge
per the single-Closes-keyword rule in validate-pr-create.sh)
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* fix(me2resh/apexyard#145): markdownlint MD031 — blank lines around fences
CI's markdownlint-cli2 (v0.34.0) flagged the JSON + bash fenced code
blocks I added in setup/SKILL.md Step 2b without surrounding blank
lines. Added the required blanks. No content change.
Refs me2resh/apexyard#147
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
---------
Co-authored-by: me2resh <ahmed.abdelaliem@gmail.com>
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* docs(me2resh/apexyard#148): correct privacy-gate wording — adopter action, not framework auto-publish (#149)
The privacy-gate wording introduced in PR #144 (and unchanged in PR #147)
attributed the publication to the framework rather than the adopter:
"the standard fork-and-commit setup will silently publish your private
project names on a public GitHub repo"
That's factually wrong. ApexYard never pushes anything without explicit
operator approval — the publication only happens when the adopter
themselves runs git push. The "silently publish" framing read as if the
framework auto-publishes, which is misleading and undermines trust in
the rest of the framework's safety claims.
Two prose-only edits, no code, no behavior change:
- .claude/skills/setup/SKILL.md Step 2a — replaced "will silently
publish ..." with adopter-action language ("you might accidentally
publish ... a stray git push after registering them — I won't push
without your approval, but the risk is on the adopter once the data
is committed locally")
- docs/multi-project.md trip-wire callout — replaced "silently publish
their portfolio names the moment they push" with "risk accidentally
publishing their portfolio names with a stray push (the framework
itself never pushes without operator approval, but once the registry
is committed locally the next push exposes it)"
Verified: `grep -r "silently publish" .claude/skills/ docs/` returns no
hits.
Closes me2resh/apexyard#148
Co-authored-by: me2resh <ahmed.abdelaliem@gmail.com>
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* feat(#150): bootstrap-skill exemption + Bash-write coverage (#152)
Closes the legitimate-bypass case (me2resh/apexyard#150) and the
illegitimate-bypass case (me2resh/apexyard#151) together so the
ticket-first gate is coherent. Shipping either alone would leave a
window where the framework is internally inconsistent — see AgDR-0011
for the full rationale.
Bootstrap exemption (me2resh/apexyard#150):
- .claude/session/active-bootstrap marker, written by /setup,
/handover, /update, /split-portfolio on entry; cleared on exit
- SessionStart sweep (clear-bootstrap-marker.sh) for stale markers
from interrupted sessions
- require-active-ticket.sh reads the marker and exempts skills on
the configured ticket.bootstrap_skills list
- bootstrap_skills list lives in .claude/project-config.defaults.json
(extendable per fork via .claude/project-config.json)
Bash-write coverage (me2resh/apexyard#151):
- new _lib-detect-bash-write.sh — heuristic detector for output
redirection, tee, sed -i, awk -i inplace, python/node/ruby
embedded interpreters
- require-active-ticket.sh + require-migration-ticket.sh now fire
on Bash in addition to Edit|Write|MultiEdit
- design choice: false-negatives preferred over false-positives
(the matcher errs toward "let through" rather than block legit
read-only commands)
Tests: 32 unit cases on the lib + 12 integration cases on the hook,
including the exact me2resh/apexyard#151 bypass repro from the issue
body.
Closes me2resh/apexyard#150
Will manually close me2resh/apexyard#151 post-merge per the
single-Closes-per-PR rule (precedent: AgDR-0010 / PR #147).
Co-authored-by: me2resh <ahmed.abdelaliem@gmail.com>
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* chore(#153): extend Bash-write matcher beyond first-version coverage (#155)
Closes me2resh/apexyard#153.
Extends `_lib-detect-bash-write.sh` (introduced for me2resh/apexyard#151
in PR #152) with the matcher families flagged by Rex's review of #152.
AgDR-0011 already frames the matcher as a living list extended on
observation; this commit just walks the list.
New matcher families:
- File-moving builtins: `cp`, `mv`, `rm`, `dd`, `install` (anchored at
command-start; `--help`/`--version` and `git rm`/`git mv` excluded)
- Archive / network writes: `tar -x` / `tar --extract`, `curl -o` /
`--output`, `wget -O` / `--output-document`
- Additional embedded interpreters: `perl -e`, `php -r` (keyword-gated
like python/node/ruby); `go run`, `deno run`/`deno script.ts`,
`bun run`/`bun script.ts` (categorical script runners)
- Python helpers: `pathlib.Path().touch()`, `shutil.copy*`,
`shutil.move`, `os.rename` added to the `python -c` and python
heredoc keyword list
- Heredoc variants for `ruby` and `node` (previously only python
heredoc was covered)
Extractor extensions:
- `cp` / `mv`: last positional arg
- `curl -o` / `--output`: file argument
- `wget -O` / `--output-document`: file argument
- `tar -x`, `go run`, `deno`, `bun`, `perl -e`, `php -r`: return empty
(caller applies gate categorically per AgDR-0011)
Test count rose from 32 to 86. Negative-class counterexamples cover
the trickiest false-positive surfaces: `tar -t` listing, `cp --help`,
`rm --version`, `git rm`, `curl` bare URL fetch, `wget` bare URL fetch,
`deno fmt`, `deno test`, `go build`. Existing
`test_require_active_ticket_bash.sh` regression suite still passes 12/12.
Co-authored-by: me2resh <ahmed.abdelaliem@gmail.com>
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* test(#154): mock gh in test sandboxes to remove live-tracker dependency (#156)
- add _lib-mock-gh.sh helper that installs a fake `gh` on the sandbox PATH;
intercepts `gh issue view <N> ... --json ...` and returns synthetic
`{"number":N,"state":"OPEN"}` (overridable per-num via mock_gh_set_state)
- wire the shim into test_single_closes_per_pr.sh and
test_validate_pr_required_sections.sh so the validator's CLOSED-issue
refusal no longer breaks the suite when upstream issues are closed
- both files previously failed every case (0/13 and 0/8) because their PR
titles reference #114 / #113, which are now CLOSED upstream
- post-fix: 13/13 and 8/8; full suite remains green
Closes me2resh/apexyard#154
Co-authored-by: me2resh <ahmed.abdelaliem@gmail.com>
* feat(#132): structured CEO marker + same-turn merge in /approve-merge (#158)
* feat(#132): structured CEO marker + same-turn merge in /approve-merge
Closes me2resh/apexyard#132 (drop the "stop before merge" rule) and
me2resh/apexyard#48 (harden CEO marker against self-approval bypass)
together. The two threads compose — see AgDR-0012 for the full
rationale.
Streamline (#132):
- /approve-merge now runs `gh pr merge --squash --delete-branch`
in the same turn as the marker write, by default
- --no-merge opt-out preserves the deferred-merge case
- The discrete approval moment is the SKILL INVOCATION, not a
follow-up "now do the merge" message
Harden (#48):
- CEO marker is now a structured key/value file with required fields:
sha=<HEAD>
approved_by=user
skill_version=2
Validated by block-unreviewed-merge.sh; bare-SHA legacy markers
rejected with a clear "stale format" error pointing at /approve-merge
- The model's bare `echo SHA > <pr>-ceo.approved` bypass is now
mechanically rejected. Forging the structured fields requires a
deliberate, visible rule violation rather than a one-line accident
- Optional audit fields (approved_at, approval_summary) capture the
"what did the user say when they approved" trail
- Rex marker stays bare-SHA — different threat model (automated
reviewer, not human authorization moment)
pr-workflow.md reframed: "the load-bearing rule is explicit per-PR
approval, not two user messages." The merge is a deterministic
consequence of the approval invocation.
Tests: 12 cases on the hardened hook covering the new format end-to-end
(valid v2, missing rex/ceo, bare-SHA legacy rejected, missing
approved_by, wrong approved_by, skill_version=1, sha mismatch,
non-merge no-op, gh-api shape gated). Full suite: 205/205 across 13
test files.
Will manually close me2resh/apexyard#48 post-merge per the
single-Closes-per-PR rule (precedent: PR #152 / AgDR-0011).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* chore(#132): redact private project reference from AgDR-0012
Abstracted two references to a registered private project that named
the project's owner/repo. The leak-protection hook caught one in the
PR body; this fixup removes the matching references from the
AgDR-0012 file content (which would otherwise have shipped the names
to me2resh/apexyard public repo via the merge).
The pre-existing reference at .claude/rules/pr-workflow.md:130
(documenting #47) is untouched — it predates this PR and is already
on the public repo's history.
Refs me2resh/apexyard#132.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* chore(#132): markdownlint blanks-around-fences + typo fix
Two small fixups against red CI / Rex feedback:
- AgDR-0012 line 63: fenced code block now has a blank line before it
(MD031). markdownlint-cli2 0.13.0 was rejecting the indented fence
inside the bullet because the fence's preceding line was the bullet
text (no blank).
- approve-merge SKILL.md line 172: typo `deferes` → `defers` (Rex flag
on PR #158).
Refs me2resh/apexyard#132.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
---------
Co-authored-by: me2resh <ahmed.abdelaliem@gmail.com>
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* chore(#157): remove voice-prompts feature + correct hook/skill counts (#161)
* chore(#157): remove voice-prompts-on-pause feature + correct hook/skill counts
Closes me2resh/apexyard#157 (sunset the voice-prompts feature) and
me2resh/apexyard#77 (hook count off-by-one in CHANGELOG / CLAUDE.md)
in one bundled PR. AgDR-0013 supersedes AgDR-0009 with the full
rationale; both AgDRs are preserved (decision records are append-only
history).
Removed (#157):
- .claude/hooks/voice-prompt-on-pause.sh
- .claude/hooks/tests/test_voice_prompt_on_pause.sh
- Stop matcher block in .claude/settings.json (became empty after
voice removal)
- voice_prompts block in .claude/project-config.defaults.json
- "## Voice prompts" section in docs/project-config.md
- voice_prompts mention in AgDR-0010 line 32 (replaced with
leak_protection / ticket as still-current example config blocks)
Preserved:
- docs/agdr/AgDR-0009-voice-prompts-on-pause.md — historical record;
new "Superseded by: AgDR-0013" header at the top
- AgDR-0010 line 115 reference to AgDR-0009 — still accurate as a
historical pattern reference
Counts corrected (#77):
- CHANGELOG.md v0.3.0 stats: "17 hooks" → "18 hooks" (historical
fix — at v0.3.0 there were actually 18 hooks)
- CLAUDE.md table line: "18 shell scripts" → "24 shell scripts"
(current count after this removal)
- CLAUDE.md table line: "35 slash commands" → "39 slash commands"
- CLAUDE.md "Available skills (34)" → "Available skills (39)"
- CLAUDE.md quick-reference "Skills (35 slash commands)" →
"(39 slash commands)"
Why bundled: #77's correct count depends on whether voice is still in
the framework. Shipping #77 before #157 would write a number that's
wrong by one again the moment #157 lands. Same shape as previous
bundles (PR #152 / AgDR-0011, PR #158 / AgDR-0012).
Why no adopter-facing changelog mention of the voice removal: the
feature never reached a tagged release on main. v1.1.0 didn't have
it; v1.2.0 won't have it. From the adopter's perspective there's
nothing to retire. AgDR-0013 captures the framework's internal record
for future contributors. See AgDR-0013 § "No adopter-facing changelog
mention".
Tests: full hook test suite green (196 cases across 12 files —
test_voice_prompt_on_pause.sh removed). No regressions.
Will manually close me2resh/apexyard#77 post-merge per the
single-Closes-per-PR rule (precedent: PRs #152, #158).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* chore(#157): unwire voice from settings + configs + docs + AgDR-0013
Continuation of d78eb08 (the file deletions). Squash-merge will
collapse both into one PR commit. This commit captures:
- .claude/settings.json — Stop matcher block removed (was the only
hook in it; entire matcher gone)
- .claude/project-config.defaults.json — voice_prompts block + its
_comment removed
- docs/project-config.md — "## Voice prompts" section removed
- docs/agdr/AgDR-0009-voice-prompts-on-pause.md — "Superseded by"
header added at the top, content otherwise preserved as history
- docs/agdr/AgDR-0010-portfolio-config-and-self-healing.md — line 32
example reference swapped from voice_prompts to
leak_protection / ticket (still-current config blocks)
- docs/agdr/AgDR-0013-sunset-voice-prompts.md — new supersession AgDR
- CLAUDE.md — hook count 18 → 24, skill count 35 → 39 (three
occurrences each, all aligned to current reality)
- CHANGELOG.md v0.3.0 stats — "17 hooks" → "18 hooks" historical fix
(#77 acceptance criterion 1)
Refs me2resh/apexyard#157 + me2resh/apexyard#77.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* chore(#157): markdownlint MD028 + resolve stale AgDR-numbering ref
Three small fixups against Rex CHANGES-REQUESTED on PR #161:
- AgDR-0009 line 3: promote "Superseded by:" header out of a
blockquote. The original "I decided ..." canonical blockquote at
line 5 was being merged with the new supersession blockquote
(markdownlint MD028 — "no blanks inside blockquote").
- AgDR-0013 line 3: same shape — "Supersedes:" header now a plain
bold paragraph, canonical "I decided ..." blockquote untouched.
- approve-merge SKILL.md line ~187: stale conditional reference
"AgDR-0012 (or 0013 — depends on whether voice-removal lands
first)" — order is now resolved (12 = approve-merge bundle, 13 =
voice removal). Drop the parenthetical.
Refs me2resh/apexyard#157 + me2resh/apexyard#77.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
---------
Co-authored-by: me2resh <ahmed.abdelaliem@gmail.com>
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* feat(#160): multi-tab terminal demo on the landing site (#162)
Landing-site `site/index.html` terminal demo previously played one
canonical flow ("one ticket, start to finish") on autoplay. With the
v1.2.0 skill surface expansion (4 new skills, 8+ new hooks), one flow
no longer represents the framework's breadth.
Adds tabs to the terminal chrome — four flows visitors can either let
auto-cycle or click directly:
1. one ticket — existing flow, unchanged content
2. /handover — adopt an external repo into the portfolio
3. /setup — first-run framework bootstrap on a fresh fork
4. /fan-out — spawn 3 parallel agents on independent tickets
Auto-advance: on completion of the active tab's script, the demo
pauses ~1.8s then advances to the next tab. Loops at the end. User
can interrupt by clicking any tab or hitting Replay.
Implementation:
- HTML chrome — single title span replaced with a tablist of 4 button
tabs. ARIA `role="tablist"` / `role="tab"` / `aria-selected` so
keyboard + screen-reader users get the same semantics as sighted
ones.
- CSS — new `.shell-demo__tabs` + `.shell-demo__tab` with an accent
underline on the active tab. Tabs scroll horizontally on narrow
viewports (mobile responsive).
- JS — refactored the existing IIFE from one `script` array to an
array of four. Added `setActiveTab()` for ARIA state, `play(idx)`
takes a tab index, end-of-script auto-advances to `(idx + 1) % N`
unless the user clicked away during the pause. Adds a new `cmd`
type alongside `you` for slash-command invocations (renders with
the same `>` prompt prefix). prefers-reduced-motion still bails
early and leaves the static seed visible.
- Static seed (the non-JS fallback) still shows tab 0's content, so
reduced-motion / no-JS visitors see the one-ticket flow as before.
Hero metrics also corrected to current reality (#77 / PR #161 covers
CLAUDE.md and CHANGELOG.md; this PR catches the same numbers in the
landing site):
Skills 32 → 39
Hooks 18 → 24
The tabs ship in v1.2.0 alongside the framework changes that make
the new flows worth showcasing.
Refs me2resh/apexyard#160 (release v1.2.0 + landing-site refresh).
Co-authored-by: me2resh <ahmed.abdelaliem@gmail.com>
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* chore(#163): default the split-portfolio sibling repo name to <fork>-portfolio (#164)
Closes me2resh/apexyard#163.
The split-portfolio mode docs and skills previously suggested
`your-org/ops` as the default name for the private sibling repo, and
`portfolio/` as the local clone directory. Both too generic — adopters
running multiple ops setups end up with `your-org/ops` collisions, and
a bare `portfolio/` dir gives no signal about which framework it
belongs to when it sits next to other unrelated `portfolio/` dirs.
`<fork>-portfolio` is now the default — keeps the relationship to the
public fork explicit on disk and on GitHub. If the fork is named
`your-org/apexyard`, the portfolio defaults to
`your-org/apexyard-portfolio`. If the fork was renamed (e.g. `cos`),
the portfolio defaults to `cos-portfolio`. Adopters with custom names
keep working — the `portfolio:` config block resolves whatever path
they configured.
Files updated:
docs/multi-project.md
- Layout diagrams use `apexyard-portfolio/` as the sibling
- Setup walkthrough Step 2 + Step 3 use `your-org/apexyard-portfolio`
and explain the `<fork>-portfolio` pattern
- Config-block + symlink path examples updated to
`../apexyard-portfolio/...`
- Daily workflow + cross-machine clone commands updated
- The two existing `your-org/ops` references that remain are
fork-rename examples (lines 52, 64) — kept as-is, since renaming
the fork to `ops` is still valid (the portfolio would then
default to `ops-portfolio`)
.claude/skills/setup/SKILL.md
- Step 2b's "default suggestion" for the private repo name is now
`your-org/<fork>-portfolio`, computed dynamically from the
fork's repo name via `gh repo view --json name -q .name` so the
suggestion is correct even when the fork was renamed
- Clone command no longer needs a second arg — the repo name IS
the directory name
- Config-block paths updated to `../apexyard-portfolio/...`
.claude/skills/split-portfolio/SKILL.md
- Step 3's suggested-name template is now `<account>/<fork>-portfolio`
with the same dynamic-fork-name resolution
Mechanism unchanged. The `portfolio:` config block in
`.claude/project-config.json` still takes any path; this PR is purely
default-suggestion + example prose.
No tests required (skills are markdown instructions; no automated
coverage today).
Refs `apexyard.projects.yaml.example` uses "ops repo" as a generic
term meaning "the operational management fork" — not a name — kept
as-is.
Co-authored-by: me2resh <ahmed.abdelaliem@gmail.com>
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* feat(#165): skills reference page on the landing site + changelog link (#167)
Closes me2resh/apexyard#165.
Adds a public, browseable index of every apexyard slash command
alongside a one-click changelog link from the homepage nav.
site/skills.html (new):
- Lists all 39 skills currently shipping in .claude/skills/
- Each entry: slash command, argument hint, description (taken
verbatim from the SKILL.md frontmatter so the page matches the
runtime exactly)
- 10 categories: Setup & onboarding, Daily ops, Tickets & ideas,
Specs & decisions, Code review & merge, Architecture & dev tools,
Production-readiness audits, Workflow primitives, Communications,
Deprecated
- Same brutalist-terminal design tokens as the homepage — JetBrains
Mono, paper-cream background, single warning-red accent, sharp
corners. Inlined CSS to keep the static-only no-build-step
convention; design vars duplicated rather than extracted to a
shared file (~18 vars; cheap to keep in sync).
- Mobile responsive — skill grid collapses to single-column under
720px; titlebar nav hides non-CTA items on narrow viewports.
- Reduced-motion friendly (no animation in the first place).
- Internal anchor TOC at the top so the page scans in seconds.
site/index.html (nav addition):
- Added two nav links to the titlebar between "what's in the box"
and the github CTA:
• skills → ./skills.html
• changelog → https://github.com/me2resh/apexyard/releases
- The changelog link points at the GitHub releases page (not the
raw CHANGELOG.md file) so it auto-resolves to the latest tagged
release on each visit. v1.2.0 lands and the link is already there.
No new dependencies, no build step, no JS for the skills page. The
existing site convention (one-html-file-per-route, inlined CSS,
optional progressive-enhancement JS) is preserved.
Refs me2resh/apexyard#160 (release v1.2.0 + landing-site refresh) —
this is the second site-side deliverable for that ticket; the release
tag itself follows once me2resh/apexyard#159 (testing) closes.
Follow-up worth a separate ticket: a small generator script that
walks .claude/skills/*/SKILL.md, parses YAML frontmatter, and emits
the skills.html sections automatically. Out of scope for v1.2.0 —
first version is hand-curated and will need maintenance until that
generator lands.
Co-authored-by: me2resh <ahmed.abdelaliem@gmail.com>
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* chore(#168): accept release/vN.N.N branches + release(...) PR titles (#169)
Closes me2resh/apexyard#168.
The /release skill prescribed `release/vA.B.C` as the source-branch
name and `release: vA.B.C` as the PR title for the dev → main release
PR (per AgDR-0007). Both were rejected by the framework's own
validators:
validate-branch-name.sh required {type}/{TICKET-ID}-{description};
release/v1.2.0 has no ticket-id portion.
validate-pr-create.sh required type(SCOPE): form with `release` not
in pr.title_type_whitelist.
The contradiction surfaced cutting v1.2.0 — the first release under
the dev/main model.
Three small changes:
1. .claude/hooks/validate-branch-name.sh — added an early-out branch
that accepts ^release/vN.N.N(-rcN)?$ as a valid name. Narrow,
intentional exception for the framework's release-cut convention;
release branches don't carry a ticket-id because the release itself
IS the ticket.
2. .claude/project-config.defaults.json — added "release" to
pr.title_type_whitelist so a title like `release(#160): v1.2.0`
passes validate-pr-create.sh's existing regex unchanged.
3. .claude/skills/release/SKILL.md step 4 — corrected the prescribed
PR title to `release(#<release-ticket>): vA.B.C` so future /release
invocations produce a title that satisfies the validators by
construction.
Tested:
bash .claude/hooks/validate-branch-name.sh against:
release/v1.2.0 → 0 (allowed, release-special-case)
release/v1.2.0-rc1 → 0 (allowed, RC variant)
release/v9.9.9 → 0 (allowed)
release/foo → 2 (correctly blocked)
release/v1 → 2 (correctly blocked)
chore/GH-168-fix → 0 (allowed, standard pattern)
feature/GH-1-x → 0 (allowed, standard pattern)
Full hook test suite: 196/196 cases green across 12 test files.
Refs: surfaced 2026-05-04 cutting the first release under AgDR-0007.
Co-authored-by: me2resh <ahmed.abdelaliem@gmail.com>
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* chore(#170): exempt release/vN.N.N from validate-pr-create's branch-id check (#171)
Closes me2resh/apexyard#170.
Completes the work started in #169 (closing #168). #169 added a
release-pattern early-out to validate-branch-name.sh so release/vN.N.N
branches pass the branch-name validator. But validate-pr-create.sh has
its own independent branch-id check at line 273 that #169 didn't
touch — and it still rejects release/v1.2.0 because that name doesn't
contain a ticket-id substring.
This is the same class of contradiction #168 fixed; the fix is the
same shape. Add the same release-pattern early-out to the branch-id
check in validate-pr-create.sh:
- if the branch matches ^release/vN.N.N(-rcN)?$ → exempt (release
branches don't carry ticket-ids; the release itself is the ticket)
- otherwise → require a ticket-id substring as before
#168's acceptance criterion 3 ("validate-pr-create.sh accepts a PR
title `release(#160): v1.2.0` against the `release/v1.2.0` branch")
was checked off based on the title regex alone but didn't catch the
secondary branch-id check living in the same file. Surfaced trying
to open the v1.2.0 release PR.
Tested:
bash .claude/hooks/validate-pr-create.sh against:
release/v1.2.0 → 0 (allowed, exempt)
release/v1.2.0-rc1 → 0 (allowed, RC variant)
chore/GH-1-fix → 0 (allowed, has ticket-id)
release/foo → 2 (correctly blocked)
chore/no-ticket → 2 (correctly blocked)
Refs me2resh/apexyard#168 (the parent bug) + #169 (the partial fix).
Co-authored-by: me2resh <ahmed.abdelaliem@gmail.com>
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* chore(#160): release v1.2.0 — CHANGELOG entry
Adds the v1.2.0 section to CHANGELOG.md ahead of the dev → main
release PR. 25 commits since v1.1.0 (was 26 — one feat removed
post-supersession per AgDR-0013, intentionally unenumerated in the
adopter-facing changelog because the feature never reached a tagged
release).
Highlights:
- Bootstrap-skill exemption + Bash-write coverage (#150 + #151)
- /approve-merge structured marker + same-turn merge (#132 + #48)
- Portfolio config block + /split-portfolio helper (#143 + #145)
- Four new skills: /debug, /validate-idea, /tickets-batch, /fan-out
- Release-cut branch model (#116, AgDR-0007)
- Landing-site multi-tab terminal + skills page + changelog link
(#160 / #165)
Refs me2resh/apexyard#160 (release-and-site-refresh ticket).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
---------
Co-authored-by: me2resh <ahmed.abdelaliem@gmail.com>
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* release(#278): v1.3.0 (#279)
* chore(#109): project-configurable ticket / branch / commit / PR schema (#118)
* chore(#109): project-configurable ticket / branch / commit / PR schema
Lift the prefix / type whitelists hardcoded across skills, hooks, and
CI into a versioned JSON config read through a shared shell library.
Shipped defaults at .claude/project-config.defaults.json; per-fork
overrides at the optional .claude/project-config.json; one reader
(_lib-read-config.sh) that every consumer now uses.
Added:
- .claude/project-config.defaults.json (v1 schema)
- .claude/hooks/_lib-read-config.sh (shared reader)
- docs/project-config.md (schema reference + extension guide)
- docs/agdr/AgDR-0006-project-configurable-ticket-schema.md
Migrated (still pass with no config present via last-resort fallback):
- validate-branch-name.sh → .branch.type_whitelist
- validate-commit-format.sh → .commit.type_whitelist (legacy
`commit_types` top-level key honoured as backward-compat fallback)
- validate-pr-create.sh → .pr.title_type_whitelist
- /feature, /task, /bug skills reference the config in their Rules
sections; none hardcodes the list any more
Unlocks subsequent config-readers for #107 / #110 / #111 / #112 /
#113 / #114 / #115 — each extends the schema under its own subtree
without further changes to the loader.
https://github.com/me2resh/apexyard/issues/109
* fix(#109): satisfy markdownlint MD032 and MD060 on new docs
Auto-fix MD032 (blank lines around lists) in AgDR-0006 and format
table-separator rows with surrounding spaces (MD060) in both new
doc files. Content unchanged; CI green.
---------
Co-authored-by: me2resh <ahmed.abdelaliem@gmail.com>
* chore(#110): add block-private-refs-in-public-repos.sh hook (#119)
Adds a new PreToolUse hook that blocks gh issue/PR/comment creation and
gh api .../issues|/pulls calls targeting a public framework repo
(default: me2resh/apexyard + whatever `upstream` resolves to) when the
title or body references any registered private project from
apexyard.projects.yaml (by name, repo slug, owner/repo#N ticket ref, or
workspace path).
The hook is a sibling to check-secrets.sh — both scan outgoing content
for identifiers that should never leave the local environment. Skip
marker `<!-- private-refs: allow -->` in the body lets a deliberate
reference through with a visible warning.
Files touched:
- .claude/hooks/block-private-refs-in-public-repos.sh (new)
- .claude/hooks/tests/test_block_private_refs.sh (new)
- .claude/rules/leak-protection.md (new)
- .claude/settings.json (wire PreToolUse matchers for the 5 gh shapes)
- docs/rule-audit.md (append section 10 + bump counts)
Refs: https://github.com/me2resh/apexyard/issues/110
Co-authored-by: me2resh <ahmed.abdelaliem@gmail.com>
* chore(#115): add warn-stale-review-markers.sh PostToolUse hook (#120)
Fires after `git push` to surface review markers that have gone stale
because new commits were pushed past an existing Rex / CEO / design
approval. The merge gate already catches this at `gh pr merge` time,
but only then -- this hook closes the gap by flagging it immediately
at push-time so the author isn't surprised at merge.
- `.claude/hooks/warn-stale-review-markers.sh`
- PostToolUse, non-blocking (PostToolUse exit 2 would push noise
into the conversation; this hook is purely informational).
- Resolves the PR HEAD via `gh pr view --json headRefOid` -- same
source-of-truth as the merge-gate hooks post-apexyard#47 / #55.
Falls back to local HEAD with a visible WARN when gh is offline.
- Silent on: no PR for branch, no markers, fresh markers,
failed push (detected via `rejected` / `failed to push` /
`fatal:` / `error:` markers in tool_response.stderr).
- Modes: `warn` (default) prints one stderr line per stale marker;
`delete` opts in to auto-removal via
`.claude/project-config.json` -> `review_markers.on_stale`.
TODO(apexyard#109): switch to the shared project-config reader
once it lands.
- `.claude/settings.json`
- Wires the hook on PostToolUse / Bash / `git push *`.
- `docs/rule-audit.md`
- Adds a row under section 3 (Code review & PR quality) and
bumps the mechanized count 26 -> 27 / total 73 -> 74.
- `.claude/hooks/tests/test_warn_stale_review_markers.sh`
- 8 cases: no PR, no markers, fresh markers, stale rex / ceo /
design (warn), delete mode, failed push. All pass locally.
Co-authored-by: me2resh <ahmed.abdelaliem@gmail.com>
* chore(#111): upgrade pre-push-gate from advisory reminder to blocking check-runner (#121)
* chore(#111): upgrade pre-push-gate from reminder to blocking check-runner
Previously pre-push-gate.sh just printed a checklist of things to run
locally before pushing — it was advisory. The rule it enforces is a
HARD STOP per pr-workflow.md. That asymmetry meant agents routinely
pushed broken work and discovered it only when CI went red.
Replaces the reminder with a blocking runner that reads the list of
shell commands from project config (.pre_push.commands) and executes
them in sequence before a push is allowed through. First non-zero
exit blocks the push with exit 2 and prints the failing command plus
the last 20 lines of its output.
- Config key: .pre_push.commands[] — array of {name, run} objects.
Shipped default is an empty list (hook stays a no-op on repos that
haven't configured their checks yet, including the framework repo
itself until it wires its own CI).
- Emergency bypass: '<!-- pre-push: skip -->' in the HEAD commit
message. Grep-able on purpose so bypasses stay auditable.
- Fail-fast: once a command fails, the rest don't run. Parallel
execution is a follow-up polish.
- 7 test cases in .claude/hooks/tests/test_pre_push_gate.sh — all
pass on the shipped default + a minimal custom config.
Updates docs/rule-audit.md to flip "partial" → "yes" for the
"before git push" rule.
Integrates with the shared config reader landed in #109.
https://github.com/me2resh/apexyard/issues/111
* fix(#111): remove orphaned footnote reference from rule-audit
The previous advisory-mode footnote was superseded by pre-push-111
but its definition was accidentally kept, tripping markdownlint MD053
(unused reference definition). Drop it.
---------
Co-authored-by: me2resh <ahmed.abdelaliem@gmail.com>
* chore(#107): add validate-issue-structure.sh PreToolUse hook (#122)
Mechanically enforces the ticket body schema when an agent files raw
`gh issue create` calls instead of going th…
…#460) The /release-sync skill documents a `sync`-typed shape (branch `sync/...`, commit `sync: ...`, PR title `sync(#N): ...`) but `sync` was absent from all three type whitelists and the hooks' hardcoded fallbacks — so every sync artifact was rejected, forcing the v2.2.0 release sync to retitle everything to `chore`. - Add `sync` to branch.type_whitelist, commit.type_whitelist, and pr.title_type_whitelist in project-config.defaults.json - Align the three hardcoded fallback strings with their config lists (each gains `sync`; commit fallback was also missing `spike`, pr fallback was missing `release`+`spike` — fixed the drift) - Exempt `sync/main-to-dev-after-vN.N.N` branches from the ticket-id requirement (same narrow exception as `release/vN.N.N` — the release being synced is the ticket) - New regression test test_sync_type_whitelisted.sh (10 cases: behavioural branch+commit acceptance + control + static config/fallback assertions) - Note the whitelisting in release-sync SKILL.md Refs #458 Co-authored-by: me2resh <ahmed.abdelaliem@gmail.com>
…pr.sh with greedy awk (#462) The extract_flag_value() function used `sed … "[^"]*" …` which stopped at the first embedded double-quote inside --body, false-blocking any PR whose body contained a `"` before the AgDR reference or skip marker. Replace the three-branch sed form with the same greedy awk extractor already used by block-private-refs-in-public-repos.sh (fixed in #227) and validate-issue-structure.sh. The awk approach matches greedily to the last closing quote and uses a flag-boundary anchor (`[[:space:]]+--[a-zA-Z]` or EOS) to avoid bleeding into the next flag. Add three regression tests covering the ACs from #461: A) AgDR reference after embedded quote → PASS (no false-block) B) Skip marker after embedded quote → PASS with skip warning C) Embedded quote but no AgDR at all → still BLOCKS (true-negative) Sibling hook audit: block-private-refs-in-public-repos.sh and validate-issue-structure.sh both already carry the awk form; validate-pr-create.sh, require-migration-ticket.sh, require-active-ticket.sh, and verify-commit-refs.sh do not own a --body extractor and are unaffected. Refs #461 Co-authored-by: me2resh <ahmed.abdelaliem@gmail.com> Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
* fix(#459): require --merge for sync PRs; auto-detect + guard against --squash - /release-sync SKILL.md: step 7 now prominently states sync PRs MUST use --merge (true merge, two parents), never --squash/--rebase. The merge commit IS the ancestry-closure artefact; squashing it destroys the second parent and defeats the skill's purpose. Rule 5 updated. AgDR-0053 referenced. - /approve-merge SKILL.md: step 6 (new) auto-detects sync-class PRs by head branch prefix (sync/main-to-dev-after-*) or title prefix (sync() and uses --merge automatically. Default for all other PRs remains --squash. Merge report surfaces the strategy used. Step numbering shifted accordingly. - block-unreviewed-merge.sh: sync-PR squash guard added after PR-number extraction. When a merge command includes --squash or --rebase and the PR's head branch starts with sync/main-to-dev-after-, the hook blocks with a clear error explaining the correct --merge path. Falls back gracefully on gh API failure (skips guard, lets other checks proceed). - test_block_unreviewed_merge.sh: three new cases covering the guard: sync+squash → blocked, sync+merge+valid-markers → passes, non-sync+squash+valid-markers → still passes (narrowly scoped). - docs/agdr/AgDR-0053-sync-pr-merge-strategy.md: records the decision between flag (Option A) vs auto-detect (Option B) and the scope of the hook guard (Option D vs E vs F). Includes residual divergence recommendation. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix(#459): close gh-api bypass in sync-PR squash guard Rex blocking finding: the guard's `grep -qE '(--squash|--rebase)'` only matched the `gh pr merge --squash` shape — it missed `gh api .../merge -f merge_method=squash`, the silent-bypass route that motivated #47. A sync PR could still be squash-merged via gh api, re-introducing the squash-divergence the guard exists to prevent. - Extend the detection to also match `merge_method=squash|rebase` - Fix the misleading comment (it claimed "same gh call as the HEAD-SHA lookup" + "fires on both shapes" — it was a separate call and did NOT fire on the gh-api shape) - Use `<owner/repo>` placeholder in the error suggestion instead of hardcoding me2resh/apexyard (correct for fork adopters) - New tests S4 (gh-api merge_method=squash → blocked) + S5 (gh-api merge_method=merge → passes) Refs #459 --------- Co-authored-by: me2resh <ahmed.abdelaliem@gmail.com> Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
…rk (#465) * fix(#464): PR-create hooks resolve PR origin repo, not session ops-fork When the session is pinned to the ops-fork but `gh pr create --repo X` targets a sibling repo, two PreToolUse hooks evaluated the WRONG repo: - require-agdr-for-arch-pr.sh diffed the ops-fork working tree (showing framework paths .claude/migrations/, topologies/, handbooks/domain/) instead of the PR's actual diff, blocking even with a valid AgDR. - validate-pr-create.sh used the ops-fork's `upstream` remote as a ticket- existence fallback for the sibling PR, causing false "ticket not found" blocks when a premium ticket number collided with a closed framework issue. Fix: - Add _lib-pr-repo.sh with `pr_repo_matches_cwd` helper: parses --repo from the command, resolves `git remote get-url origin` for the cwd, compares them. Handles SSH + HTTPS URL forms on macOS (BSD sed-safe patterns). - require-agdr-for-arch-pr.sh: exit 0 early when the PR targets a repo that differs from the current git working tree's origin — the diff would be meaningless from the wrong cwd. - validate-pr-create.sh: suppress the upstream-remote fallback when CMD_REPO is set and the target repo belongs to a different project lineage (matches neither origin nor its upstream). Framework gating preserved: - Framework PRs (--repo = ops-fork origin) still diff the framework tree and block on arch-path changes without an AgDR. - Fork → upstream PRs (#207) still use the upstream fallback when CMD_REPO matches origin or upstream of the current working tree. Tests: test_pr_hooks_cross_repo.sh — 9 cases covering A1-A4 (agdr hook) and B1-B5 (validate hook), including both the fix scenarios and regressions. Refs #464 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix(#464): harden cross-repo guard — WARN on missing lib, B6 allow-path test Finding 1 — silent revert on missing lib: require-agdr-for-arch-pr.sh: when _lib-pr-repo.sh is absent, emit a loud WARN naming the missing lib and that repo-resolution is degraded. The hook now falls through to the diff check visibly rather than silently skipping the guard entirely (which re-opened bug #464 invisibly). validate-pr-create.sh: same shape — the cross-repo guard's else branch (inline fallback) now emits a WARN before proceeding. The guard logic is preserved via the inline fallback, but the degraded state is no longer silent. Finding 2 — test doesn't exercise the new guard allow-path: test_pr_hooks_cross_repo.sh B6: new test where --repo=<fork-origin>, ticket exists only in upstream, and the upstream remote is configured. CMD_REPO_LC == ORIGIN_LC → guard's allow-path fires → upstream fallback permitted → PASS. A deliberate bug in the guard (wrong variable in the comparison) makes B6 FAIL. Verified fails-before/passes-after. Added C1 + C2: assert the WARN is emitted when the lib is missing. Finding 3 (optional, done cheaply): _lib-pr-repo.sh pr_repo_matches_cwd: when git_origin_repo returns empty (no origin remote), emit a WARN before returning 0 (safe default) so the "no origin → treat as same-repo" assumption is visible, not silent. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix(#464): handle --repo=VALUE, -R VALUE, -R=VALUE forms in all three parsers (F1, F2, F3) F1 — all four --repo/-R forms now parsed in all three parsers: - _lib-pr-repo.sh: pr_cmd_target_repo() extended to match --repo VALUE, --repo=VALUE, -R VALUE, and -R=VALUE. The BSD-sed alternation-capture-group approach (^|[[:space:]]) is replaced with the greedy `.*[[:space:]]<FLAG>` form which correctly extracts only the value on macOS sed -E. - validate-pr-create.sh: CMD_REPO extracted via pr_cmd_target_repo from _lib-pr-repo.sh (DRY); inline fallback updated with the same four-form logic for partial-checkout environments. - require-agdr-for-arch-pr.sh: CMD_REPO_PRESENT grep updated to match all four forms via `(--repo[=[:space:]]|-R[=[:space:]])`. New tests: A5/A6/A7 (agdr hook) and B7/B8/B9 (validate hook) confirm the guard fires for each form; all six tests fail when the parser is intentionally broken to only handle --repo VALUE. F2 — C1 in test_pr_hooks_cross_repo.sh refactored to sandbox-copy pattern (same as C2). The previous C1 used mv to remove _lib-pr-repo.sh from $REPO_ROOT/.claude/hooks/ and relied on mv back after the test; a SIGKILL between the two mv calls would permanently remove the lib from the live hooks directory. C1 now copies the hook + its deps into a temp sandbox, removes the lib from the sandbox copy only, and never touches $REPO_ROOT/.claude/. F3 — Two stale comments in C1 ("exits 0") updated to "BLOCK / rc=2" to match the actual expected behavior asserted by the test. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> --------- Co-authored-by: me2resh <ahmed.abdelaliem@gmail.com> Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
…470) The advisory was written to stderr with exit 0 — which Claude Code does NOT inject into the model's context, so the nudge was invisible to the agent (the exact failure the hook exists to prevent). It also fired regardless of whether apexyard-search was installed, nagging adopters without the premium component. - Emit the advisory as hookSpecificOutput.additionalContext JSON on STDOUT (exit 0, non-blocking) so the model actually reads it on the next turn. - Install-gate: only emit when `apexyard-search` is in a resolvable .mcp.json (ops root via the hook's own path, or $APEXYARD_PORTFOLIO_ROOT). Silent fallback to plain grep otherwise. - Detection (grep/find + framework/workspace paths) unchanged. - test_suggest_mcp_search.sh rewritten: asserts additionalContext JSON when gated-on, silence when apexyard-search isn't configured + on non-matches. 11 passed. Example paths genericized (no private project names). Closes #469 Co-authored-by: me2resh <ahmed.abdelaliem@gmail.com>
… (Rex for non-code) (#472) * feat: add Solution Architect — independent design-review role/agent (Rex for non-code) Adds one new role, the Solution Architect (persona Tariq), as a read-only reviewer of technical designs / migration AgDRs / feature specs — the non-code analog of the Code Reviewer (Rex). The Tech Lead authors the design; Tariq reviews it before Build. Authoring and reviewing are deliberately separate. - roles/architecture/solution-architect.md — new 6th department; persona Tariq, isolated-work-class, structured review lens (NFRs, patterns, tech debt, AgDR linkage, risk, trade-offs, traceability, migration safety) - .claude/agents/solution-architect.md — review agent modeled on Rex: read-only (disallow Write/Edit), opus, handbook discovery (public + private custom), HARD STOP submit-review + sign-off marker on APPROVED - /design-review (invoke Tariq) + /approve-architecture (record the marker) - require-architecture-review.sh — Design→Build merge gate (Gate 3b) on design-artifact PRs, both merge shapes; modeled on require-design-review-for-ui.sh - detect-role-trigger.sh fires Tariq on design-artifact edits (additive to the Tech Lead docs/agdr/ trigger — a migration AgDR fires both) - role-triggers.md, workflow-gates.md (Gate 3b), workflows/sdlc.md Phase 2, settings.json wiring, CLAUDE.md + site/* counts (roles 19→20, agents 23→24, hooks 36→37, skills 55→57), AgDR-0054 - Tests: test_require_architecture_review.sh (17), test_detect_role_trigger.sh (+8 Tariq cases, 34 total); shellcheck clean; site-counts green Closes #471 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * fix: markdownlint MD022/MD032 — blank lines around review-lens headings + lists CI markdownlint-cli2 flagged the checklist sections in the Solution Architect agent + /design-review skill: `### Heading` sat directly above a `- [ ]` list with no blank line (MD022 blanks-around-headings + MD032 blanks-around-lists). Add the required blank line after each heading. No content change. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> --------- Co-authored-by: me2resh <ahmed.abdelaliem@gmail.com> Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…y-verified audit (#474) Adds a third, opt-in mode to /launch-check. The 10 dimensions are independent and read-only — the textbook fan-out shape — so --workflow authors and runs a Claude Code Workflow that: - evaluates all applicable dimensions concurrently (one agent each, reusing each dimension's existing PASS/WARN/FAIL criteria; non-applicable dims pre-resolved) - adversarially verifies every FAIL/WARN finding as it returns (pipeline, no barrier) — a refuted finding downgrades to PASS (the false-positive cut) - synthesizes the SAME verdict table + four-state vocabulary and persists via the SAME _lib-audit-history.sh (audit_run_persist / audit_render_trend), so trend history and the render-trend.sh chart are continuous across serial↔workflow runs Opt-in by design: a workflow run spawns ~10-20 agents, so the serial path stays the default; no flag → no Workflow invocation. Degrades to serial if the Workflow tool is unavailable. No new skill/hook/role — counts unchanged. Documents the canonical workflow script (phases, dimension + verdict schemas, synthesis + persist) in-skill so each run authors a consistent workflow. AgDR-0055 records the decision and the pattern for other multi-dimension audits. Closes #473 Co-authored-by: me2resh <ahmed.abdelaliem@gmail.com> Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The "use MCP search before grep" rule only reached the main loop (via suggest-mcp-search.sh + feedback memory); spawned sub-agents read managed-project code with grep+Read instead. Confirmed 2026-06-01: the tech-lead sub-agent authored a curios-dog design with zero search_code calls in activity.jsonl. - Add mcp__apexyard-search__search_code + search_docs to the tools/allowed-tools of the 7 code-reading agents: tech-lead, backend/frontend/data/platform-engineer, qa-engineer, security-reviewer (code-reviewer already had search_docs; solution-architect already had both — the reference implementation) - Add a consistent "## MCP-first code search" block to each agent body: prefer search_code/search_docs over grep+Read; fall back to grep only when MCP returns nothing (project not indexed). Preserves graceful degradation. - AgDR-0056 records the decision + why the hook route (extend suggest-mcp-search into sub-agent contexts) was rejected for now (harness-level, can't see sub-agent tool calls). Prompt-level (self-discipline), mirroring how the main-loop rule already works. No agent-count change; site-counts unaffected. Closes #475 Co-authored-by: me2resh <ahmed.abdelaliem@gmail.com> Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…481) - Add step 5.6 "Document selection (checklist)" after the assessment is computed: operator opts in to which artefacts to generate from a numbered catalogue (L2/L1 C4 diagrams, DFD, Feature Inventory, journey, vision, sequence). The handover assessment + harnessability score are always written and never appear in the checklist — they are the core output. - Add a per-doc template-pick sub-step for each selected template-backed doc: list candidates resolved via the existing portfolio_resolve_template (framework templates/** + adopter custom-templates/** override), default to the conventional template so --all/"default" runs stay byte-stable. - Distinguish computed/toggle-only rows (no template choice) from template-backed rows (choose-a-template) explicitly in the prompt. - Default behaviour is the interactive checklist (--interactive); --all is the non-interactive escape that generates the full default set with conventional templates, byte-for-byte the pre-checklist flow. Documented in the Usage section + argument-hint. - Add step 6.1 to generate the in-skill L1 context + sequence stubs when selected; richer docs (DFD/inventory/journey/vision) hand off to their owning skills rather than being reimplemented. - Wire CONTAINER_TEMPLATE/CONTEXT_TEMPLATE/SEQUENCE_TEMPLATE through to the generation steps; widen bootstrap-exemption scope to the new stubs; add Rules 19-20; update Output-location + step 10 summary. - Update the /handover one-liner in CLAUDE.md (counts unchanged). - Record the decision in docs/agdr/AgDR-0057-handover-checklist-selection.md (interactive-with---all-escape default + reuse of template resolution). Closes #480 Co-authored-by: me2resh <ahmed.abdelaliem@gmail.com> Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…ated (#483) Companion to #475 (post-clone reindex hook). Closes the post-UPDATE index-staleness gap: when a workspace/<name>/ clone's code drifts because the agent pulled new commits, nothing reindexes that project, so search_code returns stale/not_indexed results and the agent silently falls back to grep. - New advisory hook suggest-mcp-reindex-after-pull.sh fires on a git HEAD-move (pull / merge / checkout / reset) inside a workspace clone and emits a stderr banner naming the project-scoped reindex call. Exit 0 always — non-blocking, mirrors the clone sibling + check-upstream-drift. - Trigger granularity is the coarse HEAD-move, NOT per-file Edit/Write (per-edit prompts would be far too noisy; a single edited file barely moves the index). AgDR-0058 records this + the debounce tradeoff. - Debounce: silent on "Already up to date." when the output is visible; fires otherwise (over-firing a cheap advisory beats under-firing). - Project detection: cwd-first (.cwd / .tool_input.cwd — the common case, pull run from inside the clone), with -C / cd-prefix / bare-path fallbacks. Skips failed commands and non-workspace pulls. - Scoped to the changed project only — never a portfolio-wide reindex. - Wired as a PostToolUse Bash hook (Bash(git *)); test covers cwd / path / merge / checkout / reset fire + silent on non-workspace / failed / up-to-date / non-git / Edit/Write. Hook count 37 -> 38 across CLAUDE.md and site/* (site-counts test green). Closes #478 Co-authored-by: me2resh <ahmed.abdelaliem@gmail.com> Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…m framework feedback) (#484) Two thin skills that file a bug report / feature request about the apexyard FRAMEWORK itself upstream to me2resh/apexyard — distinct from /bug and /feature, which file into the adopter's own project tracker. Closes the adopter→maintainer feedback loop. - report-apexyard-bug: Given/When/Then + repro + severity + affected-part → [Bug] issue upstream - request-apexyard-feature: problem-first + proposed behaviour + adopter benefit → [Feature] issue upstream - Both file to upstream (git remote upstream, fallback me2resh/apexyard), capture the framework version, confirm-before-file, and use the active-issue-skill marker (#268) - Mandatory leak-scrubbing of private project names before writing to the public repo (per .claude/rules/leak-protection.md + the block-private-refs backstop) - CLAUDE.md skills table + counts 57→59; site/* counts; AgDR-0059 No new hook/role/agent. Closes #482 Co-authored-by: me2resh <ahmed.abdelaliem@gmail.com> Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…ision across repos (#486) Review markers (.claude/session/reviews/) were keyed by bare PR number, causing same-numbered PRs in different managed repos to collide on the same filename. Introduces the <owner>__<repo>__<pr>-<role>.approved scheme (AgDR-0060) with a single source-of-truth helper _lib-review-markers.sh so every reader (4 gate hooks) and writer (4 skills + 2 agents) uses the same qualified path. Adds a cross-repo collision regression test proving distinct, non-colliding markers for same-numbered PRs in different repos. Backward compat: new scheme only, no dual-read fallback. Markers are gitignored ephemeral session state; re-approval cost is one skill/agent invocation per affected session. SHA-match safety backstop unchanged. Closes #485 Co-authored-by: me2resh <ahmed.abdelaliem@gmail.com> Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
… the Shield pipeline) (#488) * ci(#487): release-gated security scan on the framework repo (dog-food the Shield pipeline) - Add .github/workflows/security-scan.yml: gitleaks secrets scan + Semgrep OSS r/bash SAST over .claude/hooks/**; dep-audit and SBOM explicitly marked N/A (no package manifests in this repo); security-gate job gates all jobs; triggers on release/tag/workflow_dispatch only (release-gated) - Refresh golden-paths/pipelines/security.yml: replace token-gated returntocorp/semgrep-action@v1 and unpinned trufflehog@main with free equivalents (gitleaks-action@v2, pip-installed Semgrep OSS, anchore sbom-action@v0); narrative comments align adopters with the self-scan One-time clearance run (local): gitleaks=clean, Semgrep r/bash=4 WARNING (IFS save/restore in _lib-multi-repo-trace.sh — false positives, no exploitable surface), 22 INFO (unquoted expansions in skill scripts). No secrets, no ERROR findings. Closes #487 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * docs(#487): AgDR-0061 — security-scan tooling + cadence decision Records the gitleaks/Semgrep-OSS/release-gated choices (free, no token) + the golden-path template refresh + honest N/A for dep-audit/SBOM. Refs #487 --------- Co-authored-by: me2resh <ahmed.abdelaliem@gmail.com> Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
…ace paths (#490) Extends suggest-mcp-search.sh to also fire on Read, Glob, and Grep PreToolUse events when the target path resolves inside a managed-project workspace clone (workspace/<project>/). Previously an agent could sidestep the nudge by using native read tools instead of Bash; this closes that gap. - Hook tool gate: case-branch on Bash (original path) vs Read|Glob|Grep (new path); any other tool exits 0 immediately. - Path extraction for Read/Glob/Grep: .tool_input.file_path // .tool_input.path covers all three tools in one jq query. - Workspace guard: new branch exits 0 when the path is NOT under workspace/. - Install-gate fully preserved: the apexyard-search .mcp.json check applies to ALL tools — free adopters without the premium MCP see nothing. - settings.json: new Read|Glob|Grep PreToolUse matcher block wired to the same hook wrapper as Bash. - Tests: 23 cases (up from 9) — Read/Glob/Grep fire on workspace paths (gate open), stay silent outside workspace/, stay silent with gate closed (the load-bearing free-adopter case), Write/Edit not triggered. Closes #489 Co-authored-by: me2resh <ahmed.abdelaliem@gmail.com> Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
- JSON-LD softwareVersion 1.3.0 → 2.2.0; dateModified → 2026-05-29 (v2.2.0 release date) - Hero pill apexyard v1.1 → v2.2; hero version link v1.1.0 → v2.2.0 (release-tag href + text) - Releases metric 7 → 12, range (v0.1 → v1.3) → (v0.1 → v2.2) — 12 releases per CHANGELOG - Historical version strings (CHANGELOG entry, migration scripts, AgDRs) left untouched Closes #491 Co-authored-by: me2resh <ahmed.abdelaliem@gmail.com> Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…n dev + tracker shape-only fallback (#505) - #493: /release now bumps site/index.html version strings (JSON-LD softwareVersion + dateModified, hero pill, hero version link text/href, releases-shipped count + range) from the version being cut, as a new step 3.5; test_site_counts.sh asserts site softwareVersion == CHANGELOG top entry so drift fails CI. - #503: report-apexyard-bug + request-apexyard-feature derive the framework version from CHANGELOG.md's top `## [X.Y.Z]` (carried main->dev by /release-sync) instead of `git describe`, which returns a stale tag on dev. - #501: validate-pr-create.sh + verify-commit-refs.sh fall back to shape-only (advisory, exit 0) when a non-gh tracker returns empty; gh existence enforcement unchanged. Closes #493 Closes #503 Closes #501 Co-authored-by: me2resh <ahmed.abdelaliem@gmail.com>
…ew behind the rex marker (#504) * fix(#494): block build-agent self-review — require a real GitHub review behind the rex marker Three-layer defence against build agents fabricating rex.approved markers: 1. Prompt guardrail in each build-class agent file (backend-engineer, frontend-engineer, platform-engineer, product-manager, data-engineer, ui-designer, ux-designer): explicit "You cannot self-review" section that forbids writing review markers or framing output as a Rex verdict. 2. Canonical rule in .claude/rules/pr-workflow.md: new "Build agents cannot self-review" section explaining the structural reason (sub-agents cannot nest Agent), the rule, and the two mechanical backstops. 3. Mechanical gate in block-unreviewed-merge.sh: in addition to SHA-matching the *-rex.approved file, now calls `gh pr view --json reviews` and requires at least one posted GitHub review at the PR HEAD SHA. A fabricated local file with no corresponding GitHub review is rejected. Accepts any review state (APPROVED, COMMENTED, CHANGES_REQUESTED) — Rex posts COMMENT-type on own-PR because GitHub blocks self-approval. Graceful-degrades to SHA-only with a WARN when gh is unavailable (mirrors #55 pattern). Also adds warn-review-marker-write.sh: advisory hook (exit 0 always) wired to PreToolUse on Write + Bash that fires when a build agent targets a review marker path, emitting a banner before the file lands on disk. AgDR-0062 records the options considered, the COMMENT-review edge case, and the gh-unavailable graceful-degrade rationale. Tests: 33 pass (8 new, 25 pre-existing). shellcheck clean (SC1091 info-only on dynamic source paths — pre-existing). Closes #494 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * fix(#494): require independent reviewer — author cannot satisfy own review gate Block self-review bypass: a build sub-agent posting its own COMMENTED review at HEAD (GitHub only blocks self-*approval*, not self-*comment*) could previously write the rex.approved marker and pass the gate. Fix adds an author-independence check — the real-GitHub-review gate now requires at least one review at HEAD whose author.login differs from the PR author's login. Changes: - block-unreviewed-merge.sh: fetch PR author via `gh pr view --json author`; filter reviews to `.author.login != <pr_author>` before counting; update BLOCKED message to name the author-independence requirement - test_block_unreviewed_merge.sh: add `.author.login` to all review shims; fix G1 so review author ≠ PR author; update G2/G3 expected-stderr regex; add G5 (self-review only → BLOCK); add G6 (independent + self-review → PASS) - AgDR-0062: state author-independence as checked property; clarify COMMENT-type edge case requires independent author; name deliberate-bypass risk in graceful-degrade section; fix artifact self-cite (#495 → #504) All 35 tests pass. shellcheck clean at warning level. Refs #494 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix(#494): re-scope to layers 1+2 only — defer mechanical gate per AgDR-0062 Decision changed: drop the independent-review check from block-unreviewed-merge.sh entirely. In a single-maintainer / single-GitHub-account setup Rex posts reviews from the PR author's own account, so an author-independence check is unsatisfiable and would block every merge. What ships: - Layer 1: "You cannot self-review" guardrail in all 7 build-class agent files (already committed in earlier commits on this branch — unchanged) - Layer 2: warn-review-marker-write.sh advisory hook + settings.json wiring (already committed — unchanged) - W1-W4 warn-hook tests added to test_block_unreviewed_merge.sh What is reverted to upstream/dev baseline: - block-unreviewed-merge.sh — no diff vs upstream/dev - G1-G4 real-GitHub-review gate tests — removed (not applicable without the gate) AgDR-0062 updated: decision now records layers 1+2 as shipped, mechanical gate deferred as opt-in for hands-off / multi-account setups. Residual risk documented. Closes #494 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * fix: correct warn-hook banner — no mechanical gate claim (deferred per AgDR-0062) The warn hook's comment + runtime banner still claimed block-unreviewed-merge.sh requires a posted GitHub review at HEAD — false after the gate was reverted. Reworded to point at the human CEO nod + orchestrator review as the real safety, and cite AgDR-0062 for the deferred opt-in gate. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * fix(#494): fix MD032 blank-line violations and hook-count drift (CI failures) - Add blank line after each `**MUST NOT:**` / `**MUST:**` / `**DO:**` heading in 7 build-class agent files and pr-workflow.md — satisfies MD032/blanks-around-lists (markdownlint v0.34.0 as run by CI) - Add blank lines around lists in AgDR-0062 at the four locations flagged by the markdown-lint CI job - Bump hook count 38 → 39 in site/architecture.html, site/index.md.gen, site/architecture.md.gen, site/llms.txt (×2), site/llms-full.txt (×2), and site/skill.md — reflects the warn-review-marker-write.sh hook added by this PR; site-counts drift test now GREEN Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> --------- Co-authored-by: me2resh <ahmed.abdelaliem@gmail.com> Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…pre-push hook (#507) - Populate .claude/project-config.json with pre_push.commands mirroring the locally-runnable CI jobs: markdownlint (via npx markdownlint-cli2), shellcheck over .claude/hooks/*.sh at warning severity, site-counts drift detection, and the subpack extraction smoke test. Link-check (lychee) excluded — network- flaky and unsuitable for pre-push latency. - Add .githooks/pre-push (terminal-push companion): delegates to bin/run-pre-push-checks.sh so the same check set protects both Claude-driven and terminal git pushes. Consistent skip-marker escape hatch. - Add bin/run-pre-push-checks.sh as the shared implementation: runs all four checks, surfaces INFO: lines for missing-tool graceful degrade, and prints a BLOCKED message with the skip-marker instructions on failure. - Disable MD049 and MD060 in .markdownlint.json — both rules were added in markdownlint v0.40.0 (shipped by markdownlint-cli2 v0.22.x) and the existing repo files violate them pervasively. Consistent with the existing permissive stance (MD013, MD033, MD034, etc. already disabled). - Document the one-line core.hooksPath opt-in and the full check table in docs/getting-started.md § "Terminal push hook". Closes #506 Co-authored-by: me2resh <ahmed.abdelaliem@gmail.com>
- Add the [2.3.0] CHANGELOG entry (premium-scrubbed) - Bump site/index.html version strings 2.2.0 → 2.3.0 + releases metric (12→13, range →v2.3) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
✅ Deploy Preview for apexyard canceled.
|
atlas-apex
left a comment
There was a problem hiding this comment.
Code Review: PR #509
Commit: 81b0ece4e80c3a2d3647663bee8d497acabd960c
Summary
Framework release cut v2.3.0. The release commit touches exactly two files: the ## [2.3.0] CHANGELOG entry (Added/Changed/Fixed; non-breaking) and version-string bumps in site/index.html. Reviewed against the release-PR checklist with premium-leak protection as the hard gate.
Checklist Results
- ✅ Architecture & Design: N/A (release content only)
- ✅ Code Quality: Pass
- ✅ Testing: Pass (gates run, see below)
- ✅ Security: Pass (premium-leak sweep clean — see below)
- ✅ Performance: N/A
- ✅ PR Description & Glossary: Pass (
Closes #508,## Testing,## Glossaryall present) - ✅ Summary Bullet Narrative: Pass
- ✅ Technical Decisions (AgDR):N/A (no decision/design artifact in release diff)
- ✅ Adopter Handbooks: N/A (no language/architecture files touched)
Verification performed
1. Premium-leak sweep (hard requirement) — CLEAN.
- v2.3.0 CHANGELOG section: 0 hits for
mcp/MCP,apexyard-search,apexyard-premium,apexyard-admin,apexyard-pdf,apexyard-deploy,apexyard-playbooks,aws-diagram,run-playbook,playbook,open-core,premium,semantic search,search_docs,search_code,reindex. - site/index.html added lines: 0 hits for the same set.
- Deliberately-omitted PRs #469 / #475 / #478 / #489 (premium MCP) did NOT sneak in — confirmed absent from the v2.3.0 section.
- PR-body matches on "premium"/"MCP" are meta-statements asserting the artifacts are scrubbed ("premium-scrubbed", "no MCP / premium-component references") — they name no premium component, repo, or capability, so they are not leaks.
2. Version consistency — PASS.
softwareVersion=2.3.0= CHANGELOG top## [2.3.0].dateModified=2026-06-04. ✅- Hero pill
apexyard v2.3; version link textv2.3.0+ hrefreleases/tag/v2.3.0. ✅ - Releases metric
13== 13 actual## [entries in CHANGELOG (counted). Range(v0.1 → v2.3). ✅ - No stale
2.2/v2.2in changed site regions (the only2.2in the file is aclamp(2.25rem,…)CSS value — not a version).
3. Non-breaking — PASS. No Breaking section; no breaking/removed/deprecated/action-required language in the v2.3.0 entry. PR body declares MINOR, 6 feats, non-breaking.
4. Gates — RUN.
bash .claude/hooks/tests/test_site_counts.sh→ PASS (drift guard confirms site=2.3.0 matches CHANGELOG top; LLM payload meta within 5%).npx -y markdownlint-cli2 CHANGELOG.md→ 0 errors.
5. Scope — PASS. Release commit 81b0ece changes only CHANGELOG.md + site/index.html (32 insertions, 6 deletions). No code/hook/skill changes in the release commit. (The larger diff vs main is the expected accumulated dev→main delta for a release PR.)
6. PR metadata — PASS. Title release(#508): v2.3.0 (release type whitelisted); body has Closes #508, ## Testing, ## Glossary.
Issues Found
None.
Suggestions
None blocking.
Verdict
APPROVED
🤖 Reviewed by Rex (Code Reviewer Agent)
📌 Reviewed commit: 81b0ece4e80c3a2d3647663bee8d497acabd960c
…sh-divergence 8 past release squash-commits (v1.2.0→v2.2.0 + site hotfix #400) were never synced back into dev, leaving main↔dev diverged on ~50 files. dev is the verified content superset (CHANGELOG complete, GA4/consent present, deletions are dev-intentional), so we keep dev's tree and record main as an ancestor to clear the merge conflict. Real release-sync follows. Refs #508
atlas-apex
left a comment
There was a problem hiding this comment.
Code Review: PR #509 (re-bless) — APPROVED
Commit: 5fabe6e5ab245535885969c6a0e87a796fd506e4
Summary
Re-review after a git merge -s ours upstream/main reconcile was added on top of my prior approval at 81b0ece. The reconcile clears the accumulated squash-divergence (8 past release squash-commits were not dev ancestors) by recording main as a second parent while keeping the release branch's tree exactly — zero content change.
Verification
- ✅ Tree identical to prior approval —
HEAD^{tree}(f1935ef…) ==81b0ece^{tree}(f1935ef…);git diff 81b0ece HEADis empty. The-s oursmerge added no file content. - ✅ main is now an ancestor —
git merge-base --is-ancestor upstream/main HEAD→ true. Conflict genuinely resolved, not papered over. - ✅ Release content holds — CHANGELOG top
## [2.3.0]; sitesoftwareVersion2.3.0 (site/index.html); v2.3.0 CHANGELOG section premium-clean. - ✅ Site premium-clean — re-grep of site/ for mcp/apexyard-search/premium/playbook → 0 matches.
- ✅ test_site_counts.sh → PASS (site version matches CHANGELOG top; counts match actuals).
Verdict
APPROVED — the reconcile changed zero file content, so my prior approval of the release tree at 81b0ece carries forward to 5fabe6e.
🤖 Reviewed by Rex (Code Reviewer Agent)
📌 Reviewed commit: 5fabe6e5ab245535885969c6a0e87a796fd506e4
* chore(#109): project-configurable ticket / branch / commit / PR schema (#118)
* chore(#109): project-configurable ticket / branch / commit / PR schema
Lift the prefix / type whitelists hardcoded across skills, hooks, and
CI into a versioned JSON config read through a shared shell library.
Shipped defaults at .claude/project-config.defaults.json; per-fork
overrides at the optional .claude/project-config.json; one reader
(_lib-read-config.sh) that every consumer now uses.
Added:
- .claude/project-config.defaults.json (v1 schema)
- .claude/hooks/_lib-read-config.sh (shared reader)
- docs/project-config.md (schema reference + extension guide)
- docs/agdr/AgDR-0006-project-configurable-ticket-schema.md
Migrated (still pass with no config present via last-resort fallback):
- validate-branch-name.sh → .branch.type_whitelist
- validate-commit-format.sh → .commit.type_whitelist (legacy
`commit_types` top-level key honoured as backward-compat fallback)
- validate-pr-create.sh → .pr.title_type_whitelist
- /feature, /task, /bug skills reference the config in their Rules
sections; none hardcodes the list any more
Unlocks subsequent config-readers for #107 / #110 / #111 / #112 /
#113 / #114 / #115 — each extends the schema under its own subtree
without further changes to the loader.
https://github.com/me2resh/apexyard/issues/109
* fix(#109): satisfy markdownlint MD032 and MD060 on new docs
Auto-fix MD032 (blank lines around lists) in AgDR-0006 and format
table-separator rows with surrounding spaces (MD060) in both new
doc files. Content unchanged; CI green.
---------
Co-authored-by: me2resh <ahmed.abdelaliem@gmail.com>
* chore(#110): add block-private-refs-in-public-repos.sh hook (#119)
Adds a new PreToolUse hook that blocks gh issue/PR/comment creation and
gh api .../issues|/pulls calls targeting a public framework repo
(default: me2resh/apexyard + whatever `upstream` resolves to) when the
title or body references any registered private project from
apexyard.projects.yaml (by name, repo slug, owner/repo#N ticket ref, or
workspace path).
The hook is a sibling to check-secrets.sh — both scan outgoing content
for identifiers that should never leave the local environment. Skip
marker `<!-- private-refs: allow -->` in the body lets a deliberate
reference through with a visible warning.
Files touched:
- .claude/hooks/block-private-refs-in-public-repos.sh (new)
- .claude/hooks/tests/test_block_private_refs.sh (new)
- .claude/rules/leak-protection.md (new)
- .claude/settings.json (wire PreToolUse matchers for the 5 gh shapes)
- docs/rule-audit.md (append section 10 + bump counts)
Refs: https://github.com/me2resh/apexyard/issues/110
Co-authored-by: me2resh <ahmed.abdelaliem@gmail.com>
* chore(#115): add warn-stale-review-markers.sh PostToolUse hook (#120)
Fires after `git push` to surface review markers that have gone stale
because new commits were pushed past an existing Rex / CEO / design
approval. The merge gate already catches this at `gh pr merge` time,
but only then -- this hook closes the gap by flagging it immediately
at push-time so the author isn't surprised at merge.
- `.claude/hooks/warn-stale-review-markers.sh`
- PostToolUse, non-blocking (PostToolUse exit 2 would push noise
into the conversation; this hook is purely informational).
- Resolves the PR HEAD via `gh pr view --json headRefOid` -- same
source-of-truth as the merge-gate hooks post-apexyard#47 / #55.
Falls back to local HEAD with a visible WARN when gh is offline.
- Silent on: no PR for branch, no markers, fresh markers,
failed push (detected via `rejected` / `failed to push` /
`fatal:` / `error:` markers in tool_response.stderr).
- Modes: `warn` (default) prints one stderr line per stale marker;
`delete` opts in to auto-removal via
`.claude/project-config.json` -> `review_markers.on_stale`.
TODO(apexyard#109): switch to the shared project-config reader
once it lands.
- `.claude/settings.json`
- Wires the hook on PostToolUse / Bash / `git push *`.
- `docs/rule-audit.md`
- Adds a row under section 3 (Code review & PR quality) and
bumps the mechanized count 26 -> 27 / total 73 -> 74.
- `.claude/hooks/tests/test_warn_stale_review_markers.sh`
- 8 cases: no PR, no markers, fresh markers, stale rex / ceo /
design (warn), delete mode, failed push. All pass locally.
Co-authored-by: me2resh <ahmed.abdelaliem@gmail.com>
* chore(#111): upgrade pre-push-gate from advisory reminder to blocking check-runner (#121)
* chore(#111): upgrade pre-push-gate from reminder to blocking check-runner
Previously pre-push-gate.sh just printed a checklist of things to run
locally before pushing — it was advisory. The rule it enforces is a
HARD STOP per pr-workflow.md. That asymmetry meant agents routinely
pushed broken work and discovered it only when CI went red.
Replaces the reminder with a blocking runner that reads the list of
shell commands from project config (.pre_push.commands) and executes
them in sequence before a push is allowed through. First non-zero
exit blocks the push with exit 2 and prints the failing command plus
the last 20 lines of its output.
- Config key: .pre_push.commands[] — array of {name, run} objects.
Shipped default is an empty list (hook stays a no-op on repos that
haven't configured their checks yet, including the framework repo
itself until it wires its own CI).
- Emergency bypass: '<!-- pre-push: skip -->' in the HEAD commit
message. Grep-able on purpose so bypasses stay auditable.
- Fail-fast: once a command fails, the rest don't run. Parallel
execution is a follow-up polish.
- 7 test cases in .claude/hooks/tests/test_pre_push_gate.sh — all
pass on the shipped default + a minimal custom config.
Updates docs/rule-audit.md to flip "partial" → "yes" for the
"before git push" rule.
Integrates with the shared config reader landed in #109.
https://github.com/me2resh/apexyard/issues/111
* fix(#111): remove orphaned footnote reference from rule-audit
The previous advisory-mode footnote was superseded by pre-push-111
but its definition was accidentally kept, tripping markdownlint MD053
(unused reference definition). Drop it.
---------
Co-authored-by: me2resh <ahmed.abdelaliem@gmail.com>
* chore(#107): add validate-issue-structure.sh PreToolUse hook (#122)
Mechanically enforces the ticket body schema when an agent files raw
`gh issue create` calls instead of going through the interactive
/feature, /task, /bug skills. Matches bracketed title prefix
([Feature] / [Chore] / [Bug] / [Docs] / etc.) against
`.ticket.required_sections` in project-config, and blocks (exit 2)
when any required section is missing or empty. Skip marker
`<!-- validate-issue-structure: skip -->` bypasses with a visible
stderr WARN for legitimate off-template tickets (epics, meta-threads).
Changes:
- .claude/hooks/validate-issue-structure.sh — the hook; reads schema
via the shared _lib-read-config.sh, with inlined defaults for bare
checkouts predating the config-schema rollout. Handles
--body / --body-file / -F path.
- .claude/project-config.defaults.json — extends .ticket with
required_sections (Feature/Chore/Refactor/Testing/CI/Docs/Bug) and
skip_marker; other .ticket fields untouched.
- .claude/settings.json — new PreToolUse matcher on Bash(gh issue
create *) alongside the existing suggest-ticket-template.sh and
block-private-refs-in-public-repos.sh hooks.
- .claude/hooks/tests/test_validate_issue_structure.sh — 15 cases
covering pass + fail paths per prefix, empty section detection,
skip marker, unknown prefix, non-gh invocation, --body-file path.
- docs/rule-audit.md — new section 11 row, mechanized count +1.
Upstream ticket: https://github.com/me2resh/apexyard/issues/107
Co-authored-by: me2resh <ahmed.abdelaliem@gmail.com>
* chore(#112): add require-agdr-for-arch-pr.sh PreToolUse hook (#123)
Closes the asymmetry noted in .claude/rules/agdr-decisions.md: every
other HARD STOP in the ruleset (merge approval, ticket-first,
migration-first) is mechanically enforced, but the /decide HARD STOP
was prose-only. The commit-time hook require-agdr-for-arch-changes.sh
catches one architectural change at commit; this new PR-time hook
catches the cumulative diff so reviewers always have a pointer to the
decision record.
- New hook at .claude/hooks/require-agdr-for-arch-pr.sh
- Fires on Bash(gh pr create *)
- Parses --title/--body/--body-file/-F <path>
- Resolves base branch from --base, else upstream/dev, origin/dev,
upstream/main, origin/main, main, master (in that order)
- Computes `git diff <merge-base>..HEAD --name-only`
- Triggers on any changed file matching .agdr_trigger_paths[], OR any
dep-file addition (package.json via jq key-set diff; other
dep files via a commented +/- line-count heuristic — version
bumps match +/- counts and do not fire)
- Blocks (exit 2) with a helpful message naming the triggers and
pointing at /decide if the body has no `AgDR-\d+-[a-z0-9-]+`
reference
- Skip marker `<!-- agdr: not-applicable -->` bypasses with a
visible WARN on stderr
- Silent exit 0 on non-gh commands, empty diffs, unresolvable base
- Wired via .claude/settings.json PreToolUse Bash(gh pr create *)
- Adds two new top-level keys to .claude/project-config.defaults.json:
agdr_trigger_paths (shell globs — domain/, infrastructure/,
migrations/, *.tf, .github/workflows/, etc.)
agdr_trigger_dep_files (literal basenames — package.json,
pyproject.toml, Cargo.toml, go.mod, Gemfile)
Hook has inline fallback defaults kept in sync.
- Adds docs/rule-audit.md entry in the AgDR section; bumps mechanized
count 26 to 27 and total rows 73 to 74.
- Adds .claude/hooks/tests/test_require_agdr_for_arch_pr.sh (7 cases;
all green): path-triggered without AgDR (block), with AgDR (pass),
dep-file added (block), version-only bump (no fire), skip marker
(pass + warn), non-matching diff (pass), non-gh command (no-op).
Closes https://github.com/me2resh/apexyard/issues/112
Co-authored-by: me2resh <ahmed.abdelaliem@gmail.com>
* chore(#113): require Testing section in PR body (config-driven) (#124)
Extends validate-pr-create.sh with a required-sections check that
replaces the hardcoded Glossary-only grep. The list of required H2
headings is project-configurable via `.pr.required_sections[]`.
Shipped default is ["Testing", "Glossary"], matching the canonical PR
description shape in workflows/code-review.md.
- Each entry must appear as `## <Name>` (case-insensitive).
- Empty sections are tolerated at this layer (the issue-structure hook
#107 does stricter empty-content checks for issue bodies; for PR
bodies, empty sections are left to the reviewer's judgement).
- Skip marker `<!-- pr-sections: skip -->` bypasses with a visible
stderr WARN — for trivial PRs (lint-only fixes, version bumps)
where the full template is overkill.
- Reads from project config via the shared _lib-read-config.sh (#109).
Inline fallback matches shipped defaults so bare checkouts predating
#109 keep working.
- 8 test cases cover: all-sections pass, each missing section,
missing-both (both errors printed), skip marker, case-insensitive
headings, H3 rejection.
https://github.com/me2resh/apexyard/issues/113
Co-authored-by: me2resh <ahmed.abdelaliem@gmail.com>
* chore(#114): enforce single Closes-keyword per PR body (#125)
* chore(#114): enforce single Closes-keyword per PR body
Caps distinct auto-closing references (close/closes/closed, fix/fixes/
fixed, resolve/resolves/resolved + N or owner/repo+N) at one per PR
body. Closes the loophole where the title validator limited the title
to one ticket but multiple Closes lines in the body would still auto-
close all of them on merge.
- Scans stripped of fenced code blocks so closing keywords inside a
code sample do not count.
- Distinct counting: the same number referenced twice (e.g. via Fixes
and Closes) counts as one.
- Cross-repo refs (owner/repo+N) count normally.
- Opt-in escape hatch: pr.allow_multiple_closes=true in
project-config disables the check for teams that deliberately batch
rollbacks or dependency bumps.
- Per-PR bypass: a multi-close-approved HTML comment in the body
prints a visible stderr WARN and lets that PR through. Grep-able
trace so bypasses are auditable.
- 10 test cases cover: one close passes, no-keyword passes, two
distinct block, three mixed block, same-number-twice passes, code-
fence-ignored, skip marker, cross-ref without keyword, opt-in
config, cross-repo close.
Reads configuration via the shared _lib-read-config.sh (apexyard+109).
https://github.com/me2resh/apexyard/issues/114
* fix(#114): strip inline backticks and tilde fences from close-count scan
Rex caught a self-reflexive bug in the initial commit: documentation
mentioning closing keywords inside inline backticks (say a PR body
that explains the new hook with examples) counted as real closes, and
a skip marker inside inline backticks silently bypassed the check.
Future PRs that document the feature would trip the same trap.
Fix the code-region stripper to cover:
- Triple-backtick fences (already handled)
- Tilde fences (new)
- Inline-backtick spans (new)
Also run the skip-marker check against the stripped body, so a marker
used purely as documentation no longer activates a real bypass.
Three new test cases pin the behaviour:
- closing keywords in inline backticks are ignored
- skip marker inside inline backticks does NOT bypass
- tilde fences also get stripped
13/13 tests pass.
---------
Co-authored-by: me2resh <ahmed.abdelaliem@gmail.com>
* feat(#108): add /tickets-batch skill for bulk-file flow (#127)
The fast happy path for filing 5–20 structured tickets in one intent
without dropping to raw `gh issue create` (non-conformant) or running
`/feature` 20 times serially (~100 turns of interview).
- .claude/skills/tickets-batch/SKILL.md — new skill spec. Asks
shared-context questions (priority, epic, area-labels, repo) ONCE
for the whole batch, then runs a ≤3-question micro-interview per
ticket (type, one-line purpose, optional clarification when the
inference is low-confidence). Confirms the full batch as a table,
then files each via specific `gh issue create` calls (never a
bulk JSON dump — the validator runs per-issue). Output conforms
to `.ticket.required_sections` by construction. Caps at 20
tickets per invocation.
- CLAUDE.md — added a row for /tickets-batch in the Available
Skills table; bumped the count references from 33 to 34.
Refs https://github.com/me2resh/apexyard/issues/108
Co-authored-by: me2resh <ahmed.abdelaliem@gmail.com>
* feat(#117): add /fan-out skill + parallel-work rule doc (#128)
- Add `.claude/skills/fan-out/SKILL.md` — spawns N parallel Agent calls
in a single assistant message, with per-task agent type, worktree
isolation, and foreground/background mode. Caps at 5 concurrent
agents. Refuses fan-out when tasks share file write targets or have
sequential dependencies. Includes pre-spawn active-ticket safety
check and worktree merge-back flow that pauses on conflict.
- Add `.claude/rules/parallel-work.md` — trigger heuristic for when an
agent should proactively offer fan-out (>= 2 file-independent,
context-independent, individually substantial work items). Pairs
with the skill: rule says when, skill says how.
- Update `CLAUDE.md` — bump rules count to 9, skills count to 34, add
`/fan-out` row to the skills table.
Refs https://github.com/me2resh/apexyard/issues/117
Co-authored-by: me2resh <ahmed.abdelaliem@gmail.com>
* chore(#116): adopt release-cut branch model (dev/main + tags) — framework only (#126)
* chore(#116): adopt release-cut branch model (dev/main + tags)
Formalises the dev/main split that already exists informally — dev is
the daily-work branch where every PR lands, main is release-only,
tagged with semver on each merge. Framework-only: managed projects
under apexyard governance stay trunk-based.
Added:
- AgDR-0007 — decision record (options table covers full git flow vs
trunk-only vs gitflow-lite; chose gitflow-lite)
- /release skill — diff dev against main, propose semver bump from
conventional commits, generate CHANGELOG, open release PR, tag
after merge
- docs/release-process.md — prose runbook for cutting a release
(manual fallback for the skill)
- .git.protected_branches in project-config.defaults.json
(main/master/dev/develop)
Modified:
- block-main-push.sh — now blocks direct pushes/commits to all
configured protected branches (was: hardcoded main/master). Reads
.git.protected_branches via the shared config reader (apexyard#109).
- CLAUDE.md — new section under Git Conventions explaining the
dev/main model + the framework-only scope. Skill table entry for
/release. Skills count bumped to 34.
- docs/multi-project.md — note that upstream/main is release-only
and the dev/main split is framework-only.
Non-consequences (per AgDR-0007):
- No release/* or hotfix/* branches. Hotfixes are normal patches
cut quickly. Revisit if multi-version maintenance becomes a need.
- No automatic on-merge issue closing for dev PRs. The release PR's
body aggregates all Closes references for the batch and triggers
auto-close en masse when it merges to main. Manual close in the
meantime.
- CI workflows trigger on pull_request regardless of base, so
dev-targeting PRs already get the full check matrix — no
workflow file edits needed.
https://github.com/me2resh/apexyard/issues/116
* fix(#116): satisfy markdownlint MD032 + MD060 in 116 docs
Auto-fix added blank lines around lists in AgDR-0007 (MD032) and
spaced the table separators in AgDR-0007 + multi-project.md (MD060).
Content unchanged.
---------
Co-authored-by: me2resh <ahmed.abdelaliem@gmail.com>
* fix(#106): CHANGELOG fallback in drift hook for squash-merged forks (#129)
* fix(#106): CHANGELOG fallback in drift hook for squash-merged forks
The v1.1.0 tag-reachability check (`git tag --merged main`) misfires on
forks that sync via GitHub's default squash-merge: the squash collapses
the upstream-tag commit into a synthetic SHA, the tag stops being
reachable, and the banner keeps firing forever.
Discovered live on the first real-world `/update` flow: ops fork
squash-merged the v1.1.0 sync PR, banner kept saying "v1.1.0 available"
even though the fork was content-caught-up.
This commit adds a CHANGELOG-content fallback that fires only when the
primary tag check fails. If the fork's main has a heading
`## [X.Y.Z]` matching the upstream tag's version, treat the release as
absorbed and stay silent. Tolerant grep (matches the apexyard CHANGELOG
format from v1.1.0 onward, with leading-`v` stripping for tag→heading
conversion).
The merge-commit and rebase paths are unchanged — primary tag check
still works for them, and the fallback never fires when it shouldn't.
Test coverage (5 cases):
- squash-merge fork caught up to v1.1.0 → silent (the fix)
- merge-commit fork caught up to v1.1.0 → silent (regression check)
- fork stopped at v1.0.0 → banner fires
- fork has its own newer tag → silent
- squash-merge but no CHANGELOG on fork → banner fires (no false silence)
Records the strategy update in docs/agdr/AgDR-0008-…md (extends
AgDR-0005's tag-based-drift design).
https://github.com/me2resh/apexyard/issues/106
* fix(#106): satisfy markdownlint MD032/MD060 + shellcheck SC2164
Rex flagged two CI-blocking issues on the original 106 commit:
- AgDR-0008 had three bulleted sub-lists in the Consequences section
without surrounding blank lines (MD032). Added blanks and padded the
one tight-pipe table separator (MD060).
- The 106 test fixture had five subshell `cd "$fk"` calls without
`|| exit 1` (SC2164). Added the guard to all five.
5/5 tests still pass after the fix. No semantic change to the hook
or the test logic.
---------
Co-authored-by: me2resh <ahmed.abdelaliem@gmail.com>
* feat(#130): add /validate-idea skill — lightweight pre-spec gate (#131)
A 10-minute, 5-question check that sits between /idea and /write-spec.
Designed for solo founders running ApexYard — not a heavyweight
methodology like event storming or Wardley mapping.
Five questions, asked one at a time:
1. Who is this specifically for?
2. What do they do today instead?
3. What's the smallest version that proves the value?
4. What would prove this is wrong? (kill criteria)
5. Build, buy, or rent?
Output: a one-page validation doc with a GREEN/YELLOW/RED verdict.
RED auto-updates the IDEA-NNN backlog row to WONTDO.
Integration:
/idea — adds an optional default-no "Validate now?" step after
capture (and after the optional GitHub Issue offer).
/handover — adds a conditional "this looks dormant, validate?"
step at the end of the integration plan, gated on the dormancy
heuristic (last commit > 90d AND zero open PRs AND no recent
issue activity). Healthy projects don't see the prompt.
CLAUDE.md skills count bumped to 35; new skills row added.
https://github.com/me2resh/apexyard/issues/130
Co-authored-by: me2resh <ahmed.abdelaliem@gmail.com>
* feat: configurable voice prompts on assistant pause (AgDR-0009-voice-prompts-on-pause) (#135)
Stop hook that speaks the assistant's question aloud (Jarvis-style)
when it pauses for user input. Initial phase is macOS-only via `say`,
no voice input — user replies via keyboard.
Default OFF. Adopters opt in by overriding `voice_prompts.enabled` to
true in `.claude/project-config.json`.
Files:
- .claude/hooks/voice-prompt-on-pause.sh — Stop hook with config gate,
trigger heuristic (questions-only by default), markdown stripping,
sentence-boundary truncation, fire-and-forget say invocation
- .claude/hooks/tests/test_voice_prompt_on_pause.sh — 9 cases covering
disabled-default, enabled+question, enabled+statement, approved-pattern,
abc-menu, malformed-transcript, no-say-on-PATH, trigger-always,
markdown-stripping
- .claude/project-config.defaults.json — voice_prompts schema block
added (enabled, voice, max_chars, rate_wpm, trigger), default OFF
- .claude/settings.json — new Stop hook entry wired with the standard
ops-root resolver wrapper
- docs/agdr/AgDR-0009-voice-prompts-on-pause.md — design rationale,
options matrix (status quo / macOS say / cloud TTS / ML detection),
consequences, future phases
- docs/project-config.md — new "Voice prompts" section with override
examples and privacy notes
Test mode: hook respects VOICE_PROMPTS_SYNC=1 to run say synchronously
(test runners need this so assertions don't race against orphaned
background processes). Production invocations always run async.
Future phases (out of scope here, AgDR §"Future phases"):
- Phase 2: cross-platform TTS (Linux espeak, Windows SpeechSynthesizer)
- Phase 3: cloud TTS providers (OpenAI, ElevenLabs) — privacy AgDR-worthy
- Phase 4: voice input via Whisper-based STT
- Phase 5: per-message overrides
Refs: https://github.com/me2resh/apexyard/issues/134
Co-authored-by: me2resh <ahmed.abdelaliem@gmail.com>
* feat(#141): add /debug skill — structured hypothesis-driven debugging (#142)
* feat(#141): add /debug skill — structured hypothesis-driven debugging
Adds a methodology skill that enforces five disciplines:
1. Capture the symptom precisely (exact URL, exact response, exact step)
2. Read the architecture before guessing (map every layer the request
touches, file by file)
3. Form a hypothesis ladder (3–5 candidates, each with an explicit
evidence test that confirms or refutes it)
4. Gather evidence first, fix second
5. Verify the fix against the original symptom evidence (re-run the
same `curl` / browser repro you used in step 4 — unit tests
verify code, not feature, correctness)
Stack appendices (Web, Desktop) carry stack-specific surface-evidence
requirements (step 1), architecture-surface maps (step 2), and
evidence-tests cookbooks (step 4). The methodology body stays portable
across stacks; appendices are where stack-specific knowledge accrues
over time.
Web appendix covers browser routing, framework configs (Next/Nuxt/Vite),
SPA-fallback layers, CDN, origin, the shared API client, backend
handlers, and auth providers. Desktop appendix covers Electron / Tauri
/ native-shell concerns: app entry points, IPC bridges, native modules,
auto-updater, sandbox / entitlements, code signing, crash reports.
Includes "When NOT to use" guidance so the methodology overhead doesn't
sandbag simple bugs (typos, off-by-ones, greenfield exploration).
Motivated by a real OAuth debug session in a managed project where
three sequential fixes chased adjacent symptoms because each was
hypothesis-then-fix without evidence in between. The skill is the
"never do that again" guardrail.
Closes #141
* fix(#141): scrub private project issue numbers from anti-pattern table
Rex review on PR #142 caught that line 155 of the skill's anti-pattern
table still named the originating PRs (#375, #377, #380) from the
private project where the methodology was first exercised. The PR body
and commit message were correctly abstracted earlier, but this in-file
reference slipped through — the leak-protection hook only scans gh
issue/pr writes, not staged file content, so mechanical enforcement
didn't catch it.
Replaced with "Three sequential PRs chasing the same symptom because
each was based on a different guess (no evidence test in between
cycles)" — same pedagogical value, zero attribution.
Refs #141
---------
Co-authored-by: me2resh <ahmed.abdelaliem@gmail.com>
* docs(#143): document split-portfolio mode + add /setup privacy gate (#144)
Adopters on GitHub Free with any private project hit a silent privacy bug
following today's docs: forking apexyard makes a public fork that you cannot
later flip to private (GitHub policy), and committing `apexyard.projects.yaml`
+ `projects/<name>/` to the fork publishes private project names + handover
findings on a public GitHub repo.
This PR documents the supported workaround — split-portfolio mode — and
adds an upfront privacy gate to the /setup skill so new adopters never
hit the trip-wire silently.
docs/multi-project.md:
- New "Two setup modes — pick the one that matches your privacy needs"
section before TL;DR, with a side-by-side table and the explicit
trip-wire callout.
- Existing TL;DR retitled "TL;DR — single-fork mode (default)" with a
one-line pointer to the split-portfolio section.
- New "Split-portfolio mode — public framework + private portfolio"
section between the existing setup steps and the directory-layout
section. Includes:
- The two-repo layout (~/ops/apexyard public + ~/ops/portfolio private)
- 7-step setup walkthrough with copy-pasteable commands
- Daily workflow + upstream sync notes (both unchanged)
- Trade-offs (two repos to maintain, two clones per machine, one
upstream-sync conflict path on `projects/README.md`)
- "Migrating from single-fork to split-portfolio" recovery flow with
the explicit warning that GitHub Issue / PR edit history survives a
force-push and must be redacted separately
.claude/skills/setup/SKILL.md:
- New Step 2a: privacy gate — asks "are any projects private?" before
proposing the config. Branches on the answer:
- All public → single-fork mode
- GitHub Pro / Team / Enterprise → single-fork mode (private
forks of public repos
are supported on those
plans)
- Any private + GitHub Free → split-portfolio mode
- New Step 2b: walks through the split-portfolio setup interactively
(private repo create, sibling clone, gitignore + symlink) when the
privacy gate triggers.
- Detection: `test -L apexyard.projects.yaml` short-circuits Step 2b
for adopters already in split mode.
- Explicit "do NOT auto-migrate" rule for adopters already in single-fork
mode with private names already pushed — that path is destructive
(force-push history rewrite + redact issue/PR bodies + delete backup
branch) and warrants a deliberate, eyes-open run, not a /setup side
effect.
Out of scope for this PR (tracked separately on #143):
- `portfolio:` config block in `onboarding.yaml` schema
- Skill audit + refactor to honour configured `registry` / `projects_dir`
/ `ideas_backlog` paths instead of hardcoded fork-relative paths
- `/split-portfolio` migration helper skill that automates the recovery
flow currently documented manually
This is the docs-and-setup-question minimum-viable starter — the
framework code refactor is mechanical and lands as a follow-up.
Refs #143
Co-authored-by: me2resh <ahmed.abdelaliem@gmail.com>
* feat(#145): portfolio config + self-healing + /split-portfolio helper (#147)
* feat(me2resh/apexyard#145): portfolio config block + self-healing + /split-portfolio helper
Closes the framework primitive deferred from me2resh/apexyard#144. Adds
first-class config-driven path resolution for the portfolio registry,
projects dir, and ideas backlog, with self-healing surfacing of broken
config at session start, plus a new /split-portfolio skill that automates
the destructive recovery flow.
Schema, helper, and hook:
- .claude/project-config.defaults.json: new portfolio: block
(registry, projects_dir, ideas_backlog) with defaults matching
today's single-fork layout
- .claude/hooks/_lib-portfolio-paths.sh: new sourceable helper exposing
portfolio_registry, portfolio_projects_dir, portfolio_ideas_backlog,
portfolio_validate, portfolio_clear_cache. Resolves relative paths
against the ops-fork root.
- .claude/hooks/check-portfolio-config.sh: new SessionStart hook —
silent on OK, one-line banner on broken config, never blocks session
- .claude/hooks/tests/test_portfolio_paths.sh: 13 cases covering
defaults, absolute/relative overrides, validate states, cache clear
Skill audit (18 SKILL.md files):
- Adds Path resolution callout pointing at the helper
- handover bash blocks now source helper and use $(portfolio_registry)
instead of literal apexyard.projects.yaml
- setup Step 2b now writes the portfolio: config block (recommended)
and validates via portfolio_validate before declaring success;
symlink approach kept as legacy fallback
New skill (.claude/skills/split-portfolio/SKILL.md):
- 10-step migration with explicit operator-confirmation gates at each
destructive step (force-push, body redaction, branch deletion)
- --verify mode: read-only state report (mode, paths, validate, drift)
- --dry-run mode: prints commands without executing
- Pre-flight refusals: already-private fork, paid GitHub plan, dirty
working tree, already-migrated state
- Step 9 writes the portfolio: config block (not symlinks) — symlink
fallback documented for adopters on older framework versions
- Step 9 surfaces the GitHub timeline-API survival caveat verbatim
- Idempotent re-runs: detects partial-migration state and resumes
Docs (docs/multi-project.md):
- Layout section describes both modes (config-block recommended,
symlink legacy) with self-healing notes
- Setup steps split into config-block mode and legacy symlink mode
- Migration section now points at /split-portfolio skill; manual
recipe preserved as fallback
AgDR (docs/agdr/AgDR-0010-portfolio-config-and-self-healing.md):
- Full Y-statement, options, decision, consequences, future phases
- Schema decision rationale: project-config.json over onboarding.yaml
because runtime path resolution belongs in project-config
Closes me2resh/apexyard#145
Refs me2resh/apexyard#146 (delivered same PR; closed manually post-merge
per the single-Closes-keyword rule in validate-pr-create.sh)
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* fix(me2resh/apexyard#145): markdownlint MD031 — blank lines around fences
CI's markdownlint-cli2 (v0.34.0) flagged the JSON + bash fenced code
blocks I added in setup/SKILL.md Step 2b without surrounding blank
lines. Added the required blanks. No content change.
Refs me2resh/apexyard#147
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
---------
Co-authored-by: me2resh <ahmed.abdelaliem@gmail.com>
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* docs(me2resh/apexyard#148): correct privacy-gate wording — adopter action, not framework auto-publish (#149)
The privacy-gate wording introduced in PR #144 (and unchanged in PR #147)
attributed the publication to the framework rather than the adopter:
"the standard fork-and-commit setup will silently publish your private
project names on a public GitHub repo"
That's factually wrong. ApexYard never pushes anything without explicit
operator approval — the publication only happens when the adopter
themselves runs git push. The "silently publish" framing read as if the
framework auto-publishes, which is misleading and undermines trust in
the rest of the framework's safety claims.
Two prose-only edits, no code, no behavior change:
- .claude/skills/setup/SKILL.md Step 2a — replaced "will silently
publish ..." with adopter-action language ("you might accidentally
publish ... a stray git push after registering them — I won't push
without your approval, but the risk is on the adopter once the data
is committed locally")
- docs/multi-project.md trip-wire callout — replaced "silently publish
their portfolio names the moment they push" with "risk accidentally
publishing their portfolio names with a stray push (the framework
itself never pushes without operator approval, but once the registry
is committed locally the next push exposes it)"
Verified: `grep -r "silently publish" .claude/skills/ docs/` returns no
hits.
Closes me2resh/apexyard#148
Co-authored-by: me2resh <ahmed.abdelaliem@gmail.com>
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* feat(#150): bootstrap-skill exemption + Bash-write coverage (#152)
Closes the legitimate-bypass case (me2resh/apexyard#150) and the
illegitimate-bypass case (me2resh/apexyard#151) together so the
ticket-first gate is coherent. Shipping either alone would leave a
window where the framework is internally inconsistent — see AgDR-0011
for the full rationale.
Bootstrap exemption (me2resh/apexyard#150):
- .claude/session/active-bootstrap marker, written by /setup,
/handover, /update, /split-portfolio on entry; cleared on exit
- SessionStart sweep (clear-bootstrap-marker.sh) for stale markers
from interrupted sessions
- require-active-ticket.sh reads the marker and exempts skills on
the configured ticket.bootstrap_skills list
- bootstrap_skills list lives in .claude/project-config.defaults.json
(extendable per fork via .claude/project-config.json)
Bash-write coverage (me2resh/apexyard#151):
- new _lib-detect-bash-write.sh — heuristic detector for output
redirection, tee, sed -i, awk -i inplace, python/node/ruby
embedded interpreters
- require-active-ticket.sh + require-migration-ticket.sh now fire
on Bash in addition to Edit|Write|MultiEdit
- design choice: false-negatives preferred over false-positives
(the matcher errs toward "let through" rather than block legit
read-only commands)
Tests: 32 unit cases on the lib + 12 integration cases on the hook,
including the exact me2resh/apexyard#151 bypass repro from the issue
body.
Closes me2resh/apexyard#150
Will manually close me2resh/apexyard#151 post-merge per the
single-Closes-per-PR rule (precedent: AgDR-0010 / PR #147).
Co-authored-by: me2resh <ahmed.abdelaliem@gmail.com>
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* chore(#153): extend Bash-write matcher beyond first-version coverage (#155)
Closes me2resh/apexyard#153.
Extends `_lib-detect-bash-write.sh` (introduced for me2resh/apexyard#151
in PR #152) with the matcher families flagged by Rex's review of #152.
AgDR-0011 already frames the matcher as a living list extended on
observation; this commit just walks the list.
New matcher families:
- File-moving builtins: `cp`, `mv`, `rm`, `dd`, `install` (anchored at
command-start; `--help`/`--version` and `git rm`/`git mv` excluded)
- Archive / network writes: `tar -x` / `tar --extract`, `curl -o` /
`--output`, `wget -O` / `--output-document`
- Additional embedded interpreters: `perl -e`, `php -r` (keyword-gated
like python/node/ruby); `go run`, `deno run`/`deno script.ts`,
`bun run`/`bun script.ts` (categorical script runners)
- Python helpers: `pathlib.Path().touch()`, `shutil.copy*`,
`shutil.move`, `os.rename` added to the `python -c` and python
heredoc keyword list
- Heredoc variants for `ruby` and `node` (previously only python
heredoc was covered)
Extractor extensions:
- `cp` / `mv`: last positional arg
- `curl -o` / `--output`: file argument
- `wget -O` / `--output-document`: file argument
- `tar -x`, `go run`, `deno`, `bun`, `perl -e`, `php -r`: return empty
(caller applies gate categorically per AgDR-0011)
Test count rose from 32 to 86. Negative-class counterexamples cover
the trickiest false-positive surfaces: `tar -t` listing, `cp --help`,
`rm --version`, `git rm`, `curl` bare URL fetch, `wget` bare URL fetch,
`deno fmt`, `deno test`, `go build`. Existing
`test_require_active_ticket_bash.sh` regression suite still passes 12/12.
Co-authored-by: me2resh <ahmed.abdelaliem@gmail.com>
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* test(#154): mock gh in test sandboxes to remove live-tracker dependency (#156)
- add _lib-mock-gh.sh helper that installs a fake `gh` on the sandbox PATH;
intercepts `gh issue view <N> ... --json ...` and returns synthetic
`{"number":N,"state":"OPEN"}` (overridable per-num via mock_gh_set_state)
- wire the shim into test_single_closes_per_pr.sh and
test_validate_pr_required_sections.sh so the validator's CLOSED-issue
refusal no longer breaks the suite when upstream issues are closed
- both files previously failed every case (0/13 and 0/8) because their PR
titles reference #114 / #113, which are now CLOSED upstream
- post-fix: 13/13 and 8/8; full suite remains green
Closes me2resh/apexyard#154
Co-authored-by: me2resh <ahmed.abdelaliem@gmail.com>
* feat(#132): structured CEO marker + same-turn merge in /approve-merge (#158)
* feat(#132): structured CEO marker + same-turn merge in /approve-merge
Closes me2resh/apexyard#132 (drop the "stop before merge" rule) and
me2resh/apexyard#48 (harden CEO marker against self-approval bypass)
together. The two threads compose — see AgDR-0012 for the full
rationale.
Streamline (#132):
- /approve-merge now runs `gh pr merge --squash --delete-branch`
in the same turn as the marker write, by default
- --no-merge opt-out preserves the deferred-merge case
- The discrete approval moment is the SKILL INVOCATION, not a
follow-up "now do the merge" message
Harden (#48):
- CEO marker is now a structured key/value file with required fields:
sha=<HEAD>
approved_by=user
skill_version=2
Validated by block-unreviewed-merge.sh; bare-SHA legacy markers
rejected with a clear "stale format" error pointing at /approve-merge
- The model's bare `echo SHA > <pr>-ceo.approved` bypass is now
mechanically rejected. Forging the structured fields requires a
deliberate, visible rule violation rather than a one-line accident
- Optional audit fields (approved_at, approval_summary) capture the
"what did the user say when they approved" trail
- Rex marker stays bare-SHA — different threat model (automated
reviewer, not human authorization moment)
pr-workflow.md reframed: "the load-bearing rule is explicit per-PR
approval, not two user messages." The merge is a deterministic
consequence of the approval invocation.
Tests: 12 cases on the hardened hook covering the new format end-to-end
(valid v2, missing rex/ceo, bare-SHA legacy rejected, missing
approved_by, wrong approved_by, skill_version=1, sha mismatch,
non-merge no-op, gh-api shape gated). Full suite: 205/205 across 13
test files.
Will manually close me2resh/apexyard#48 post-merge per the
single-Closes-per-PR rule (precedent: PR #152 / AgDR-0011).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* chore(#132): redact private project reference from AgDR-0012
Abstracted two references to a registered private project that named
the project's owner/repo. The leak-protection hook caught one in the
PR body; this fixup removes the matching references from the
AgDR-0012 file content (which would otherwise have shipped the names
to me2resh/apexyard public repo via the merge).
The pre-existing reference at .claude/rules/pr-workflow.md:130
(documenting #47) is untouched — it predates this PR and is already
on the public repo's history.
Refs me2resh/apexyard#132.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* chore(#132): markdownlint blanks-around-fences + typo fix
Two small fixups against red CI / Rex feedback:
- AgDR-0012 line 63: fenced code block now has a blank line before it
(MD031). markdownlint-cli2 0.13.0 was rejecting the indented fence
inside the bullet because the fence's preceding line was the bullet
text (no blank).
- approve-merge SKILL.md line 172: typo `deferes` → `defers` (Rex flag
on PR #158).
Refs me2resh/apexyard#132.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
---------
Co-authored-by: me2resh <ahmed.abdelaliem@gmail.com>
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* chore(#157): remove voice-prompts feature + correct hook/skill counts (#161)
* chore(#157): remove voice-prompts-on-pause feature + correct hook/skill counts
Closes me2resh/apexyard#157 (sunset the voice-prompts feature) and
me2resh/apexyard#77 (hook count off-by-one in CHANGELOG / CLAUDE.md)
in one bundled PR. AgDR-0013 supersedes AgDR-0009 with the full
rationale; both AgDRs are preserved (decision records are append-only
history).
Removed (#157):
- .claude/hooks/voice-prompt-on-pause.sh
- .claude/hooks/tests/test_voice_prompt_on_pause.sh
- Stop matcher block in .claude/settings.json (became empty after
voice removal)
- voice_prompts block in .claude/project-config.defaults.json
- "## Voice prompts" section in docs/project-config.md
- voice_prompts mention in AgDR-0010 line 32 (replaced with
leak_protection / ticket as still-current example config blocks)
Preserved:
- docs/agdr/AgDR-0009-voice-prompts-on-pause.md — historical record;
new "Superseded by: AgDR-0013" header at the top
- AgDR-0010 line 115 reference to AgDR-0009 — still accurate as a
historical pattern reference
Counts corrected (#77):
- CHANGELOG.md v0.3.0 stats: "17 hooks" → "18 hooks" (historical
fix — at v0.3.0 there were actually 18 hooks)
- CLAUDE.md table line: "18 shell scripts" → "24 shell scripts"
(current count after this removal)
- CLAUDE.md table line: "35 slash commands" → "39 slash commands"
- CLAUDE.md "Available skills (34)" → "Available skills (39)"
- CLAUDE.md quick-reference "Skills (35 slash commands)" →
"(39 slash commands)"
Why bundled: #77's correct count depends on whether voice is still in
the framework. Shipping #77 before #157 would write a number that's
wrong by one again the moment #157 lands. Same shape as previous
bundles (PR #152 / AgDR-0011, PR #158 / AgDR-0012).
Why no adopter-facing changelog mention of the voice removal: the
feature never reached a tagged release on main. v1.1.0 didn't have
it; v1.2.0 won't have it. From the adopter's perspective there's
nothing to retire. AgDR-0013 captures the framework's internal record
for future contributors. See AgDR-0013 § "No adopter-facing changelog
mention".
Tests: full hook test suite green (196 cases across 12 files —
test_voice_prompt_on_pause.sh removed). No regressions.
Will manually close me2resh/apexyard#77 post-merge per the
single-Closes-per-PR rule (precedent: PRs #152, #158).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* chore(#157): unwire voice from settings + configs + docs + AgDR-0013
Continuation of d09d7b5 (the file deletions). Squash-merge will
collapse both into one PR commit. This commit captures:
- .claude/settings.json — Stop matcher block removed (was the only
hook in it; entire matcher gone)
- .claude/project-config.defaults.json — voice_prompts block + its
_comment removed
- docs/project-config.md — "## Voice prompts" section removed
- docs/agdr/AgDR-0009-voice-prompts-on-pause.md — "Superseded by"
header added at the top, content otherwise preserved as history
- docs/agdr/AgDR-0010-portfolio-config-and-self-healing.md — line 32
example reference swapped from voice_prompts to
leak_protection / ticket (still-current config blocks)
- docs/agdr/AgDR-0013-sunset-voice-prompts.md — new supersession AgDR
- CLAUDE.md — hook count 18 → 24, skill count 35 → 39 (three
occurrences each, all aligned to current reality)
- CHANGELOG.md v0.3.0 stats — "17 hooks" → "18 hooks" historical fix
(#77 acceptance criterion 1)
Refs me2resh/apexyard#157 + me2resh/apexyard#77.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* chore(#157): markdownlint MD028 + resolve stale AgDR-numbering ref
Three small fixups against Rex CHANGES-REQUESTED on PR #161:
- AgDR-0009 line 3: promote "Superseded by:" header out of a
blockquote. The original "I decided ..." canonical blockquote at
line 5 was being merged with the new supersession blockquote
(markdownlint MD028 — "no blanks inside blockquote").
- AgDR-0013 line 3: same shape — "Supersedes:" header now a plain
bold paragraph, canonical "I decided ..." blockquote untouched.
- approve-merge SKILL.md line ~187: stale conditional reference
"AgDR-0012 (or 0013 — depends on whether voice-removal lands
first)" — order is now resolved (12 = approve-merge bundle, 13 =
voice removal). Drop the parenthetical.
Refs me2resh/apexyard#157 + me2resh/apexyard#77.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
---------
Co-authored-by: me2resh <ahmed.abdelaliem@gmail.com>
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* feat(#160): multi-tab terminal demo on the landing site (#162)
Landing-site `site/index.html` terminal demo previously played one
canonical flow ("one ticket, start to finish") on autoplay. With the
v1.2.0 skill surface expansion (4 new skills, 8+ new hooks), one flow
no longer represents the framework's breadth.
Adds tabs to the terminal chrome — four flows visitors can either let
auto-cycle or click directly:
1. one ticket — existing flow, unchanged content
2. /handover — adopt an external repo into the portfolio
3. /setup — first-run framework bootstrap on a fresh fork
4. /fan-out — spawn 3 parallel agents on independent tickets
Auto-advance: on completion of the active tab's script, the demo
pauses ~1.8s then advances to the next tab. Loops at the end. User
can interrupt by clicking any tab or hitting Replay.
Implementation:
- HTML chrome — single title span replaced with a tablist of 4 button
tabs. ARIA `role="tablist"` / `role="tab"` / `aria-selected` so
keyboard + screen-reader users get the same semantics as sighted
ones.
- CSS — new `.shell-demo__tabs` + `.shell-demo__tab` with an accent
underline on the active tab. Tabs scroll horizontally on narrow
viewports (mobile responsive).
- JS — refactored the existing IIFE from one `script` array to an
array of four. Added `setActiveTab()` for ARIA state, `play(idx)`
takes a tab index, end-of-script auto-advances to `(idx + 1) % N`
unless the user clicked away during the pause. Adds a new `cmd`
type alongside `you` for slash-command invocations (renders with
the same `>` prompt prefix). prefers-reduced-motion still bails
early and leaves the static seed visible.
- Static seed (the non-JS fallback) still shows tab 0's content, so
reduced-motion / no-JS visitors see the one-ticket flow as before.
Hero metrics also corrected to current reality (#77 / PR #161 covers
CLAUDE.md and CHANGELOG.md; this PR catches the same numbers in the
landing site):
Skills 32 → 39
Hooks 18 → 24
The tabs ship in v1.2.0 alongside the framework changes that make
the new flows worth showcasing.
Refs me2resh/apexyard#160 (release v1.2.0 + landing-site refresh).
Co-authored-by: me2resh <ahmed.abdelaliem@gmail.com>
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* chore(#163): default the split-portfolio sibling repo name to <fork>-portfolio (#164)
Closes me2resh/apexyard#163.
The split-portfolio mode docs and skills previously suggested
`your-org/ops` as the default name for the private sibling repo, and
`portfolio/` as the local clone directory. Both too generic — adopters
running multiple ops setups end up with `your-org/ops` collisions, and
a bare `portfolio/` dir gives no signal about which framework it
belongs to when it sits next to other unrelated `portfolio/` dirs.
`<fork>-portfolio` is now the default — keeps the relationship to the
public fork explicit on disk and on GitHub. If the fork is named
`your-org/apexyard`, the portfolio defaults to
`your-org/apexyard-portfolio`. If the fork was renamed (e.g. `cos`),
the portfolio defaults to `cos-portfolio`. Adopters with custom names
keep working — the `portfolio:` config block resolves whatever path
they configured.
Files updated:
docs/multi-project.md
- Layout diagrams use `apexyard-portfolio/` as the sibling
- Setup walkthrough Step 2 + Step 3 use `your-org/apexyard-portfolio`
and explain the `<fork>-portfolio` pattern
- Config-block + symlink path examples updated to
`../apexyard-portfolio/...`
- Daily workflow + cross-machine clone commands updated
- The two existing `your-org/ops` references that remain are
fork-rename examples (lines 52, 64) — kept as-is, since renaming
the fork to `ops` is still valid (the portfolio would then
default to `ops-portfolio`)
.claude/skills/setup/SKILL.md
- Step 2b's "default suggestion" for the private repo name is now
`your-org/<fork>-portfolio`, computed dynamically from the
fork's repo name via `gh repo view --json name -q .name` so the
suggestion is correct even when the fork was renamed
- Clone command no longer needs a second arg — the repo name IS
the directory name
- Config-block paths updated to `../apexyard-portfolio/...`
.claude/skills/split-portfolio/SKILL.md
- Step 3's suggested-name template is now `<account>/<fork>-portfolio`
with the same dynamic-fork-name resolution
Mechanism unchanged. The `portfolio:` config block in
`.claude/project-config.json` still takes any path; this PR is purely
default-suggestion + example prose.
No tests required (skills are markdown instructions; no automated
coverage today).
Refs `apexyard.projects.yaml.example` uses "ops repo" as a generic
term meaning "the operational management fork" — not a name — kept
as-is.
Co-authored-by: me2resh <ahmed.abdelaliem@gmail.com>
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* feat(#165): skills reference page on the landing site + changelog link (#167)
Closes me2resh/apexyard#165.
Adds a public, browseable index of every apexyard slash command
alongside a one-click changelog link from the homepage nav.
site/skills.html (new):
- Lists all 39 skills currently shipping in .claude/skills/
- Each entry: slash command, argument hint, description (taken
verbatim from the SKILL.md frontmatter so the page matches the
runtime exactly)
- 10 categories: Setup & onboarding, Daily ops, Tickets & ideas,
Specs & decisions, Code review & merge, Architecture & dev tools,
Production-readiness audits, Workflow primitives, Communications,
Deprecated
- Same brutalist-terminal design tokens as the homepage — JetBrains
Mono, paper-cream background, single warning-red accent, sharp
corners. Inlined CSS to keep the static-only no-build-step
convention; design vars duplicated rather than extracted to a
shared file (~18 vars; cheap to keep in sync).
- Mobile responsive — skill grid collapses to single-column under
720px; titlebar nav hides non-CTA items on narrow viewports.
- Reduced-motion friendly (no animation in the first place).
- Internal anchor TOC at the top so the page scans in seconds.
site/index.html (nav addition):
- Added two nav links to the titlebar between "what's in the box"
and the github CTA:
• skills → ./skills.html
• changelog → https://github.com/me2resh/apexyard/releases
- The changelog link points at the GitHub releases page (not the
raw CHANGELOG.md file) so it auto-resolves to the latest tagged
release on each visit. v1.2.0 lands and the link is already there.
No new dependencies, no build step, no JS for the skills page. The
existing site convention (one-html-file-per-route, inlined CSS,
optional progressive-enhancement JS) is preserved.
Refs me2resh/apexyard#160 (release v1.2.0 + landing-site refresh) —
this is the second site-side deliverable for that ticket; the release
tag itself follows once me2resh/apexyard#159 (testing) closes.
Follow-up worth a separate ticket: a small generator script that
walks .claude/skills/*/SKILL.md, parses YAML frontmatter, and emits
the skills.html sections automatically. Out of scope for v1.2.0 —
first version is hand-curated and will need maintenance until that
generator lands.
Co-authored-by: me2resh <ahmed.abdelaliem@gmail.com>
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* chore(#168): accept release/vN.N.N branches + release(...) PR titles (#169)
Closes me2resh/apexyard#168.
The /release skill prescribed `release/vA.B.C` as the source-branch
name and `release: vA.B.C` as the PR title for the dev → main release
PR (per AgDR-0007). Both were rejected by the framework's own
validators:
validate-branch-name.sh required {type}/{TICKET-ID}-{description};
release/v1.2.0 has no ticket-id portion.
validate-pr-create.sh required type(SCOPE): form with `release` not
in pr.title_type_whitelist.
The contradiction surfaced cutting v1.2.0 — the first release under
the dev/main model.
Three small changes:
1. .claude/hooks/validate-branch-name.sh — added an early-out branch
that accepts ^release/vN.N.N(-rcN)?$ as a valid name. Narrow,
intentional exception for the framework's release-cut convention;
release branches don't carry a ticket-id because the release itself
IS the ticket.
2. .claude/project-config.defaults.json — added "release" to
pr.title_type_whitelist so a title like `release(#160): v1.2.0`
passes validate-pr-create.sh's existing regex unchanged.
3. .claude/skills/release/SKILL.md step 4 — corrected the prescribed
PR title to `release(#<release-ticket>): vA.B.C` so future /release
invocations produce a title that satisfies the validators by
construction.
Tested:
bash .claude/hooks/validate-branch-name.sh against:
release/v1.2.0 → 0 (allowed, release-special-case)
release/v1.2.0-rc1 → 0 (allowed, RC variant)
release/v9.9.9 → 0 (allowed)
release/foo → 2 (correctly blocked)
release/v1 → 2 (correctly blocked)
chore/GH-168-fix → 0 (allowed, standard pattern)
feature/GH-1-x → 0 (allowed, standard pattern)
Full hook test suite: 196/196 cases green across 12 test files.
Refs: surfaced 2026-05-04 cutting the first release under AgDR-0007.
Co-authored-by: me2resh <ahmed.abdelaliem@gmail.com>
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* chore(#170): exempt release/vN.N.N from validate-pr-create's branch-id check (#171)
Closes me2resh/apexyard#170.
Completes the work started in #169 (closing #168). #169 added a
release-pattern early-out to validate-branch-name.sh so release/vN.N.N
branches pass the branch-name validator. But validate-pr-create.sh has
its own independent branch-id check at line 273 that #169 didn't
touch — and it still rejects release/v1.2.0 because that name doesn't
contain a ticket-id substring.
This is the same class of contradiction #168 fixed; the fix is the
same shape. Add the same release-pattern early-out to the branch-id
check in validate-pr-create.sh:
- if the branch matches ^release/vN.N.N(-rcN)?$ → exempt (release
branches don't carry ticket-ids; the release itself is the ticket)
- otherwise → require a ticket-id substring as before
#168's acceptance criterion 3 ("validate-pr-create.sh accepts a PR
title `release(#160): v1.2.0` against the `release/v1.2.0` branch")
was checked off based on the title regex alone but didn't catch the
secondary branch-id check living in the same file. Surfaced trying
to open the v1.2.0 release PR.
Tested:
bash .claude/hooks/validate-pr-create.sh against:
release/v1.2.0 → 0 (allowed, exempt)
release/v1.2.0-rc1 → 0 (allowed, RC variant)
chore/GH-1-fix → 0 (allowed, has ticket-id)
release/foo → 2 (correctly blocked)
chore/no-ticket → 2 (correctly blocked)
Refs me2resh/apexyard#168 (the parent bug) + #169 (the partial fix).
Co-authored-by: me2resh <ahmed.abdelaliem@gmail.com>
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* chore(#173): sync CHANGELOG.md from main → dev (#174)
Closes me2resh/apexyard#173.
The release-cut model (AgDR-0007 / #116) squash-merges
release/vN.N.N → main, which means the v1.2.0 CHANGELOG section that
landed on main via PR #172 was never propagated back to dev. This
commit copies main's CHANGELOG.md verbatim onto dev so the v1.2.0
section is now present on both branches.
The diff is exactly the v1.2.0 entry being prepended; no other lines
change.
Without this sync, the next release PR cut from dev would build a
v1.3.0 section on top of v1.1.0, silently dropping v1.2.0 from dev's
running history. The corollary skill-level fix (option B in the
ticket) — updating /release to source the previous CHANGELOG from
upstream/main — is filed as a follow-up and out of scope for this PR.
Co-authored-by: me2resh <ahmed.abdelaliem@gmail.com>
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* feat(#181): /agdr skill — searchable AgDR library (#186)
Adds /agdr — a portfolio-wide index for Agent Decision Records.
Walks apexyard.projects.yaml, reads each project's docs/agdr/*.md
(local clone if available, else gh api fallback), parses the optional
YAML frontmatter for category + projects, and answers four queries:
- /agdr browse list across the portfolio, grouped by category
- /agdr search <term> full-text grep across all bodies, returns
<project>/AgDR-NNNN paths + matching paragraph
- /agdr show <id> print a specific record, disambiguates duplicates
- /agdr stats counts per category (the marketing-slide tile,
now backed by real data)
Six-category taxonomy: architecture | tech-stack | security | patterns
| integrations | other. Legacy AgDRs without frontmatter remain
first-class — they bucket as `other` and are flagged in browse so
operators can migrate at their own pace.
Backwards-compatible template change: templates/agdr.md gains an
optional `category:` (and optional `projects:`) line in the existing
frontmatter block. Omitting the line keeps every existing AgDR valid;
the skill defaults to `other` when missing.
Doc note in workflows/sdlc.md § Phase 2 points at /agdr search for
"have we decided this before?" lookups before drafting a design.
Smoke test in .claude/hooks/tests/test_agdr_skill.sh covers the
parser the spec specifies — frontmatter extraction, category
bucketing (including the legacy default-to-other path), id reading,
stats aggregation, and search match counts. 18 assertions, all green;
12 pre-existing test suites also green (no regressions).
Closes #181
Co-authored-by: me2resh <ahmed.abdelaliem@gmail.com>
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* feat(me2resh/apexyard#183): /launch-check trend tracking (#185)
- Persist each run as JSON under <projects_dir>/<name>/launch-check/runs/
(timestamp + branch + commit + per-dimension scores + verdict + top_risks)
- Append "Trend (last 5 runs)" section to the per-run summary when at least 2
prior runs exist — markdown table + ASCII score chart
- Add /launch-check trend mode for read-only trend rendering (no full audit)
- Auto-derive notes column from score-delta vs previous run
(e.g. "Security +12, Analytics +10")
- Opt-in commit via .launch-check-history-tracked marker; gitignored by default
- New helper script render-trend.sh + test_launch_check_trend.sh (21 cases)
- Resolve projects dir via portfolio_projects_dir helper (no hardcoded path)
- Schema is forward-compatible — extra fields preserved on framework upgrade
AgDR-0014 documents the chart format / schema / opt-in choices.
Closes me2resh/apexyard#183
Co-authored-by: me2resh <ahmed.abdelaliem@gmail.com>
* feat(#182): /status --briefing + bin/apexyard status CLI shim (#187)
* feat(me2resh/apexyard#182): /status --briefing + bin/apexyard CLI shim
Make slide 6's `$ apexyard status` invocation real — the smallest of three
slide-reality tickets, demonstrating the marketing-to-implementation
pattern before #181 / #183 land.
- New helper at .claude/skills/status/briefing.sh — computes the 4-line
"where am I" briefing (active workspace, active ticket, branch,
role-set) so the logic is testable in isolation and runnable from a
plain shell. Workspace inference walks up from cwd to the ops-fork
root (same algorithm as _lib-portfolio-paths.sh and /start-ticket).
- Ticket reads from .claude/session/tickets/<workspace> first, falls
back to .claude/session/current-ticket. Role-set is inferred from
the active ticket's GitHub labels (v1: backend / frontend / qa /
security / platform / sre / data / ux / ui / product / tech-lead,
plus the long forms). No match emits the explicit "<none — inferred
per task>" placeholder so the four-line shape is constant.
- New CLI shim bin/apexyard delegates `apexyard status` to the same
helper after walking up to find the ops-fork root. Works from any
workspace/<name>/ clone or the fork itself; symlink onto PATH to
install (no shadowing of the `claude` binary).
- /status SKILL.md gains a "Briefing mode" section documenting the
--briefing / -b flag; default /status output is unchanged.
- docs/multi-project.md "Daily workflow" demonstrates the new
invocation alongside /inbox and /status.
- New smoke tests at .claude/hooks/tests/test_status_briefing.sh — 8
cases covering ops-root cwd, workspace cwd, unknown cwd, ops-fallback
marker, per-project marker priority, label-based role inference, the
no-matching-label path, and the constant-four-line shape.
Closes me2resh/apexyard#182
* fix(me2resh/apexyard#182): replace curios-dog with example-app in SKILL.md output sample (leak fix)
---------
Co-authored-by: me2resh <ahmed.abdelaliem@gmail.com>
* docs(#178): LSP integration spike — measurement + recommendation (#184)
* docs(#178): LSP spike — token-savings measurement + integration findings
- Phase 1: estimated token cost A vs B for three representative queries on a real TS Lambda backend (~9,750 LOC); shallow semantic queries see ~3-23x input-token savings, multi-hop traces see ~1.4x
- Phase 2: verified Claude Code shipped first-party LSP support in v2.0.74 (Dec 2025), gated behind ENABLE_LSP_TOOL=1, wired in via the plugin system (.lsp.json); MCP-wrapped LSP shims (cclsp, lsp-mcp) remain as fallback
- Phase 3: recommends Option 3 — interactive clone-first prompt at end of /handover, preserving today's "never auto-clone" principle while making the deep-dive path discoverable
- Phase 4: AgDR Y-statement and option matrix sketched; full AgDR is a follow-up if the spike says go
- Recommendation: GO. Adopt the built-in tool, document the opt-in path, change /handover to offer clone-first interactively. No code changes beyond /handover SKILL.md; no novel integration to maintain
Closes me2resh/apexyard#178
* docs: fix markdownlint MD031/MD032 in spike report
Add blank lines around lists and a fenced code block to satisfy
markdownlint-cli2 in CI. Pure formatting, no content change.
Refs me2resh/apexyard#178
---------
Co-authored-by: me2resh <ahmed.abdelaliem@gmail.com>
* docs(me2resh/apexyard#190): annotate LSP-aware skills with opt-in callouts (#191)
- Add identical-shape "LSP-aware (optional, recommended)" callout near
the top of each of the four code-aware SKILL.md files.
- Per-skill savings number is the only variation:
- /code-review: ~3-15× cheaper for semantic queries
- /threat-model: ~3-15× shallow, ~1.4-5× multi-hop traces
- /security-review: ~3-15× cheaper for semantic querie…
Summary
Framework release v2.3.0 — 18 commits since v2.2.0, non-breaking (MINOR; 6 feats). Headlines: the Solution Architect design-review role + gate,
/launch-check --workflow, the build-agent self-review guardrails, and the pre-push gate wired to the framework's own CI. CHANGELOG and site are premium-scrubbed (no MCP / premium-component references).This PR will tag
v2.3.0onmainafter merge, followed by the mandatory/release-sync.CHANGELOG (v2.3.0)
Added
/design-review([Feature] Solution Architect — independent design-review role/agent (Rex for non-code) #471)/launch-check --workflow([Feature] /launch-check --workflow — opt-in parallel + adversarially-verified audit #473)/handoverchecklist-first doc selection ([Feature] /handover — checklist-first doc selection + per-doc template pick #480)/report-apexyard-bug+/request-apexyard-feature([Feature] /report-apexyard-bug + /request-apexyard-feature — upstream framework feedback skills #482)Changed
/releaseauto-bumps the marketing-site version + drift guard ([Chore] /release should bump marketing-site version strings (root cause of #491) #493)syncaccepted as a commit / branch / PR type ([Chore] /release-sync — reconcile sync type with branch/commit/PR whitelists #458)Fixed
dev([Chore] /release should bump marketing-site version strings (root cause of #491) #493)--merge([Chore] /release-sync — --squash defeats ancestry closure; require --merge for sync PRs #459)(Shipped tickets already closed individually on dev-merge: #458 #459 #461 #464 #469 #471 #473 #475 #478 #480 #482 #485 #487 #489 #493 #494 #501 #503 #506.)
Testing
bash .claude/hooks/tests/test_site_counts.sh→ PASS, incl. the version-drift guard (site softwareVersion=2.3.0 matches CHANGELOG top 2.3.0) and all framework counts.markdownlint-cli2 CHANGELOG.md→ 0 errors.!:markers in the v2.2.0→dev set. CHANGELOG + site swept clean of premium-component references.Closes #508
Glossary
test_site_counts.shcheck (#493) assertingsite/index.htmlsoftwareVersion equals the CHANGELOG top entry.