chore(#170): exempt release/vN.N.N from validate-pr-create's branch-id check#171
Merged
Merged
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #170. Completes the work started in #169 (closing #168). The release-pattern exemption was applied to
validate-branch-name.shbut the secondary branch-id check insidevalidate-pr-create.sh(line 273) was missed; this PR adds the same exemption there.One file edit, ~6 lines. Same regex (
^release/v\d+\.\d+\.\d+(-rc\d+)?$), same rationale ("release branches don't carry a ticket-id because the release itself is the ticket").#168's AC 3 was checked off based on the title regex alone; the second branch-id check inside the same file was missed. This PR closes that gap.
Why now
Same chain as #168. The v1.2.0 release PR can't open without this fix.
Testing
Validator probes against all relevant patterns:
No regression — full hook test suite still passes;
validate-pr-create.sh's other branches (Closes-keyword check, sections check, title regex check, issue-state check) are untouched.PR title + body format — title
chore(#170): ..., body has Summary / Why now / Testing / Glossary, singleCloses me2resh/apexyard#170keyword.Glossary
validate-pr-create.shfile. This PR completes that fix.^release/vN.N.N(-rcN)?$regex that recognises the framework's release-cut convention (AgDR-0007). Now applied identically in two validators (validate-branch-name.shfrom #169,validate-pr-create.shfrom this PR).[A-Z]{2,10}-[0-9]+,GH-[0-9]+,#[0-9]+). Independent of the branch-name format check.🤖 Generated with Claude Code