feat(#23): support Conventional Commits breaking-change marker#30
Merged
Merged
Conversation
Both validate-commit-format.sh and validate-pr-create.sh now accept the ! breaking-change marker per Conventional Commits 1.0: feat!: remove deprecated v1 endpoints feat(api)!: change response format to JSON:API feat(#42)!: breaking PR title with ticket ref The regex change is minimal — `!?` (optional exclamation mark) before the colon in both hooks' type regex. The marker is NOT required for breaking changes; it's just accepted as a valid form. Also updates .claude/rules/git-conventions.md to document the ! marker in both the PR Title Format and Commit Message Format sections, with examples. No BREAKING CHANGE: footer enforcement — the ! marker alone is sufficient per the Conventional Commits spec (the footer is explicitly marked optional when ! is used). Closes #23 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
me2resh
approved these changes
Apr 12, 2026
atlas-apex
commented
Apr 12, 2026
atlas-apex
left a comment
Collaborator
Author
There was a problem hiding this comment.
Code Review: PR #30
Commit: 5e3e85afd75a1badd419d62d499b4189150bbac9
Summary
Adds optional ! breaking-change marker to commit and PR-title validation hooks, plus docs update. Correct, minimal, well-tested.
Checklist Results
- ✅ Code Quality: Pass — regex change is precise (
!?before:) - ✅ Security: Pass — no secrets, no injection vectors
- ✅ PR Description & Glossary: Pass
- ✅ Technical Decisions (AgDR): N/A — no architectural choice, just spec-compliance fix
Issues Found
None.
Suggestions
None — clean PR.
Verdict
COMMENT — No blockers. Ready for CEO approval.
🤖 Reviewed by Rex (Code Reviewer Agent)
📌 Reviewed commit: 5e3e85afd75a1badd419d62d499b4189150bbac9
Dr-kersho
added a commit
to Dr-kersho/apexyard
that referenced
this pull request
May 20, 2026
…roadmap Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Both `validate-commit-format.sh` and `validate-pr-create.sh` now accept the `!` breaking-change marker per Conventional Commits 1.0. Minimal change — `!?` (optional) before the colon in both hooks' type regex. Also updates `.claude/rules/git-conventions.md` to document the marker with examples.
Closes #23
Examples now accepted
```
feat!: remove deprecated v1 endpoints
feat(api)!: change response format to JSON:API
feat(#42)!: breaking PR title with ticket ref
```
All non-breaking forms (`feat:`, `feat(scope):`, `feat(#42):`) continue to work unchanged.
Smoke tests (all 6 pass)
Glossary
Test plan
🤖 Generated with Claude Code