Context
Rex's review of #17 flagged that the commit-format regex and the PR-title regex in `git-conventions.md` both reject `feat!: breaking change` (the Conventional Commits 1.0 breaking-change marker). This is consistent between the hook and the existing convention, so it's not a bug — but Conventional Commits compliance is a common ask and the exclamation-mark marker is how most teams indicate breaking changes.
Design question
Do we want to support the Conventional Commits 1.0 breaking-change marker across the two hooks + the rule file?
Pro: industry-standard notation, some tools (semantic-release, commitlint, changelog generators) expect it.
Con: adds complexity, the existing `BREAKING CHANGE:` footer convention already handles the semantic need, and we'd have to decide whether to hard-block on missing `BREAKING CHANGE:` footer when `!` is present (Conventional Commits spec says it's optional when `!` is used).
Acceptance Criteria (if we decide to support it)
Non-goals
- Does NOT automate changelog generation from breaking-change markers.
- Does NOT integrate with semantic-release.
Links
Context
Rex's review of #17 flagged that the commit-format regex and the PR-title regex in `git-conventions.md` both reject `feat!: breaking change` (the Conventional Commits 1.0 breaking-change marker). This is consistent between the hook and the existing convention, so it's not a bug — but Conventional Commits compliance is a common ask and the exclamation-mark marker is how most teams indicate breaking changes.
Design question
Do we want to support the Conventional Commits 1.0 breaking-change marker across the two hooks + the rule file?
Pro: industry-standard notation, some tools (semantic-release, commitlint, changelog generators) expect it.
Con: adds complexity, the existing `BREAKING CHANGE:` footer convention already handles the semantic need, and we'd have to decide whether to hard-block on missing `BREAKING CHANGE:` footer when `!` is present (Conventional Commits spec says it's optional when `!` is used).
Acceptance Criteria (if we decide to support it)
Non-goals
Links