Remove port mention for URL protocol documentation#39000
Conversation
Current documentation for `protocol` was confusing because it said "this property contains an empty string", but actually referred to the `port` property? Possibly a copy & paste error.
Josh-Cena
approved these changes
Apr 6, 2025
Member
Josh-Cena
left a comment
There was a problem hiding this comment.
Thanks, great catch! I believe this was a copy paste mistake
wbamberg
added a commit
to wbamberg/content
that referenced
this pull request
Apr 6, 2025
* upstream/main: (158 commits) fix: remove unrelated add() method reference from openCursor() doc (mdn#38998) Fix link (mdn#38995) Remove uncovered topic from a tuturial overview. (mdn#38999) Change the description of Temporal.Instant (mdn#38996) Remove `port` mention for URL `protocol` documentation (mdn#39000) Improve the clarity of a sentence (mdn#39003) Change if...else to non-zero on control_flow page (mdn#38992) Update group-data of EditContext API (mdn#38842) improve description (mdn#38845) fix: auto-cleanup by bot (mdn#38990) New pages: HTMLFormElement.rel and .relList (mdn#38900) Add live sample embeds for SVG path examples (mdn#38928) Remove uncovered topic from the introduction (mdn#38986) Remove self-links (mdn#38982) Synchronize with BCD v6.0.3 (mdn#38983) Fix grammar (mdn#38981) Remove external Web Speech API articles (mdn#38980) Add missing {{Specifications}} macros (mdn#38975) Remove browser-compat for CSS types without BCD (mdn#38970) Update async_function_star_ to have a working example (mdn#38972) ...
cssinate
pushed a commit
to cssinate/content
that referenced
this pull request
Apr 11, 2025
Current documentation for `protocol` was confusing because it said "this property contains an empty string", but actually referred to the `port` property? Possibly a copy & paste error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove the mention of the
portproperty from the URLprotocoldocumentationMotivation
Current documentation for
protocolwas confusing because it said "this property contains an empty string", but actually referred to theportproperty?Possibly a copy & paste error?
Related issues and pull requests
Was introduced by #38029
@Josh-Cena, was the original change intentional, and am I maybe misunderstanding something here?