Skip to content

Update async_function_star_ to have a working example#38972

Merged
Josh-Cena merged 5 commits intomdn:mainfrom
jaenster:patch-1
Apr 4, 2025
Merged

Update async_function_star_ to have a working example#38972
Josh-Cena merged 5 commits intomdn:mainfrom
jaenster:patch-1

Conversation

@jaenster
Copy link
Copy Markdown
Contributor

@jaenster jaenster commented Apr 4, 2025

Description

The current example puts in the console [object Promise]

Motivation

The example now does what it says it does

@jaenster jaenster requested a review from a team as a code owner April 4, 2025 09:15
@jaenster jaenster requested review from Josh-Cena and removed request for a team April 4, 2025 09:15
@github-actions github-actions bot added Content:JS JavaScript docs size/s [PR only] 6-50 LoC changed labels Apr 4, 2025
jaenster and others added 4 commits April 4, 2025 11:16
…star_/index.md

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…star_/index.md

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Copy link
Copy Markdown
Member

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch. I've been meaning to fix this for a while. Thank you!

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 4, 2025

@Josh-Cena Josh-Cena merged commit 10f1c65 into mdn:main Apr 4, 2025
8 checks passed
@jaenster
Copy link
Copy Markdown
Contributor Author

jaenster commented Apr 5, 2025

Great catch. I've been meaning to fix this for a while. Thank you!

Oh the then example is way better, good change

wbamberg added a commit to wbamberg/content that referenced this pull request Apr 6, 2025
* upstream/main: (158 commits)
  fix: remove unrelated add() method reference from openCursor() doc (mdn#38998)
  Fix link (mdn#38995)
  Remove uncovered topic from a tuturial overview. (mdn#38999)
  Change the description of Temporal.Instant (mdn#38996)
  Remove `port` mention for URL `protocol` documentation (mdn#39000)
  Improve the clarity of a sentence (mdn#39003)
  Change if...else to non-zero on control_flow page (mdn#38992)
  Update group-data of EditContext API (mdn#38842)
  improve description (mdn#38845)
  fix: auto-cleanup by bot (mdn#38990)
  New pages: HTMLFormElement.rel and .relList (mdn#38900)
  Add live sample embeds for SVG path examples (mdn#38928)
  Remove uncovered topic from the introduction (mdn#38986)
  Remove self-links (mdn#38982)
  Synchronize with BCD v6.0.3 (mdn#38983)
  Fix grammar (mdn#38981)
  Remove external Web Speech API articles (mdn#38980)
  Add missing {{Specifications}} macros (mdn#38975)
  Remove browser-compat for CSS types without BCD (mdn#38970)
  Update async_function_star_ to have a working example (mdn#38972)
  ...
cssinate pushed a commit to cssinate/content that referenced this pull request Apr 11, 2025
* Update async_function_star_ to have a working example

* moved the await to a more logical place

* Update files/en-us/web/javascript/reference/operators/async_function_star_/index.md

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update files/en-us/web/javascript/reference/operators/async_function_star_/index.md

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update index.md

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Joshua Chen <sidachen2003@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Content:JS JavaScript docs size/s [PR only] 6-50 LoC changed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants