Skip to content

Better SameSite docs#38710

Merged
hamishwillee merged 3 commits intomdn:mainfrom
wbamberg:better-samesite
Mar 21, 2025
Merged

Better SameSite docs#38710
hamishwillee merged 3 commits intomdn:mainfrom
wbamberg:better-samesite

Conversation

@wbamberg
Copy link
Copy Markdown
Collaborator

@wbamberg wbamberg commented Mar 19, 2025

This PR tries to fix a few problems with the docs for SameSite:

  • the item for Strict seems to mix up site and origin: "If a request originates from a different domain or scheme (even with the same domain), no cookies with the SameSite=Strict attribute are sent."
  • it does not link to our definition of site.
  • it does not describe the subtle difference in Lax when it is used as the default (I've confirmed that this still the case in Chrome)
  • it includes a lot of quite irrelevant stuff under None

I also added some more examples of how Lax works, and deleted the bit about CHIPs: I don't think it's very useful to talk about what might happen in future browser versions.

@wbamberg wbamberg requested a review from a team as a code owner March 19, 2025 04:52
@wbamberg wbamberg requested review from hamishwillee and removed request for a team March 19, 2025 04:52
@github-actions github-actions bot added Content:HTTP HTTP docs size/s [PR only] 6-50 LoC changed labels Mar 19, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 19, 2025

Preview URLs

Flaws (1)

URL: /en-US/docs/Web/HTTP/Reference/Headers/Set-Cookie
Title: Set-Cookie
Flaw count: 1

  • unknown:
    • No generic content config found

(comment last updated: 2025-03-21 05:18:18)

wbamberg and others added 2 commits March 20, 2025 22:15
Co-authored-by: Hamish Willee <hamishwillee@gmail.com>
Co-authored-by: Hamish Willee <hamishwillee@gmail.com>
Copy link
Copy Markdown
Collaborator

@hamishwillee hamishwillee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THanks very much!

@hamishwillee hamishwillee merged commit 1aa58c8 into mdn:main Mar 21, 2025
8 checks passed
wbamberg added a commit to wbamberg/content that referenced this pull request Apr 4, 2025
* upstream/main: (172 commits)
  chore: improve code style guide (mdn#38715)
  fix: typo on `Error.isError()` page (mdn#38754)
  plural consistency (mdn#38747)
  fix: auto-cleanup by bot (mdn#38695)
  Synchronize with BCD v5.7.4 (mdn#38709)
  Add docs for JS self-profiling API (mdn#37796)
  Better SameSite docs (mdn#38710)
  Added missing explanation for Array Literals (mdn#38745)
  Add a page on CSRF (mdn#38151)
  Fix description of several Range methods (mdn#38518)
  Remove extraneous span (mdn#38696)
  Add a definition for media containers, improve how the media files are defined and Remove wrong information (mdn#38721)
  Move visited selector guide to CSS selectors module (mdn#38642)
  Make JSON learning article more technically precise (mdn#38644)
  Make translate3d() interactive example code valid (mdn#38647)
  Clarity on Safari support for custom elements (mdn#38727)
  feat(css): Link to learning doc about text direction (mdn#38719)
  Fix typo (mdn#38739)
  move guide to module: inline formatting context (mdn#38637)
  Fix CSS pseudo-class lists (mdn#38576)
  ...
cssinate pushed a commit to cssinate/content that referenced this pull request Apr 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Content:HTTP HTTP docs size/s [PR only] 6-50 LoC changed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants