Skip to content

Remove extraneous span#38696

Merged
Josh-Cena merged 3 commits intomdn:mainfrom
deathcrafter:patch-1
Mar 20, 2025
Merged

Remove extraneous span#38696
Josh-Cena merged 3 commits intomdn:mainfrom
deathcrafter:patch-1

Conversation

@deathcrafter
Copy link
Copy Markdown
Contributor

Description

In the second example of ARIA Role "menu", fix text "Purple" outside if span element.

Motivation

This fixes an unintended mistake in the example possibly causing confusion over an empty element.

@deathcrafter deathcrafter requested a review from a team as a code owner March 18, 2025 13:26
@deathcrafter deathcrafter requested review from scottaohara and removed request for a team March 18, 2025 13:26
@github-actions github-actions bot added Content:Accessibility Accessibility docs size/s [PR only] 6-50 LoC changed labels Mar 18, 2025
Comment on lines +133 to +135
<span>
Purple
</span>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[mdn-linter] reported by reviewdog 🐶

Suggested change
<span>
Purple
</span>
<span> Purple </span>

@github-actions github-actions bot added size/xs [PR only] 0-5 LoC changed and removed size/s [PR only] 6-50 LoC changed labels Mar 18, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 20, 2025

@Josh-Cena Josh-Cena changed the title Fix text "Purple" outside of <span> at line 133 Remove extraneous span Mar 20, 2025
@Josh-Cena Josh-Cena merged commit 4fb534a into mdn:main Mar 20, 2025
8 checks passed
wbamberg added a commit to wbamberg/content that referenced this pull request Apr 4, 2025
* upstream/main: (172 commits)
  chore: improve code style guide (mdn#38715)
  fix: typo on `Error.isError()` page (mdn#38754)
  plural consistency (mdn#38747)
  fix: auto-cleanup by bot (mdn#38695)
  Synchronize with BCD v5.7.4 (mdn#38709)
  Add docs for JS self-profiling API (mdn#37796)
  Better SameSite docs (mdn#38710)
  Added missing explanation for Array Literals (mdn#38745)
  Add a page on CSRF (mdn#38151)
  Fix description of several Range methods (mdn#38518)
  Remove extraneous span (mdn#38696)
  Add a definition for media containers, improve how the media files are defined and Remove wrong information (mdn#38721)
  Move visited selector guide to CSS selectors module (mdn#38642)
  Make JSON learning article more technically precise (mdn#38644)
  Make translate3d() interactive example code valid (mdn#38647)
  Clarity on Safari support for custom elements (mdn#38727)
  feat(css): Link to learning doc about text direction (mdn#38719)
  Fix typo (mdn#38739)
  move guide to module: inline formatting context (mdn#38637)
  Fix CSS pseudo-class lists (mdn#38576)
  ...
cssinate pushed a commit to cssinate/content that referenced this pull request Apr 11, 2025
* Fix text "Purple" outside of <span> at line 133

* Fix linter error

* Update files/en-us/web/accessibility/aria/reference/roles/menu_role/index.md

---------

Co-authored-by: Joshua Chen <sidachen2003@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Content:Accessibility Accessibility docs size/xs [PR only] 0-5 LoC changed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants