Remove RTCRtpEncodingParameters API from BCD#19584
Conversation
This PR removes the `RTCRtpEncodingParameters` API from BCD. This feature is a type (ex. a dictionary, enum, mixin, constant or WebIDL typedef) that we have explicitly stated not to document separately from the feature(s) that depend on it, as they are virtually invisible to the end developer.
|
This pull request has merge conflicts that must be resolved before it can be merged. |
|
@queengooborg This adds features for However the
Can you update/test those cases too? See also #19584 (comment) Docs are in progress in mdn/content#30080 |
|
FF - the properties like Because I know the intent is to remove them, we have know way of knowing when they may have existed or not in reality, and they are non-spec, I am completely removing those entries. |
|
FYI @queengooborg The corresponding docs merged, so these questions need to be addressed please. |
Co-authored-by: Hamish Willee <hamishwillee@gmail.com>
Elchi3
left a comment
There was a problem hiding this comment.
Safari 11 should probably be used (was 11 in the dictionary too)
Elchi3
left a comment
There was a problem hiding this comment.
Thanks @queengooborg and @hamishwillee! 👍 I've cleaned this up so that it can be merged. We can always send follow-up PRs to correct the data further.
|
Thanks very much! |
* Remove RTCRtpEncodingParameters API from BCD This PR removes the `RTCRtpEncodingParameters` API from BCD. This feature is a type (ex. a dictionary, enum, mixin, constant or WebIDL typedef) that we have explicitly stated not to document separately from the feature(s) that depend on it, as they are virtually invisible to the end developer. * Fix consistency * Remove never supported parameters Co-authored-by: Hamish Willee <hamishwillee@gmail.com> * Safari 12.1 -> Safari 11 * Safari 11 for setParameters (like getParameters) * Safari 11 for encoding tree as well --------- Co-authored-by: Florian Scholz <fs@florianscholz.com> Co-authored-by: Hamish Willee <hamishwillee@gmail.com>
This PR removes the
RTCRtpEncodingParametersAPI from BCD. This feature is a type (ex. a dictionary, enum, mixin, constant or WebIDL typedef) that we have explicitly stated not to document separately from the feature(s) that depend on it, as they are virtually invisible to the end developer.