Skip to content

RTCRtpEncodingParameters - removal#30080

Merged
teoli2003 merged 6 commits intomdn:mainfrom
hamishwillee:rtcrtp_encodingparameters
Nov 10, 2023
Merged

RTCRtpEncodingParameters - removal#30080
teoli2003 merged 6 commits intomdn:mainfrom
hamishwillee:rtcrtp_encodingparameters

Conversation

@hamishwillee
Copy link
Collaborator

@hamishwillee hamishwillee commented Nov 7, 2023 •
edited
Loading

This removes the RTCRtpEncodingParameters dictionary, pushing its properties into the places where they are used

  • RTCPeerConnection.addTransceiver() (just cross link to RTCPeerConnection.setParameters())
  • RTCRtpSender.getParameters
  • RTCPeerConnection.setParameters()
  • Delete RTCRtpEncodingParameters

Note that this removes fec, rtx, srcc from the returned values as these are non standard and not actually returned by firefox.

Associated BCD is here: mdn/browser-compat-data#19584

@github-actions github-actions bot added Content:WebAPI Web API docs Content:Firefox Content in the Mozilla/Firefox subtree labels Nov 7, 2023
hamishwillee
hamishwillee commented Nov 7, 2023
View reviewed changes
hamishwillee
hamishwillee commented Nov 7, 2023
View reviewed changes
hamishwillee
hamishwillee commented Nov 7, 2023
View reviewed changes
@github-actions
Copy link
Contributor

github-actions bot commented Nov 7, 2023 •
edited
Loading

Preview URLs (6 pages)
Flaws (9)

Note! 3 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Mozilla/Firefox/Releases/64
Title: Firefox 64 for developers
Flaw count: 2

  • macros:
    • /en-US/docs/Web/CSS/::-moz-tree does not exist
  • broken_links:
    • Can't resolve /en-US/docs/Mozilla/Gecko/Chrome/CSS/display-xul

URL: /en-US/docs/Web/API/RTCRtpSender/getParameters
Title: RTCRtpSender: getParameters() method
Flaw count: 1

  • macros:
    • /en-US/docs/Web/API/RTCRtcpParameters does not exist

URL: /en-US/docs/Web/API/RTCRtpSender/setParameters
Title: RTCRtpSender: setParameters() method
Flaw count: 6

  • macros:
    • /en-US/docs/Web/API/RTCRtcpParameters does not exist
    • /en-US/docs/Web/API/RTCRtpEncodingParameters/maxFramerate redirects to /en-US/docs/Web/API/RTCRtpSender/setParameters
    • /en-US/docs/Web/API/RTCRtpEncodingParameters/maxBitrate redirects to /en-US/docs/Web/API/RTCRtpSender/setParameters
    • /en-US/docs/Web/API/RTCRtpEncodingParameters/scaleResolutionDownBy redirects to /en-US/docs/Web/API/RTCRtpSender/setParameters
    • /en-US/docs/Web/API/RTCRtpEncodingParameters/scaleResolutionDownBy redirects to /en-US/docs/Web/API/RTCRtpSender/setParameters
    • and 1 more flaws omitted
External URLs (1)

URL: /en-US/docs/Mozilla/Firefox/Releases/64
Title: Firefox 64 for developers

(comment last updated: 2023-11-10 01:34:39)

hamishwillee
hamishwillee commented Nov 7, 2023
View reviewed changes
@hamishwillee hamishwillee changed the title RTCRtpEncodingParameters - move into RTCRtpSender.setParameters() RTCRtpEncodingParameters - removal Nov 7, 2023
hamishwillee
hamishwillee commented Nov 7, 2023
View reviewed changes
files/en-us/web/api/rtcpeerconnection/addtransceiver/index.md
- `sendEncodings` {{optional_inline}}
- : A list of encodings to allow when sending RTP media from the {{domxref("RTCRtpSender")}}. Each entry is of type {{domxref("RTCRtpEncodingParameters")}}.
- : An array of encodings to allow when sending RTP media from the {{domxref("RTCRtpSender")}}.
This is the same as the [`parameter.encodings`](/en-US/docs/Web/API/RTCRtpSender/setParameters#encodings) array passed to {{domxref("RTCRtpSender.setParameters()")}}.
Copy link
Collaborator Author

@hamishwillee hamishwillee Nov 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Decided to cross link to RTCPeerConnection.setParameters() since this should be identical.

hamishwillee
hamishwillee commented Nov 7, 2023
View reviewed changes
@hamishwillee hamishwillee mentioned this pull request Nov 7, 2023
Merged
@github-actions github-actions bot added the merge conflicts 🚧 [PR only] label Nov 9, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Nov 9, 2023

This pull request has merge conflicts that must be resolved before it can be merged.

@hamishwillee hamishwillee force-pushed the rtcrtp_encodingparameters branch from e4d9ebf to fc068b7 Compare November 10, 2023 01:31
@github-actions github-actions bot removed the merge conflicts 🚧 [PR only] label Nov 10, 2023
@hamishwillee hamishwillee marked this pull request as ready for review November 10, 2023 01:33
@hamishwillee hamishwillee requested review from a team as code owners November 10, 2023 01:33
@hamishwillee hamishwillee requested review from Elchi3 and removed request for a team November 10, 2023 01:33
teoli2003
teoli2003 approved these changes Nov 10, 2023
View reviewed changes
Copy link
Contributor

@teoli2003 teoli2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@teoli2003 teoli2003 merged commit 1f48c7c into mdn:main Nov 10, 2023
@hamishwillee hamishwillee deleted the rtcrtp_encodingparameters branch November 12, 2023 23:30
@Josh-Cena Josh-Cena mentioned this pull request Jun 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Elchi3 Elchi3 Awaiting requested review from Elchi3 Elchi3 was automatically assigned from mdn/yari-content-web-api

1 more reviewer

@teoli2003 teoli2003 teoli2003 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Content:Firefox Content in the Mozilla/Firefox subtree Content:WebAPI Web API docs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hamishwillee @teoli2003