Enforce alphabetical order of browsers in the support block#1882
Enforce alphabetical order of browsers in the support block#1882Elchi3 merged 5 commits intomdn:masterfrom
support block#1882Conversation
73f64c6 to
e8f5132
Compare
94b2bdf to
feb1101
Compare
3a5aa91 to
ddf95bf
Compare
|
Thanks for working on this! |
|
Yes, we can do this soon. There are other PRs that affect many files, though. Trying to get in #1356 for example, so maybe wait a bit before rebasing. |
fbf4997 to
31b7147
Compare
|
577 files left to go! :D |
|
The backlog is relatively small now. I would review a PR that sorts |
|
@Elchi3 Ask and ye shall receive. 😉 |
|
This needs to be rebased now and then we might be able to finally enforce this :) |
|
😱🥳 |
|
Sorry, I didn't see that you pushed a merge here. Latest master has two new issues now unfortunately: Seeing these messages, I wonder if we should have a better error message. Especially to new contributors it might not be obvious what we want here. |
+1 -- it's not the most descriptive error message in the world, haha. 😛 |
|
I've resolved the conflict here and added a (naive) special case to see how this could look like. It now outputs this against master for me: I think this looks like a better error message. What do you think about this, @ExE-Boss? Do you want to rebase and land this then? |
|
Let’s finally land this. |
Elchi3
left a comment
There was a problem hiding this comment.
This should pass on master now. r+
Thanks for your work! 👍
Depends on #2889
Fixes #398
Closes #1474; Closes #2890