Skip to content

Add Firefox for iOS#2332

Closed
ExE-Boss wants to merge 6 commits intomdn:masterfrom
ExE-Boss:browsers/firefox-ios
Closed

Add Firefox for iOS#2332
ExE-Boss wants to merge 6 commits intomdn:masterfrom
ExE-Boss:browsers/firefox-ios

Conversation

@ExE-Boss
Copy link
Contributor

There are plans for Firefox for iOS to support lightweight themes, probably by using the WebExtensions theme manifest keys.

@ExE-Boss ExE-Boss force-pushed the browsers/firefox-ios branch from e6aa34a to 1e71e84 Compare June 17, 2018 18:55
@connorshea
Copy link
Contributor

I'd be concerned that some contributors might try to add data about Firefox for iOS to properties that aren't WebExtensions-related, which doesn't really have a point because of iOS browsers all just using WebKit as their engine.

@ExE-Boss
Copy link
Contributor Author

ExE-Boss commented Jun 17, 2018

Well, which browsers are visible for which category is controlled by browser‑compat‑toolkit (and kumascript), so even if someone were to try to add Firefox for iOS to non-WebExtension features, it wouldn’t show up in MDN anyway.

@Elchi3 Elchi3 added question Issues where a question or problem is stated and a discussion is held to gather opinions. data:browsers Data about browsers (versions, release dates, etc). This data is used for validation. labels Jun 20, 2018
@ExE-Boss ExE-Boss force-pushed the browsers/firefox-ios branch from 8f045b5 to 9f2ed92 Compare June 27, 2018 01:17
@connorshea
Copy link
Contributor

Regarding my previous comment, I wonder if we shouldn’t have the linter check for certain browsers in certain feature categories? E.g. Firefox for iOS info being added for a feature in html/ would cause the linter to fail. I think that’d make it easier to add these “edge-case” browses safely.

@ExE-Boss
Copy link
Contributor Author

ExE-Boss commented Jul 17, 2018

At first, I thought that wouldn’t be a problem, but after seeing #2484, I’ll add that to the linter in a separate PR.

Update: I have now opened PR #2487 to add that.

@Elchi3
Copy link
Member

Elchi3 commented Aug 29, 2018

There is still no implementation of themes in Firefox for iOS. I think it is too early to even add Firefox iOS to this repo (even if it is just for webextensions). Implementation might never happen at all and I think it is too much overhead for us now to maintain this here. What do you think @wbamberg?

@wbamberg
Copy link
Contributor

I think it is too early to even add Firefox iOS to this repo (even if it is just for webextensions). Implementation might never happen at all and I think it is too much overhead for us now to maintain this here. What do you think @wbamberg?

I agree.

@Elchi3
Copy link
Member

Elchi3 commented Aug 29, 2018

I'm closing here then. We can re-consider this if it should become a reality.

@Elchi3 Elchi3 closed this Aug 29, 2018
@Elchi3 Elchi3 added wontfix 👎 and removed question Issues where a question or problem is stated and a discussion is held to gather opinions. labels Aug 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

data:browsers Data about browsers (versions, release dates, etc). This data is used for validation.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants