Ensure that some browsers are only allowed in specific categories#2487
Ensure that some browsers are only allowed in specific categories#2487Elchi3 merged 6 commits intomdn:masterfrom
Conversation
|
I think this is no longer relevant now. In #3160 we've seen that node implements some features in api/ land and so that validation isn't really useful anymore. For the other edge case browsers, we have decided to not add them to the repo. I could imagine to test for webextension-only browsers, but I'm not sure if it is really neeeded. What do you think, @ExE-Boss ? |
|
I think it might be useful. |
Elchi3
left a comment
There was a problem hiding this comment.
Okay cool, then I would like to reduce the scope of this to only test for WebExtension browsers.
fec9edc to
683e8c5
Compare
|
The way I understand it, the goal for MDN is to only display Node in the |
Elchi3
left a comment
There was a problem hiding this comment.
The nodejs removals are fine with me, thanks.
I have a few suggestions to the new test, but generally it is nicely done. Thanks for your work 👍
Please see my comments inline.
Elchi3
left a comment
There was a problem hiding this comment.
Thank you, this looks good to me now. 👍
This has been suggested by @connorshea in #2332 (comment), and I agree that it’s a good idea, as it ensures that contributors don’t try to add
firefox_iosorthunderbirdto non‑WebExtension entries, ornodejsto non‑JavaScript entries (which it turns out they already did).It also ensures that PRs like #2484 get better error messages.
review?(@a2sheppy, @Elchi3)