Skip to content

Sort browser compatibility order#2889

Closed
queengooborg wants to merge 7 commits intomdn:masterfrom
queengooborg:alphabetical-browser-order
Closed

Sort browser compatibility order#2889
queengooborg wants to merge 7 commits intomdn:masterfrom
queengooborg:alphabetical-browser-order

Conversation

@queengooborg
Copy link
Contributor

@queengooborg queengooborg commented Oct 1, 2018 •
edited
Loading

This PR is intended to sort the browsers' order in all of the existing files and adhere to the new style linting proposed by #1474. This is one of two PRs that supersedes #1474, whereas the other one (#2890 #1882) includes the linting test itself. I will be updating changes on a daily or bi-daily basis to ensure compatibility.

WARNING: this may break PRs that modify existing data and require them to rebase.

@queengooborg queengooborg mentioned this pull request Oct 1, 2018
Closed
@ExE-Boss
Copy link
Contributor

ExE-Boss commented Oct 1, 2018

This should not close #1882!

@ExE-Boss ExE-Boss mentioned this pull request Oct 1, 2018
Merged
@queengooborg
Copy link
Contributor Author

queengooborg commented Oct 1, 2018

Fixed to leave #1882 open -- as mentioned in the other PR, I assumed it was only for the data, whoops!

@Elchi3 you up for merging this, or would you rather get the PR backlog down a little more?

@Elchi3
Copy link
Member

Elchi3 commented Oct 2, 2018

@Elchi3 you up for merging this, or would you rather get the PR backlog down a little more?

I don't think it is useful create merge conflicts for open PRs that actually do useful stuff. I mean sorting is useful, too, but this kind of PR can be created programmatically at any time and other PRs often can't. So I think it would have been appropriate to ask in existing sorting PRs like #1882 what the plan is before investing the time :)

@Elchi3
Copy link
Member

Elchi3 commented Oct 2, 2018 •
edited
Loading

I will review and accept separate PRs for the following folders, because they don't break existing PRs.
(It might make sense to have one PR per folder to ease reviewing.)

  • html/
  • http/
  • javascript/
  • mathml/
  • svg/
  • webdriver/

I will let know you when is a good time to proceed with the rest. Thank you!

@ExE-Boss
Copy link
Contributor

ExE-Boss commented Oct 2, 2018

Well, XSLT and XPath data was so far contributed entirely by me in #2026 and #2287, so they’re currently sorted.

@queengooborg queengooborg force-pushed the alphabetical-browser-order branch from ab09dbc to ab3d9d3 Compare October 2, 2018 16:32
@queengooborg
Copy link
Contributor Author

queengooborg commented Oct 2, 2018

Alright, cherry-picking it is! Sending separate PRs shortly. 😉

@queengooborg queengooborg deleted the alphabetical-browser-order branch October 2, 2018 16:41
@Elchi3
Copy link
Member

Elchi3 commented Oct 4, 2018

The PR backlog for css/* is low enough now as well, I think.

@queengooborg
Copy link
Contributor Author

queengooborg commented Oct 4, 2018

PR for css/* has now been made!

@queengooborg queengooborg added bulk_update An update to a mass amount of data, or scripts/linters related to such changes invalid Invalid issues or pull requests (wrong repo, spam, duplicates, etc.). This won't get merged. Sorry! labels Aug 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

bulk_update An update to a mass amount of data, or scripts/linters related to such changes invalid Invalid issues or pull requests (wrong repo, spam, duplicates, etc.). This won't get merged. Sorry!

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@queengooborg @ExE-Boss @Elchi3