Walkthrough

Updates the Node.js runtime target in .nvmrc and refactors browser feature-detection in Client.ts to use guarded helpers; three Vite example configs adjust chunkSizeWarningLimit numbers.

Changes

Sequence Diagram(s)

sequenceDiagram
    autonumber
    participant Init as App initialization
    participant Client as Client.static init
    participant Guards as Guard helpers (isWindow..., isUserAgent...)
    Note over Client: Old flow: direct access to window/navigator
    Init->>Client: trigger static initializers
    Client->>Guards: call isWindowObjectAvailable()
    Guards-->>Client: true/false
    alt window available
        Client->>Guards: call isUserAgentIncludes(...)/isAppVersionIncludes(...)
        Guards-->>Client: boolean results
        Client-->Init: set static flags (IS_EDGE, IS_SF, IS_ANDROID, ...)
    else non-browser context
        Client-->Init: set static flags to safe defaults (false/undefined)
    end
    Note over Guards: Guards avoid direct undefined property access and use optional chaining where applicable

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

• Reasoning: logic-level changes in a core Client initialization file plus small config edits across multiple packages—requires reading the guard implementations and verifying each static flag mapping.
• Pay extra attention to:
  • packages/core/src/Client.ts — correctness of guard implementations and any edge cases (SSR/non-browser environments).
  • Preservation of public/static property semantics and types.
  • No regressions from Vite config numeric tweaks (build warnings only).

Possibly related PRs

• chore: build with node 22 #937 — also updates .nvmrc to bump Node.js from 20 to 22; likely related to the same runtime target change.

Pre-merge checks and finishing touches

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

⚠️ when running js-example-nodejs with node 22, an error occurs on macos and ubuntu. This works well with node 20

$ npm run build

> build
> run-s build:*


> build:esm
> node src/index.mjs

file:///maxGraph/maxGraph/packages/core/lib/esm/Client.js:84
Client.IS_ANDROID = typeof window !== 'undefined' && navigator.appVersion.indexOf('Android') >= 0;
                                                                          ^

TypeError: Cannot read properties of undefined (reading 'indexOf')
    at file://maxGraph/maxGraph/packages/core/lib/esm/Client.js:84:75
    at ModuleJob.run (node:internal/modules/esm/module_job:345:25)
    at async onImport.tracePromise.__proto__ (node:internal/modules/esm/loader:665:26)
    at async asyncRunEntryPointWithESMLoader (node:internal/modules/run_main:117:5)

Quality Gate failed

Failed conditions
C Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE