Conversation
20d1a61 to
f4a116e
Compare
e7ba310 to
4de47b5
Compare
f4a116e to
7428298
Compare
7428298 to
c7c88c2
Compare
- Remove redundant mutexes around CallbackList as they are protected inside. - Added a mutex around components.
c7c88c2 to
d20e05c
Compare
It's enough to have duplication between mavsdk.h and mavlink_direct.h which is currently unavoidable because mavlink_direct is auto-generated, but we really shouldn't have it inside of mavsdk as well.
|
julianoes
added a commit
that referenced
this pull request
Jan 6, 2026
This restores the original behavior where the intercept callback is called before message forwarding, allowing users to modify or drop messages before they are forwarded to other connections. With this fix: - Modifications in intercept callback affect forwarded messages - Dropping a message (returning false) prevents forwarding The behavior had been changed by accident in: #2638
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a new interception API based on the libmav JSON integration (see #2610), avoiding the MAVLink C header depend dependency. The JSON based API will replace the previous one by the next major release.
Currently on top of #2637.